search for: add_dom

...#39;lblocksize' respectively. I've tried to avoid long names like 'physicalblocksize' while keeping readability and semantic. - Do we want to add the same optional parameters to 'add_drive_scratch' API method? I think it would be nice but it is up to you. - What about 'add_dom', 'add_libvirt_dom' API methods? Should they also handle 'blokio' tag in domain XML and act respectively? - Anything else I didn't spot yet? - Do we want guestfish to accept physical/logical block size per drive from command line? - What about other virt tools like virt-df,...

...and semantic. If we only have one, we can use "blocksize". But it does require us to answer the previous one. > - Do we want to add the same optional parameters to 'add_drive_scratch' > API method? I think it would be nice but it is up to you. It should also be added to add_domain and add_libvirt_dom (note all the APIs which have 'discard' and 'copyonread' already). It could be added to add_drive_scratch, I guess. However it doesn't seem very useful for scratch drives (why create a scratch drive with 4K sectors which will be thrown away in the end?)...

...take logical_block_size and attach disk to libguestfs with physical_block_size == logical_block_size. > > - Do we want to add the same optional parameters to 'add_drive_scratch' > > API method? I think it would be nice but it is up to you. > > It should also be added to add_domain and add_libvirt_dom (note all > the APIs which have 'discard' and 'copyonread' already). Yeah, already did that. > It could be added to add_drive_scratch, I guess. However it doesn't > seem very useful for scratch drives (why create a scratch drive with > 4K se...