search for: adconrad

Otherwise, stack can be corrupted resulting in incorrect runtime behaviour. For example, overriding argc from main(). References: https://bugs.launchpad.net/ubuntu/+source/klibc/+bug/1850184 Signed-off-by: Michael Hudson-Doyle <michael.hudson at ubuntu.com> Signed-off-by: Adam Conrad <adconrad at ubuntu.com> Signed-off-by: Dimitri John Ledkov <xnox at ubuntu.com> --- usr/utils/loop.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr/utils/loop.h b/usr/utils/loop.h index 9abc2874..667f7dc0 100644 --- a/usr/utils/loop.h +++ b/usr/utils/loop.h @@ -15,9 +1...

---------- Forwarded message ---------- From: Adam Conrad <adconrad at 0c3.net> Message-ID: <157106879908.15546.2658970073129703906.malone at soybean.canonical.com> 2.0.7-1 fails to build in the same way on Ubuntu 19.10. I'm assuming it's either glibc 2.30 (Debian is at 2.29) or linux 5.3 (Debian is at 5.2), with the latter being more likely....

Hrm, perhaps adding the flag (or the matching __attribute__) only to where it is needed makes sense? --mirabilos ---------- Forwarded message ---------- From: Adam Conrad <adconrad at 0c3.net> Message-ID: <157169641305.9361.4432909657455952189.malone at soybean.canonical.com> Date: Mon, 21 Oct 2019 22:20:12 -0000 Subject: [Bug 1843743] Re: klibc ftbfs in eoan Reply-To: Bug 1843743 <1843743 at bugs.launchpad.net> > The best guess I can come up with is that t...

...p.h header is exported by linux, for userspace to consume. This would prevent issues with struct sizes incompatibilities. References: https://bugs.launchpad.net/ubuntu/+source/klibc/+bug/1850184 Signed-off-by: Michael Hudson-Doyle <michael.hudson at ubuntu.com> Signed-off-by: Adam Conrad <adconrad at ubuntu.com> Signed-off-by: Dimitri John Ledkov <xnox at ubuntu.com> --- usr/utils/loop.h | 49 --------------------------------------------- usr/utils/losetup.c | 3 +-- 2 files changed, 1 insertion(+), 51 deletions(-) delete mode 100644 usr/utils/loop.h diff --git a/usr/utils/lo...

...ion in the header, does not match the kernel's definition (on most architectures) which leads to undefined behaviour. References: https://bugs.launchpad.net/ubuntu/+source/klibc/+bug/1850184 Signed-off-by: Michael Hudson-Doyle <michael.hudson at ubuntu.com> Signed-off-by: Adam Conrad <adconrad at ubuntu.com> Signed-off-by: Dimitri John Ledkov <xnox at ubuntu.com> --- Updated patch description, based on feedback on the mailing list. usr/utils/loop.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr/utils/loop.h b/usr/utils/loop.h index 9abc2874..667...

...p.h header is exported by linux, for userspace to consume. This would prevent issues with struct sizes incompatibilities. References: https://bugs.launchpad.net/ubuntu/+source/klibc/+bug/1850184 Signed-off-by: Michael Hudson-Doyle <michael.hudson at ubuntu.com> Signed-off-by: Adam Conrad <adconrad at ubuntu.com> Signed-off-by: Dimitri John Ledkov <xnox at ubuntu.com> [bwh: We were using dev_t instead of __kernel_old_dev_t, which doesn't match on some architectures. Instead of fixing our definition first, switch directly to the kernel's UAPI header.] Signed-off-by: Ben Hut...

...;} [tuxguitar-jack] tuxguitar-jack: Jackd2 Changed Bug submitter to 'Torquil Macdonald S?rensen <torquil at gmail.com>' from 'Torquil Macdonald S??rensen <torquil at gmail.com>' > submitter 608903 Lo?c Minier <lool at dooz.org> Bug #608903 {Done: Adam Conrad <adconrad at 0c3.net>} [eglibc] Causes reboot of d-i if installing with upstart Changed Bug submitter to 'Lo?c Minier <lool at dooz.org>' from 'Lo??c Minier <lool at dooz.org>' > submitter 611206 Guido G?nther <agx at sigxcpu.org> Bug #611206 {Done: Petter Reinholdtsen...

On Fri, 1 Nov 2019 at 14:40:24, Dimitri John Ledkov wrote: > > On Fri, 1 Nov 2019 at 14:36, Ben Hutchings <ben at decadent.org.uk> wrote: > > > The structure definitions can't change in future, so I don't think > > that's a real issue after the previous patch. But I agree that we > > should prefer using the kernel's UAPI headers wherever possible.