search for: acutlaly

...ed to instead write a "in-kernel user of pvclock data". If you can get kernel interfaces to replace that, go for it. I prefer kernel interfaces as well. > And gets it entirely > wrong when doing nested virt, since, unless there's some secret in > this maze, it doesn't acutlaly use the scaling factor from the host > when it tells the guest what to do. > > I am really, seriously tempted to send a patch to simply delete all > this code. If your patch which deletes the code gets the necessary features right, sure, go for it. > The correct way to do it is...

...ed to instead write a "in-kernel user of pvclock data". If you can get kernel interfaces to replace that, go for it. I prefer kernel interfaces as well. > And gets it entirely > wrong when doing nested virt, since, unless there's some secret in > this maze, it doesn't acutlaly use the scaling factor from the host > when it tells the guest what to do. > > I am really, seriously tempted to send a patch to simply delete all > this code. If your patch which deletes the code gets the necessary features right, sure, go for it. > The correct way to do it is...

...gt; > > > If you can get kernel interfaces to replace that, go for it. I prefer > > kernel interfaces as well. > > > > > And gets it entirely > > > wrong when doing nested virt, since, unless there's some secret in > > > this maze, it doesn't acutlaly use the scaling factor from the host > > > when it tells the guest what to do. > > > > > > I am really, seriously tempted to send a patch to simply delete all > > > this code. > > > > If your patch which deletes the code gets the necessary features ri...

...gt; > > > If you can get kernel interfaces to replace that, go for it. I prefer > > kernel interfaces as well. > > > > > And gets it entirely > > > wrong when doing nested virt, since, unless there's some secret in > > > this maze, it doesn't acutlaly use the scaling factor from the host > > > when it tells the guest what to do. > > > > > > I am really, seriously tempted to send a patch to simply delete all > > > this code. > > > > If your patch which deletes the code gets the necessary features ri...

...f the vDSO code to read the time (instead of doing > the sane thing and using the kernel interfaces for this), and > propagates a totally made up copy to the guest. And gets it entirely > wrong when doing nested virt, since, unless there's some secret in > this maze, it doesn't acutlaly use the scaling factor from the host > when it tells the guest what to do. > > I am really, seriously tempted to send a patch to simply delete all > this code. The correct way to do it is to hook "I have discovered a truly marvelous proof of this, which this margin is too narrow...

...f the vDSO code to read the time (instead of doing > the sane thing and using the kernel interfaces for this), and > propagates a totally made up copy to the guest. And gets it entirely > wrong when doing nested virt, since, unless there's some secret in > this maze, it doesn't acutlaly use the scaling factor from the host > when it tells the guest what to do. > > I am really, seriously tempted to send a patch to simply delete all > this code. The correct way to do it is to hook "I have discovered a truly marvelous proof of this, which this margin is too narrow...

...ly maintained copy of the vDSO code to read the time (instead of doing the sane thing and using the kernel interfaces for this), and propagates a totally made up copy to the guest. And gets it entirely wrong when doing nested virt, since, unless there's some secret in this maze, it doesn't acutlaly use the scaling factor from the host when it tells the guest what to do. I am really, seriously tempted to send a patch to simply delete all this code. The correct way to do it is to hook And I don't see how it's even possible to pass kvmclock correctly to the L2 guest when L0 is hyperv....

...ernel user of pvclock data". > > If you can get kernel interfaces to replace that, go for it. I prefer > kernel interfaces as well. > > > And gets it entirely > > wrong when doing nested virt, since, unless there's some secret in > > this maze, it doesn't acutlaly use the scaling factor from the host > > when it tells the guest what to do. > > > > I am really, seriously tempted to send a patch to simply delete all > > this code. > > If your patch which deletes the code gets the necessary features right, > sure, go for it. &gt...

...can get kernel interfaces to replace that, go for it. I prefer > > > kernel interfaces as well. > > > > > > > And gets it entirely > > > > wrong when doing nested virt, since, unless there's some secret in > > > > this maze, it doesn't acutlaly use the scaling factor from the host > > > > when it tells the guest what to do. > > > > > > > > I am really, seriously tempted to send a patch to simply delete all > > > > this code. > > > > > > If your patch which deletes the code...

...ead the time (instead of doing > > the sane thing and using the kernel interfaces for this), and > > propagates a totally made up copy to the guest. And gets it entirely > > wrong when doing nested virt, since, unless there's some secret in > > this maze, it doesn't acutlaly use the scaling factor from the host > > when it tells the guest what to do. > > > > I am really, seriously tempted to send a patch to simply delete all > > this code. The correct way to do it is to hook > > "I have discovered a truly marvelous proof of this, wh...

...to read the time (instead of doing >> the sane thing and using the kernel interfaces for this), and >> propagates a totally made up copy to the guest. And gets it entirely >> wrong when doing nested virt, since, unless there's some secret in >> this maze, it doesn't acutlaly use the scaling factor from the host >> when it tells the guest what to do. >> >> I am really, seriously tempted to send a patch to simply delete all >> this code. The correct way to do it is to hook > > "I have discovered a truly marvelous proof of this, which...

Matt attempted to add CLOCK_TAI support to the VDSO clock_gettime() implementation, which extended the clockid switch case and added yet another slightly different copy of the same code. Especially the extended switch case is problematic as the compiler tends to generate a jump table which then requires to use retpolines. If jump tables are disabled it adds yet another conditional to the existing

Matt attempted to add CLOCK_TAI support to the VDSO clock_gettime() implementation, which extended the clockid switch case and added yet another slightly different copy of the same code. Especially the extended switch case is problematic as the compiler tends to generate a jump table which then requires to use retpolines. If jump tables are disabled it adds yet another conditional to the existing