search for: active_netdev

...tdev is registered as + * 'backup' netdev and a passthru device with the same MAC is registered + * as 'active' netdev. + */ + +/* bypass state maintained when BACKUP feature is enabled */ +struct virtnet_bypass_info { + /* passthru netdev with same MAC */ + struct net_device __rcu *active_netdev; + + /* virtio_net netdev */ + struct net_device __rcu *backup_netdev; + + /* active netdev stats */ + struct rtnl_link_stats64 active_stats; + + /* backup netdev stats */ + struct rtnl_link_stats64 backup_stats; + + /* aggregated stats */ + struct rtnl_link_stats64 bypass_stats; + + /* spinlock wh...

...39;backup' netdev and a passthru device with the same MAC is registered >+ * as 'active' netdev. >+ */ >+ >+/* bypass state maintained when BACKUP feature is enabled */ >+struct virtnet_bypass_info { >+ /* passthru netdev with same MAC */ >+ struct net_device __rcu *active_netdev; >+ >+ /* virtio_net netdev */ >+ struct net_device __rcu *backup_netdev; >+ >+ /* active netdev stats */ >+ struct rtnl_link_stats64 active_stats; >+ >+ /* backup netdev stats */ >+ struct rtnl_link_stats64 backup_stats; >+ >+ /* aggregated stats */ >+ struct rt...

...39;backup' netdev and a passthru device with the same MAC is registered >+ * as 'active' netdev. >+ */ >+ >+/* bypass state maintained when BACKUP feature is enabled */ >+struct virtnet_bypass_info { >+ /* passthru netdev with same MAC */ >+ struct net_device __rcu *active_netdev; >+ >+ /* virtio_net netdev */ >+ struct net_device __rcu *backup_netdev; >+ >+ /* active netdev stats */ >+ struct rtnl_link_stats64 active_stats; >+ >+ /* backup netdev stats */ >+ struct rtnl_link_stats64 backup_stats; >+ >+ /* aggregated stats */ >+ struct rt...

...**pskb); >+}; >+ >+struct bypass_master { >+ struct list_head list; >+ struct net_device __rcu *bypass_netdev; >+ struct bypass_ops __rcu *ops; >+}; >+ >+/* bypass state */ >+struct bypass_info { >+ /* passthru netdev with same MAC */ >+ struct net_device __rcu *active_netdev; You still use "active"/"backup" names which is highly misleading as it has completely different meaning that in bond for example. I noted that in my previous review already. Please change it. >+ >+ /* virtio_net netdev */ >+ struct net_device __rcu *backup_netdev; &...

...**pskb); >+}; >+ >+struct bypass_master { >+ struct list_head list; >+ struct net_device __rcu *bypass_netdev; >+ struct bypass_ops __rcu *ops; >+}; >+ >+/* bypass state */ >+struct bypass_info { >+ /* passthru netdev with same MAC */ >+ struct net_device __rcu *active_netdev; You still use "active"/"backup" names which is highly misleading as it has completely different meaning that in bond for example. I noted that in my previous review already. Please change it. >+ >+ /* virtio_net netdev */ >+ struct net_device __rcu *backup_netdev; &...

..._handler_result_t (*handle_frame)(struct sk_buff **pskb); +}; + +struct bypass_master { + struct list_head list; + struct net_device __rcu *bypass_netdev; + struct bypass_ops __rcu *ops; +}; + +/* bypass state */ +struct bypass_info { + /* passthru netdev with same MAC */ + struct net_device __rcu *active_netdev; + + /* virtio_net netdev */ + struct net_device __rcu *backup_netdev; + + /* active netdev stats */ + struct rtnl_link_stats64 active_stats; + + /* backup netdev stats */ + struct rtnl_link_stats64 backup_stats; + + /* aggregated stats */ + struct rtnl_link_stats64 bypass_stats; + + /* spinlock wh...

...;> + >> +static void virtnet_bypass_set_rx_mode(struct net_device *dev) >> +{ >> + struct virtnet_bypass_info *vbi = netdev_priv(dev); >> + struct net_device *child_netdev; >> + >> + rcu_read_lock(); >> + >> + child_netdev = rcu_dereference(vbi->active_netdev); >> + if (child_netdev) { >> + dev_uc_sync_multiple(child_netdev, dev); >> + dev_mc_sync_multiple(child_netdev, dev); >> + } >> + >> + child_netdev = rcu_dereference(vbi->backup_netdev); >> + if (child_netdev) { >> + dev_uc_sync_multiple(child_...

...ster { >> + struct list_head list; >> + struct net_device __rcu *bypass_netdev; >> + struct bypass_ops __rcu *ops; >> +}; >> + >> +/* bypass state */ >> +struct bypass_info { >> + /* passthru netdev with same MAC */ >> + struct net_device __rcu *active_netdev; > You still use "active"/"backup" names which is highly misleading as > it has completely different meaning that in bond for example. > I noted that in my previous review already. Please change it. I guess the issue is with only the 'active'? name. 'backup...

...>> > + struct net_device __rcu *bypass_netdev; >> > + struct bypass_ops __rcu *ops; >> > +}; >> > + >> > +/* bypass state */ >> > +struct bypass_info { >> > + /* passthru netdev with same MAC */ >> > + struct net_device __rcu *active_netdev; >> You still use "active"/"backup" names which is highly misleading as >> it has completely different meaning that in bond for example. >> I noted that in my previous review already. Please change it. > >I guess the issue is with only the 'active'...

...>> > + struct net_device __rcu *bypass_netdev; >> > + struct bypass_ops __rcu *ops; >> > +}; >> > + >> > +/* bypass state */ >> > +struct bypass_info { >> > + /* passthru netdev with same MAC */ >> > + struct net_device __rcu *active_netdev; >> You still use "active"/"backup" names which is highly misleading as >> it has completely different meaning that in bond for example. >> I noted that in my previous review already. Please change it. > >I guess the issue is with only the 'active'...

The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct attached SR-IOV VF devices. Patch 1 introduces a new feature bit VIRTIO_NET_F_BACKUP that can be used

The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct attached SR-IOV VF devices. Patch 1 introduces a new feature bit VIRTIO_NET_F_BACKUP that can be used

...> > + struct bypass_ops __rcu *ops; >> > > > +}; >> > > > + >> > > > +/* bypass state */ >> > > > +struct bypass_info { >> > > > + /* passthru netdev with same MAC */ >> > > > + struct net_device __rcu *active_netdev; >> > > You still use "active"/"backup" names which is highly misleading as >> > > it has completely different meaning that in bond for example. >> > > I noted that in my previous review already. Please change it. >> > I guess the iss...

...> > + struct bypass_ops __rcu *ops; >> > > > +}; >> > > > + >> > > > +/* bypass state */ >> > > > +struct bypass_info { >> > > > + /* passthru netdev with same MAC */ >> > > > + struct net_device __rcu *active_netdev; >> > > You still use "active"/"backup" names which is highly misleading as >> > > it has completely different meaning that in bond for example. >> > > I noted that in my previous review already. Please change it. >> > I guess the iss...

...ct net_device __rcu *bypass_netdev; >>>> + struct bypass_ops __rcu *ops; >>>> +}; >>>> + >>>> +/* bypass state */ >>>> +struct bypass_info { >>>> + /* passthru netdev with same MAC */ >>>> + struct net_device __rcu *active_netdev; >>> You still use "active"/"backup" names which is highly misleading as >>> it has completely different meaning that in bond for example. >>> I noted that in my previous review already. Please change it. >> I guess the issue is with only the ...

...__rcu *ops; > >> > > > +}; > >> > > > + > >> > > > +/* bypass state */ > >> > > > +struct bypass_info { > >> > > > + /* passthru netdev with same MAC */ > >> > > > + struct net_device __rcu *active_netdev; > >> > > You still use "active"/"backup" names which is highly misleading as > >> > > it has completely different meaning that in bond for example. > >> > > I noted that in my previous review already. Please change it. > >>...

...; #include <net/route.h> #include <net/xdp.h> @@ -147,6 +148,27 @@ struct receive_queue { struct xdp_rxq_info xdp_rxq; }; +/* bypass state maintained when BACKUP feature is enabled */ +struct virtnet_bypass_info { + /* passthru netdev with same MAC */ + struct net_device __rcu *active_netdev; + + /* virtio_net netdev */ + struct net_device __rcu *backup_netdev; + + /* active netdev stats */ + struct rtnl_link_stats64 active_stats; + + /* backup netdev stats */ + struct rtnl_link_stats64 backup_stats; + + /* aggregated stats */ + struct rtnl_link_stats64 bypass_stats; + + /* spinlock wh...

Patch 1 introduces a new feature bit VIRTIO_NET_F_BACKUP that can be used by hypervisor to indicate that virtio_net interface should act as a backup for another device with the same MAC address. Ppatch 2 is in response to the community request for a 3 netdev solution. However, it creates some issues we'll get into in a moment. It extends virtio_net to use alternate datapath when available

Patch 1 introduces a new feature bit VIRTIO_NET_F_BACKUP that can be used by hypervisor to indicate that virtio_net interface should act as a backup for another device with the same MAC address. Ppatch 2 is in response to the community request for a 3 netdev solution. However, it creates some issues we'll get into in a moment. It extends virtio_net to use alternate datapath when available

...t;> > > > +}; >> >> > > > + >> >> > > > +/* bypass state */ >> >> > > > +struct bypass_info { >> >> > > > + /* passthru netdev with same MAC */ >> >> > > > + struct net_device __rcu *active_netdev; >> >> > > You still use "active"/"backup" names which is highly misleading as >> >> > > it has completely different meaning that in bond for example. >> >> > > I noted that in my previous review already. Please change it. &g...