search for: actions_tsk

...se /* !HAVE_YARA */ + +OPTGROUP_YARA_NOT_AVAILABLE + +#endif /* !HAVE_YARA */ diff --git a/generator/Makefile.am b/generator/Makefile.am index cb69fe831..0f7fc289b 100644 --- a/generator/Makefile.am +++ b/generator/Makefile.am @@ -43,6 +43,8 @@ sources = \ actions_properties_deprecated.mli \ actions_tsk.ml \ actions_tsk.mli \ + actions_yara.ml \ + actions_yara.mli \ bindtests.ml \ bindtests.mli \ c.ml \ @@ -130,6 +132,7 @@ objects = \ actions_properties.cmo \ actions_properties_deprecated.cmo \ actions_tsk.cmo \ + actions_yara.cmo \ actions.cmo \ structs.cmo \ fish_commands.cmo...

Rebase patches on top of 1.37.1. No changes since last series. Matteo Cafasso (7): daemon: expose file upload logic appliance: add yara dependency New API: yara_load New API: yara_destroy New API: internal_yara_scan New API: yara_scan yara_scan: added API tests appliance/packagelist.in | 4 + configure.ac | 1 + daemon/Makefile.am

...le (void) +{ + return 1; +} + +#else /* !HAVE_YARA */ + +OPTGROUP_LIBYARA_NOT_AVAILABLE + +#endif /* !HAVE_YARA */ diff --git a/generator/Makefile.am b/generator/Makefile.am index 31989cd4a..81b49cab1 100644 --- a/generator/Makefile.am +++ b/generator/Makefile.am @@ -45,6 +45,8 @@ sources = \ actions_tsk.mli \ authors.ml \ authors.mli \ + actions_yara.ml \ + actions_yara.mli \ bindtests.ml \ bindtests.mli \ c.ml \ @@ -132,6 +134,7 @@ objects = \ actions_properties.cmo \ actions_properties_deprecated.cmo \ actions_tsk.cmo \ + actions_yara.cmo \ actions.cmo \ structs.cmo \ fish_...

...le (void) +{ + return 1; +} + +#else /* !HAVE_YARA */ + +OPTGROUP_LIBYARA_NOT_AVAILABLE + +#endif /* !HAVE_YARA */ diff --git a/generator/Makefile.am b/generator/Makefile.am index 31989cd4a..81b49cab1 100644 --- a/generator/Makefile.am +++ b/generator/Makefile.am @@ -45,6 +45,8 @@ sources = \ actions_tsk.mli \ authors.ml \ authors.mli \ + actions_yara.ml \ + actions_yara.mli \ bindtests.ml \ bindtests.mli \ c.ml \ @@ -132,6 +134,7 @@ objects = \ actions_properties.cmo \ actions_properties_deprecated.cmo \ actions_tsk.cmo \ + actions_yara.cmo \ actions.cmo \ structs.cmo \ fish_...

...lable (void) +{ + return 1; +} + +#else /* !HAVE_YARA */ + +OPTGROUP_YARA_NOT_AVAILABLE + +#endif /* !HAVE_YARA */ diff --git a/generator/Makefile.am b/generator/Makefile.am index 31989cd4a..81b49cab1 100644 --- a/generator/Makefile.am +++ b/generator/Makefile.am @@ -45,6 +45,8 @@ sources = \ actions_tsk.mli \ authors.ml \ authors.mli \ + actions_yara.ml \ + actions_yara.mli \ bindtests.ml \ bindtests.mli \ c.ml \ @@ -132,6 +134,7 @@ objects = \ actions_properties.cmo \ actions_properties_deprecated.cmo \ actions_tsk.cmo \ + actions_yara.cmo \ actions.cmo \ structs.cmo \ fish_...

...ons.ml index 4df3b2a32..d36a4f8a9 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -38,7 +38,8 @@ let non_daemon_functions = Actions_inspection_deprecated.non_daemon_functions @ Actions_properties.non_daemon_functions @ Actions_properties_deprecated.non_daemon_functions @ - Actions_tsk.non_daemon_functions + Actions_tsk.non_daemon_functions @ + Actions_yara.non_daemon_functions (* daemon_functions are any functions which cause some action * to take place in the daemon. diff --git a/generator/actions_yara.ml b/generator/actions_yara.ml index 2166d6f0a..deb4190a9 100644 --- a...

...ons.ml index 4df3b2a32..d36a4f8a9 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -38,7 +38,8 @@ let non_daemon_functions = Actions_inspection_deprecated.non_daemon_functions @ Actions_properties.non_daemon_functions @ Actions_properties_deprecated.non_daemon_functions @ - Actions_tsk.non_daemon_functions + Actions_tsk.non_daemon_functions @ + Actions_yara.non_daemon_functions (* daemon_functions are any functions which cause some action * to take place in the daemon. diff --git a/generator/actions_yara.ml b/generator/actions_yara.ml index a5a46e8c7..bb320a74e 100644 --- a...

...ons.ml index 6e11d99c3..2722f3dcd 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -38,7 +38,8 @@ let non_daemon_functions = Actions_inspection_deprecated.non_daemon_functions @ Actions_properties.non_daemon_functions @ Actions_properties_deprecated.non_daemon_functions @ - Actions_tsk.non_daemon_functions + Actions_tsk.non_daemon_functions @ + Actions_yara.non_daemon_functions (* daemon_functions are any functions which cause some action * to take place in the daemon. diff --git a/generator/actions_yara.ml b/generator/actions_yara.ml index 1f7decdd4..5afbd47e9 100644 --- a...

v7: - Fixes according to comments - Rebase on top of 1.37.12 Matteo Cafasso (7): daemon: expose file upload logic appliance: add yara dependency New API: yara_load New API: yara_destroy New API: internal_yara_scan New API: yara_scan yara_scan: added API tests appliance/packagelist.in | 4 + configure.ac | 1 + daemon/Makefile.am

v9: - fixes according to comments Matteo Cafasso (7): daemon: expose file upload logic appliance: add yara dependency New API: yara_load New API: yara_destroy New API: internal_yara_scan New API: yara_scan yara_scan: added API tests appliance/packagelist.in | 4 + configure.ac | 1 + daemon/Makefile.am | 4 +-

v5: - rebase on top of 1.37.9 - add missing actions_yara.* files Matteo Cafasso (7): daemon: expose file upload logic appliance: add yara dependency New API: yara_load New API: yara_destroy New API: internal_yara_scan New API: yara_scan yara_scan: added API tests appliance/packagelist.in | 4 + configure.ac | 1 + daemon/Makefile.am

v8: - Ignore returned value in daemon/upload.c - Report serialization errors in lib/yara.c Matteo Cafasso (8): daemon: ignore unused return value in upload function daemon: expose file upload logic appliance: add yara dependency New API: yara_load New API: yara_destroy New API: internal_yara_scan New API: yara_scan yara_scan: added API tests appliance/packagelist.in

...t up the huge generator/actions.ml into several smaller files. Few notes: - regarding patch #2: wasn't the order stable before? Except from the explicitly seen order change in tests_c_api.ml, what made the actions order non-deterministic? - regarding patch #5: download_inode should be in actions_tsk.ml - regarding patch #5: I'm personally not fond of the _deprecated.ml versions: that means in case an API is deprecated, then it is moved from one place to another, IMHO for no reason. +1 for the split, -1 for the _deprecated split Thanks, -- Pino Toscano

v6: - use new test functions - fix yara_detection struct field names - revert yara_load function to initial version With Pino we were exploring the idea of allowing Users to load multiple rule files with subsequent calls to yara_load API. https://www.redhat.com/archives/libguestfs/2016-November/msg00119.html It turns out impractical due to YARA API limitations. It is possible to load multiple

...which changed because the contents of the actions_*.ml files changed). Indeed there weren't any changes, which was how I verified the patch set. But for that to work I had to have a stable ordering that I could reproduce in the new code. > - regarding patch #5: download_inode should be in actions_tsk.ml OK, will fix. > - regarding patch #5: I'm personally not fond of the _deprecated.ml > versions: that means in case an API is deprecated, then it is moved > from one place to another, IMHO for no reason. > +1 for the split, -1 for the _deprecated split The thinking here w...

..._inspection_deprecated.non_daemon_functions @ Actions_properties.non_daemon_functions @ @@ -51,6 +50,7 @@ let daemon_functions = Actions_core_deprecated.daemon_functions @ Actions_debug.daemon_functions @ Actions_hivex.daemon_functions @ + Actions_hivex_deprecated.daemon_functions @ Actions_tsk.daemon_functions @ Actions_yara.daemon_functions diff --git a/generator/actions_hivex.ml b/generator/actions_hivex.ml index 0a3d6dd20..6ccb65fa6 100644 --- a/generator/actions_hivex.ml +++ b/generator/actions_hivex.ml @@ -22,25 +22,6 @@ open Types (* Hivex APIs. *) -let non_daemon_functio...

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

...- fuse/guestunmount.c | 4 ++-- fuse/guestunmount.pod | 2 +- generator/actions.ml | 2 +- generator/actions_core.ml | 12 +++++------ generator/actions_core_deprecated.ml | 2 +- generator/actions_debug.ml | 2 +- generator/actions_tsk.ml | 30 +++++++++++++-------------- get-kernel/get_kernel.ml | 2 +- get-kernel/virt-get-kernel.pod | 2 +- inspector/inspector.c | 2 +- inspector/virt-inspector.pod | 2 +- lib/copy-in-out.c | 8 ++++---- lib/create.c...

...| 10 +- generator/actions_inspection.ml | 46 +- generator/actions_inspection_deprecated.ml | 2 +- generator/actions_internal_tests.ml | 12 +- generator/actions_properties.ml | 16 +- generator/actions_properties_deprecated.ml | 2 +- generator/actions_tsk.ml | 12 +- generator/bindtests.ml | 16 +- generator/c.ml | 87 ++-- generator/csharp.ml | 20 +- generator/daemon.ml | 56 ++- generator/erlang.ml | 10 +-...

Very large but mechanical change to the generator. Rich.