search for: acr_r352

...t in the middle. This needs an initial walk of the lists to figure out how large the buffer should be. [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA at mail.gmail.com Signed-off-by: Kees Cook <keescook at chromium.org> --- .../nouveau/nvkm/subdev/secboot/acr_r352.c | 25 ++++++++++++++++--- .../nouveau/nvkm/subdev/secboot/acr_r367.c | 16 +++++++++++- 2 files changed, 37 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c index a721354249ce..d02e183...

This is needed for using Nouveaus PMU image after performing secboot. This will be helpfull for Maxwell2 reclocking on boards without externally controlled fans like on most laptops or fanless boards. Signed-off-by: Karol Herbst <karolherbst at gmail.com> --- drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drm/nouveau/nvkm/subdev/secboot/acr_r352.c index a7213542..00095ef8 100644 --- a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c +++ b/drm/nouveau/nvkm/subdev/secboot/acr_r352.c @@ -924,6 +9...

...* were allocated, release them before return. Addresses-Coverity-ID: 1472021 ("Resource leak") Fixes: 0d466901552a ("drm/nouveau/secboot/acr: Remove VLA usage") Signed-off-by: Gustavo A. R. Silva <gustavo at embeddedor.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c index d02e183..5c14d6a 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/...

...WPR and LSB headers, used to generate the LS blob, may have a different layout and sizes depending on the driver version they come from. Abstract them and confine their use to driver-specific code. Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> --- drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 102 +++++++++++++--------- drm/nouveau/nvkm/subdev/secboot/acr_r352.h | 119 ++++++++++++++++++++++++++ drm/nouveau/nvkm/subdev/secboot/acr_r361.c | 9 +- drm/nouveau/nvkm/subdev/secboot/ls_ucode.h | 100 +--------------------- drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 39...

...; >> Addresses-Coverity-ID: 1472021 ("Resource leak") >> Fixes: 0d466901552a ("drm/nouveau/secboot/acr: Remove VLA usage") >> Signed-off-by: Gustavo A. R. Silva <gustavo at embeddedor.com> >> --- >> drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c >> index d02e183..5c14d6a 100644 >> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352....

This was used only locally to one function and can be replaced by ad-hoc variables. Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> --- drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 90 +++++++++++------------------- 1 file changed, 33 insertions(+), 57 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drm/nouveau/nvkm/subdev/secboot/acr_r352.c index cdba9ffc5bbe..4b72371bdbae 100644 --- a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c +++ b/drm/nouveau/n...

Split the reset function into more meaningful and reusable ones. Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> --- drm/nouveau/include/nvkm/subdev/secboot.h | 3 ++ drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 78 ++++++++++++++++++++---------- 2 files changed, 56 insertions(+), 25 deletions(-) diff --git a/drm/nouveau/include/nvkm/subdev/secboot.h b/drm/nouveau/include/nvkm/subdev/secboot.h index 24d98878bb93..785e2c553392 100644 --- a/drm/nouveau/include/nvkm/subdev/secboot.h +++ b/drm/nouveau/inc...

...igure >> out how large the buffer should be. >> >> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA at mail.gmail.com >> >> Signed-off-by: Kees Cook <keescook at chromium.org> >> --- >> .../nouveau/nvkm/subdev/secboot/acr_r352.c | 25 ++++++++++++++++--- >> .../nouveau/nvkm/subdev/secboot/acr_r367.c | 16 +++++++++++- >> 2 files changed, 37 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr...

...itial walk of the lists to figure > out how large the buffer should be. > > [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA at mail.gmail.com > > Signed-off-by: Kees Cook <keescook at chromium.org> > --- > .../nouveau/nvkm/subdev/secboot/acr_r352.c | 25 ++++++++++++++++--- > .../nouveau/nvkm/subdev/secboot/acr_r367.c | 16 +++++++++++- > 2 files changed, 37 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c > ind...

ucode_header is not used anywhere, so just get rid of it. Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> --- drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 25 +++++++------------------ drm/nouveau/nvkm/subdev/secboot/ls_ucode.h | 2 -- drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c | 2 -- 3 files changed, 7 insertions(+), 22 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drm/nouveau/nvkm/subdev/secboot/acr_r352.c...

...| 17 ++- drm/nouveau/nvkm/subdev/mc/gp10b.c | 50 +++++++++ drm/nouveau/nvkm/subdev/mc/priv.h | 6 ++ drm/nouveau/nvkm/subdev/secboot/Kbuild | 1 + drm/nouveau/nvkm/subdev/secboot/acr.h | 3 +- drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 88 +++++----------- drm/nouveau/nvkm/subdev/secboot/acr_r352.h | 6 +- drm/nouveau/nvkm/subdev/secboot/acr_r367.c | 3 +- drm/nouveau/nvkm/subdev/secboot/acr_r367.h | 1 + drm/nouveau/nvkm/subdev/secboot/base.c | 6 +- drm/nouveau/nvkm/subde...

...falcon/base.c | 6 +- drm/nouveau/nvkm/falcon/v1.c | 17 +- drm/nouveau/nvkm/subdev/secboot/Kbuild | 4 +- drm/nouveau/nvkm/subdev/secboot/acr.c | 54 +- drm/nouveau/nvkm/subdev/secboot/acr.h | 69 +- drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 936 +++++++++++++- drm/nouveau/nvkm/subdev/secboot/acr_r352.h | 250 ++++- drm/nouveau/nvkm/subdev/secboot/acr_r361.c | 138 ++- drm/nouveau/nvkm/subdev/secboot/base.c | 95 +- drm/nouveau/nvkm/subdev/secboot/gm200.c | 1283 +------------------ drm/nouveau/nvkm/subde...

...arge the buffer should be. >>> >>> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA at mail.gmail.com >>> >>> Signed-off-by: Kees Cook <keescook at chromium.org> >>> --- >>> .../nouveau/nvkm/subdev/secboot/acr_r352.c | 25 ++++++++++++++++--- >>> .../nouveau/nvkm/subdev/secboot/acr_r367.c | 16 +++++++++++- >>> 2 files changed, 37 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drivers/gpu/drm/nouveau/nvkm/su...

...v/pmu/nv_pmu.h | 53 +- drm/nouveau/nvkm/subdev/pmu/priv.h | 22 +- drm/nouveau/nvkm/subdev/secboot/Kbuild | 5 +- drm/nouveau/nvkm/subdev/secboot/acr.c | 54 +- drm/nouveau/nvkm/subdev/secboot/acr.h | 73 +- drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 1111 ++++++++++++++- drm/nouveau/nvkm/subdev/secboot/acr_r352.h | 252 +++- drm/nouveau/nvkm/subdev/secboot/acr_r361.c | 135 ++- drm/nouveau/nvkm/subdev/secboot/base.c | 151 +- drm/nouveau/nvkm/subdev/secboot/gm200.c | 1337 +----------------- drm/nouveau/nvkm/s...

...ot during channel recovery (ie. page fault on gr)? - What about the running of the unload blob? It makes me angry that we even have to think about doing stuff like this! :P Ben. > > Signed-off-by: Karol Herbst <karolherbst at gmail.com> > --- > drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drm/nouveau/nvkm/subdev/secboot/acr_r352.c > index a7213542..00095ef8 100644 > --- a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c > +++ b/drm/nouveau/nvkm/subdev/s...

Fix sparse warning: drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c:1092:1: warning: symbol 'acr_r352_ls_gpccs_func' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci at huawei.com> Signed-off-by: YueHaibing <yuehaibing at huawei.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 2 +- 1 file changed, 1 i...

...m/engine/gr/gf100.c | 16 +- drm/nouveau/nvkm/engine/gr/gm200.c | 6 +- drm/nouveau/nvkm/subdev/secboot/Kbuild | 4 + drm/nouveau/nvkm/subdev/secboot/acr.c | 54 + drm/nouveau/nvkm/subdev/secboot/acr.h | 68 ++ drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 925 +++++++++++++++++ drm/nouveau/nvkm/subdev/secboot/acr_r352.h | 246 +++++ drm/nouveau/nvkm/subdev/secboot/acr_r361.c | 135 +++ drm/nouveau/nvkm/subdev/secboot/base.c | 118 ++- drm/nouveau/nvkm/subdev/secboot/gm200.c | 1335 +------------------------ drm/nouveau/...

...before return. > > Addresses-Coverity-ID: 1472021 ("Resource leak") > Fixes: 0d466901552a ("drm/nouveau/secboot/acr: Remove VLA usage") > Signed-off-by: Gustavo A. R. Silva <gustavo at embeddedor.com> > --- > drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c > index d02e183..5c14d6a 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c > +++ b/driver...

...sses-Coverity-ID: 1472021 ("Resource leak") >>> Fixes: 0d466901552a ("drm/nouveau/secboot/acr: Remove VLA usage") >>> Signed-off-by: Gustavo A. R. Silva <gustavo at embeddedor.com> >>> --- >>> drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c >>> index d02e183..5c14d6a 100644 >>> --- a/drivers/gpu/drm/nouveau/nvkm/subd...

...m/engine/gr/gf100.c | 16 +- drm/nouveau/nvkm/engine/gr/gm200.c | 6 +- drm/nouveau/nvkm/subdev/secboot/Kbuild | 4 + drm/nouveau/nvkm/subdev/secboot/acr.c | 54 + drm/nouveau/nvkm/subdev/secboot/acr.h | 68 ++ drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 924 +++++++++++++++++ drm/nouveau/nvkm/subdev/secboot/acr_r352.h | 246 +++++ drm/nouveau/nvkm/subdev/secboot/acr_r361.c | 140 +++ drm/nouveau/nvkm/subdev/secboot/base.c | 118 ++- drm/nouveau/nvkm/subdev/secboot/gm200.c | 1335 +------------------------ drm/nouveau/...