search for: acr

This fixes a NULL pointer access inside nvkm_acr_oneinit in case necessary firmware files couldn't be loaded. Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/212 Fixes: 4b569ded09fd ("drm/nouveau/acr/ga102: initial support") Signed-off-by: Karol Herbst <kherbst at redhat.com> --- drivers/gpu/drm/nouveau/nvkm/subd...

...nt data frames and then manipulate those 10 data frames but would like to do this in a more simplified code than what i am doing. I have tried a couple of approaches but cannot get it to work correctly. So the initial (bulky) code is: #Bin 1 #------- #Loads bin data frame from csv files with acres and TAZ data Bin1_main <- read.csv(file="I:/Research/Samba/urb_transport_modeling/LUSDR/Workspace/BizLandPrice/data/Bin_lookup_values/Bin1_lookup.csv",head=FALSE); #Separates Acres data from main data and converts acres to square feet Bin1_Acres=Bin1_main[[1]]*43560 #Separates TAZ...

Hello All, I would like to select records with identical IDs then sum an attribute then and return them to the data frame as a single record. Please consider Acres<-c(100,101,100,130,156,.5,293,300,.09) Bldgid<-c(1,2,3,4,5,5,6,7,7) DF=cbind(Acres,Bldgid) DF<-as.data.frame(DF) So that: Acres Bldgid 1 100.00 1 2 101.00 2 3 100.00 3 4 130.00 4 5 156.00 5 6 0.50 5 7 293.00 6 8 300.00 7 9 0.09 7 Bec...

Split the reset function into more meaningful and reusable ones. Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> --- drm/nouveau/include/nvkm/subdev/secboot.h | 3 ++ drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 78 ++++++++++++++++++++---------- 2 files changed, 56 insertions(+), 25 deletions(-) diff --git a/drm/nouveau/include/nvkm/subdev/secboot.h b/drm/nouveau/include/nvkm/subdev/secboot.h index 24d98878bb93..785e2c553392 100644 --- a/drm/nouveau/include/nvkm/subdev/secboot.h +++ b/drm/nouvea...

...t in the middle. This needs an initial walk of the lists to figure out how large the buffer should be. [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA at mail.gmail.com Signed-off-by: Kees Cook <keescook at chromium.org> --- .../nouveau/nvkm/subdev/secboot/acr_r352.c | 25 ++++++++++++++++--- .../nouveau/nvkm/subdev/secboot/acr_r367.c | 16 +++++++++++- 2 files changed, 37 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c index a721354249ce..d0...

Fixes coccicheck warning: drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c:103:23-30: WARNING opportunity for kmemdup drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c:113:22-29: WARNING opportunity for kmemdup Fixes: 22dcda45a3d1 ("drm/nouveau/acr: implement new subdev to replace "secure boot"") Reported-by: Hulk Robot <hulkci at huawei.com&gt...

This patch performs the following changes: 1. remove a redundant parentheses around the nvkm_acr_lsfw_add() calls 2. do assignment before this if condition, it is more readable Signed-off-by: Jing Xiangfeng <jingxiangfeng at huawei.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/s...

gcc with W=1 reports drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: error: no previous prototype for ?wpr_generic_header_dump? [-Werror=missing-prototypes] 49 | wpr_generic_header_dump(struct nvkm_subdev *subdev, | ^~~~~~~~~~~~~~~~~~~~~~~ wpr_generic_header_dump is only used in acr.c, so it should be static Signed-off-by: Tom Rix <trix at re...

...s of interest. Best Ben Caldwell ----------------------------------------------- #unpaired verification.plots<-rnorm(30, 100, 10) # writeClipboard(as.character(verification.plots)) unpaired.test<- function(verification.plots, project.n, project.mean, project.sd, allowed.deviation, project.acres, alpha=.05){ verification.plots <-as.numeric(as.character(verification.plots)) a <- qnorm(alpha/2) d <- alpha*project.mean # verifier plot number n<-length(verification.plots) verifier.plot.number <- c(1:n) #all plots (verifier and project) all.plots.n <- rep(0,n) for(i in...

clang with W=1 reports drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:7: error: variable 'loc' set but not used [-Werror,-Wunused-but-set-variable] u32 loc, sig, cnt, *meta; ^ This variable is not used so remove it. Signed-off-by: Tom Rix <trix at redhat.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/...

...WPR and LSB headers, used to generate the LS blob, may have a different layout and sizes depending on the driver version they come from. Abstract them and confine their use to driver-specific code. Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> --- drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 102 +++++++++++++--------- drm/nouveau/nvkm/subdev/secboot/acr_r352.h | 119 ++++++++++++++++++++++++++ drm/nouveau/nvkm/subdev/secboot/acr_r361.c | 9 +- drm/nouveau/nvkm/subdev/secboot/ls_ucode.h | 100 +--------------------- drm/nouveau/nvkm/subdev/secboot/ls_ucode_gr.c |...

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function ?nvkm_acr_lsfw_load_sig_image_desc_v2?: drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable ?loc? set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs <bskeggs at redhat.com> Cc: Karol Herbst <kherbst at redhat.com> Cc: Lyude Paul <ly...

This was used only locally to one function and can be replaced by ad-hoc variables. Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> --- drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 90 +++++++++++------------------- 1 file changed, 33 insertions(+), 57 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drm/nouveau/nvkm/subdev/secboot/acr_r352.c index cdba9ffc5bbe..4b72371bdbae 100644 --- a/drm/nouveau/nvkm/subdev/secboot/acr_r352.c +++ b/drm/nouv...

...t there are many potential users (GR, PMU, etc). I will test users and send further patches making use of it. Patch 4 renames a hook to something better describing its actual use. Patch 5 is where the big refactoring occurs. It looks scary, but is really just moving code (and introducing the nvkm_acr structures). Patch 6, 7 and 8 remove a few HS hooks that turn out to be unneeded, and add support for LS hooks. The end result can be observed by looking at acr_v1_gm20b.c: all the specifics of GM20B's firmware are handled in a single file, with no data structures shared with acr_v1.c. The gm...

I am trying to run a windows program called ACR with Wine on a Mandrake system. The install goes beautifully (thanks to all of those hardworking programmers!). But when I try to run ACR it complains that Windows is being run in Debug mode and quits. This is also what happened when trying to run ACR on Win4Lin. Does this make running ACR hop...

...itial walk of the lists to figure > out how large the buffer should be. > > [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA at mail.gmail.com > > Signed-off-by: Kees Cook <keescook at chromium.org> > --- > .../nouveau/nvkm/subdev/secboot/acr_r352.c | 25 ++++++++++++++++--- > .../nouveau/nvkm/subdev/secboot/acr_r367.c | 16 +++++++++++- > 2 files changed, 37 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c &gt...

...ions secboot: safer zeroing of BL descriptors secboot: add missing fields to BL structure secboot: set default error value in error register secboot: fix WPR descriptor generation secboot: add lazy-bootstrap flag falcon: add clear_interrupt function secboot: clear halt interrupt after ACR is run drm/nouveau/include/nvkm/engine/falcon.h | 2 +- drm/nouveau/include/nvkm/subdev/secboot.h | 10 +- drm/nouveau/nvkm/falcon/base.c | 6 +- drm/nouveau/nvkm/falcon/v1.c | 17 +- drm/nouveau/nvkm/subdev/secboot/Kbuild | 4 +- drm/n...

This revision includes initial signed PMU firmware support for GM20B (Tegra X1). This PMU code will also be used as a basis for dGPU signed PMU firmware support. With the PMU code, the refactoring of secure boot should also make more sense. ACR (secure boot) support is now separated by the driver version it originates from. This separation allows to run any version of the ACR on any chip, although in practice only one version should ever be released for any given chip. But since ACR only changes slightly from version to version, we just h...

...ted. Thanks! ---------------------------------------------------------------- Alexandre Courbot (2): nvidia: Add GM200, GM204 and GM206 signed firmware nvidia: Add GM20B signed firmware WHENCE | 61 ++++++++++++++++++++++++++++++++++++- nvidia/gm200/acr/bl.bin | Bin 0 -> 832 bytes nvidia/gm200/acr/ucode_load.bin | Bin 0 -> 10144 bytes nvidia/gm200/acr/ucode_unload.bin | Bin 0 -> 1440 bytes nvidia/gm200/gr/fecs_bl.bin | Bin 0 -> 576 bytes nvidia/gm200/gr/fecs_data.bin | Bin 0 -> 1968 bytes nvidia/...

...question are not available yet I cannot send the code to manage then, but hopefully the gain in clarity will be enough to merge this series ahead of the rest. Of the whole series, patch 8 is the most significant as it reorganizes the code into more source files. Chip support is separated from the ACR implementation, with ACR being numbered according to the (public) NVIDIA driver version it was build aainst. This means one can make any chip work with any ACR version just by instanciating the proper ACR and adds a lot of flexibility that will be required as more firmwares get released. At the mom...