search for: acquire_lock

Since each ACQUIRE_LOCK/RELEASE_LOCK call must balance, this code is difficult to debug. Enable DEBUG_LOCK to add some prints which can help. The only definitive list of public APIs is found indirectly in the generator (in generator/c.ml : globals). --- generator/c.ml | 18 ++++++++++++++ src/errors.c...

Previous discussion here: https://www.redhat.com/archives/libguestfs/2015-June/thread.html#00048 v2: - Use a cleanup handler to release the lock. - Rebase to upstream. Note I have not fixed the problem(s) with error handling (patch 3).

This patch isn't ready to go upstream. In fact, I think we might do a quick 1.30 release soon, and save this patch, and also the extensive changes proposed for the test suite[1], to after 1.30. Currently it is not safe to use the same handle from multiple threads, unless you implement your own mutexes. See: http://libguestfs.org/guestfs.3.html#multiple-handles-and-multiple-threads These

Hi, On Saturday 06 June 2015 14:20:38 Richard W.M. Jones wrote: > Since each ACQUIRE_LOCK/RELEASE_LOCK call must balance, this code is > difficult to debug. Enable DEBUG_LOCK to add some prints which can > help. There's some way this could be simplified: > const char * > guestfs_last_error (guestfs_h *g) > { > - return g->last_error; > + const char *r...

..., msg); + if (error_data->error_cb) + error_data->error_cb (g, error_data->error_cb_data, msg); } void @@ -212,17 +340,22 @@ void guestfs_set_error_handler (guestfs_h *g, guestfs_error_handler_cb cb, void *data) { + struct error_data *error_data; + ACQUIRE_LOCK (g); - g->error_cb = cb; - g->error_cb_data = data; + error_data = get_error_data (g); + error_data->error_cb = cb; + error_data->error_cb_data = data; RELEASE_LOCK (g); } static guestfs_error_handler_cb unlocked_get_error_handler (guestfs_h *g, void **data_rtn) { - if (d...

...e the show page for an example, and that same example is modified by another user before that first user confirms, that first users'' attempt to confirm is blocked. LockingResource example: class LockingResourcesController < ApplicationController before_filter :login_required, :acquire_lock protected def acquire_lock catch_resources_unavailable current_user, :accessor => :acquire_lock_for_user, :message => "Could not acquire lock" end end If user cannot acquire a lock they are redirected back to the referring page with th...

..., tf_esi = 0, tf_ebp = -1069343740, tf_isp = -1069343768, tf_ebx = -1069114020, tf_edx = 6867016, tf_ecx = 11, tf_eax = 0, tf_trapno = 12, tf_err = 0, tf_eip = -1070392284, tf_cs = 8, tf_eflags = 66054, tf_esp = 0, tf_ss = 0}) at /usr/src/sys/i386/i386/trap.c:466 #6 0xc0331c24 in acquire_lock (lk=0xc0469d5c) at /usr/src/sys/ufs/ffs/ffs_softdep.c:266 #7 0xc0336246 in softdep_fsync_mountdev (vp=0xde8fab40) at /usr/src/sys/ufs/ffs/ffs_softdep.c:4024 #8 0xc033a596 in ffs_fsync (ap=0xc0431c78) at /usr/src/sys/ufs/ffs/ffs_vnops.c:134 #9 0xc033921f in ffs_sync (mp=0xc22de600, waitfor=2,...

Changes since v1: - Removed libxl vncviewer related dependencies - The vncviewer function was modified to accept a domid instead of domspec; - main_vncviewer was updated to reflect the new use. - A domain_create structure is now passed to the parse_config_data where required/feasible (NULL otherwise) - xl restore now have long options for vncviewer/vncviewer-autopass; docs updated. - Updated

...21748, tf_isp = -1071021776, tf_ebx = -1070926180, tf_edx = 6864960, tf_ecx = -1070772832, tf_eax = 0, tf_trapno = 12, tf_err = 0, tf_eip = -1071669292, tf_cs = 8, tf_eflags = 66050, tf_esp = -1071021628, tf_ss = 2}) at /usr/src/sys/i386/i386/trap.c:466 #6 0xc01f9fd4 in acquire_lock (lk=0xc02af69c) at /usr/src/sys/ufs/ffs/ffs_softdep.c:266 #7 0xc01fe722 in softdep_fsync_mountdev (vp=0xce7059c0) at /usr/src/sys/ufs/ffs/ffs_softdep.c:4024 #8 0xc0202b4a in ffs_fsync (ap=0xc02981c4) at /usr/src/sys/ufs/ffs/ffs_vnops.c:134 #9 0xc0201788 in ffs_sync (mp=0xc2306800, wa...

...0, tf_trapno = 12, tf_err = 0, tf_eip = -1071367104, tf_cs = 8, tf_eflags = 2163334, tf_esp = -1036583680, tf_ss = -1036583680}) at /usr/src/sys/i386/i386/trap.c:466 p = (struct proc *) 0x0 sticks = 18446744072637479814 i = 0 ucode = 0 type = 12 code = 0 eva = 48 #6 0xc0243c40 in acquire_lock (lk=0xc0351dfc) at /usr/src/sys/ufs/ffs/ffs_softdep.c:266 lk = (struct lockit *) 0xffffffff holder = -1036583680 #7 0xc0247d40 in softdep_update_inodeblock (ip=0xc236fd00, bp=0xcc8e2f2c, waitfor=0) at /usr/src/sys/ufs/ffs/ffs_softdep.c:3813 ip = (struct inode *) 0xc236fd00 inodedep = (stru...

...1248, tf_esi = 0, tf_ebp = -1070469844, tf_isp = -1070469872, tf_ebx = -1070360356, tf_edx = 6869056, tf_ecx = 28, tf_eax = 0, tf_trapno = 12, tf_err = 0, tf_eip = -1071186024, tf_cs = 8, tf_eflags = 66050, tf_esp = 0, tf_ss = 0}) at /usr/src/sys/i386/i386/trap.c:466 #6 0xc026ff98 in acquire_lock (lk=0xc03398dc) at /usr/src/sys/ufs/ffs/ffs_softdep.c:266 #7 0xc02745d6 in softdep_fsync_mountdev (vp=0xda9e7a80) at /usr/src/sys/ufs/ffs/ffs_softdep.c:4024 #8 0xc0278816 in ffs_fsync (ap=0xc031eda0) at /usr/src/sys/ufs/ffs/ffs_vnops.c:134 #9 0xc027749f in ffs_sync (mp=0xc29b4200, waitfor=2, cre...

This is a rebase/resend of earlier patches. I skipped the pure cosmetic patches for now. Mostly this is consolidation earlier changes, removing dead code etc. The important part is the change for allowing a vmbus channel to get callback directly in interrupt mode; this is necessary for NAPI support. Stephen Hemminger (14): vmbus: use kernel bitops for traversing interrupt mask vmbus: drop

This is a rebase/resend of earlier patches. I skipped the pure cosmetic patches for now. Mostly this is consolidation earlier changes, removing dead code etc. The important part is the change for allowing a vmbus channel to get callback directly in interrupt mode; this is necessary for NAPI support. Stephen Hemminger (14): vmbus: use kernel bitops for traversing interrupt mask vmbus: drop