search for: acpi_lid_open

Since notification side has been changed to always notify kernel listeners using _LID returning value. Now listeners needn't invoke acpi_lid_open(), it should use a spec suggested control method lid device usage model: register lid notification and use the notified value instead, which is the only way to ensure the value is correct for "button.lid_init_state=ignore" mode or other modes with "button.lid_fake_events=N" spec...

On Tue, May 9, 2017 at 9:02 AM, Lv Zheng <lv.zheng at intel.com> wrote: > Since notification side has been changed to always notify kernel listeners > using _LID returning value. Now listeners needn't invoke acpi_lid_open(), > it should use a spec suggested control method lid device usage model: > register lid notification and use the notified value instead, which is the > only way to ensure the value is correct for "button.lid_init_state=ignore" > mode or other modes with "button.lid_fake...

Hi, > From: Benjamin Tissoires [mailto:benjamin.tissoires at gmail.com] > Subject: Re: [PATCH v2 5/5] ACPI: button: Obselete acpi_lid_open() invocations > > On Tue, May 9, 2017 at 9:02 AM, Lv Zheng <lv.zheng at intel.com> wrote: > > Since notification side has been changed to always notify kernel listeners > > using _LID returning value. Now listeners needn't invoke acpi_lid_open(), > > it should use...

Hi, If my previous reply is not persuasive enough. Let me do that in a different way. > From: linux-acpi-owner at vger.kernel.org [mailto:linux-acpi-owner at vger.kernel.org] On Behalf Of Zheng, > Lv > Subject: RE: [PATCH v2 5/5] ACPI: button: Obselete acpi_lid_open() invocations > > Hi, > > > From: Benjamin Tissoires [mailto:benjamin.tissoires at gmail.com] > > Subject: Re: [PATCH v2 5/5] ACPI: button: Obselete acpi_lid_open() invocations > > > > On Tue, May 9, 2017 at 9:02 AM, Lv Zheng <lv.zheng at intel.com> wrote: &...

...> Hi, > > If my previous reply is not persuasive enough. > Let me do that in a different way. > >> From: linux-acpi-owner at vger.kernel.org [mailto:linux-acpi-owner at vger.kernel.org] On Behalf Of Zheng, >> Lv >> Subject: RE: [PATCH v2 5/5] ACPI: button: Obselete acpi_lid_open() invocations >> >> Hi, >> >> > From: Benjamin Tissoires [mailto:benjamin.tissoires at gmail.com] >> > Subject: Re: [PATCH v2 5/5] ACPI: button: Obselete acpi_lid_open() invocations >> > >> > On Tue, May 9, 2017 at 9:02 AM, Lv Zheng <lv.zheng...

Hi, Benjamin > From: linux-acpi-owner at vger.kernel.org [mailto:linux-acpi-owner at vger.kernel.org] On Behalf Of Benjamin > Tissoires > Subject: Re: [PATCH v2 5/5] ACPI: button: Obselete acpi_lid_open() invocations > > Hi Lv, > > I am trying to reduce the number of parallel discussion we have on the > same subject, but there is something here I can't let you have. OK. So let's stop talking in PATCH 4-5. They are actually cleanups from my point of view. In fact, I don...

...On Mon, May 15, 2017 at 5:55 AM, Zheng, Lv <lv.zheng at intel.com> wrote: > Hi, Benjamin > >> From: linux-acpi-owner at vger.kernel.org [mailto:linux-acpi-owner at vger.kernel.org] On Behalf Of Benjamin >> Tissoires >> Subject: Re: [PATCH v2 5/5] ACPI: button: Obselete acpi_lid_open() invocations >> >> Hi Lv, >> >> I am trying to reduce the number of parallel discussion we have on the >> same subject, but there is something here I can't let you have. > > OK. So let's stop talking in PATCH 4-5. > They are actually cleanups from my...

...uld provide a fake state for the _LID acpi call, and until we reach an agreement on how to handle things, there is no point changing the currently working code in i915. It is true that there is an issue in i915 regarding the fact that intel_lid_notify() doesn't use the provided value but calls acpi_lid_open(), but this is something that can be solved in https://bugs.freedesktop.org/show_bug.cgi?id=100923, when the situation clarifies. Cheers, Benjamin

...cpi call, and until we reach an agreement on how to > handle things, there is no point changing the currently working code > in i915. Fair enough. > It is true that there is an issue in i915 regarding the fact that > intel_lid_notify() doesn't use the provided value but calls > acpi_lid_open(), but this is something that can be solved in > https://bugs.freedesktop.org/show_bug.cgi?id=100923, when the > situation clarifies. The snarky reply here might be that we're just following the documentation of acpi_lid_notifier_register(), acpi_lid_open(), and friends. ;) BR, Jani....

On Wed, Feb 17, 2010 at 10:42:43AM +0100, Daniel Mack wrote: > Fix the following compile time error: > > drivers/built-in.o: In function `nouveau_connector_detect': > /home/daniel/src/linux/jup/linux-2.6/drivers/gpu/drm/nouveau/nouveau_connector.c:243: undefined reference to `acpi_lid_open' > > Signed-off-by: Daniel Mack <daniel at caiaq.de> > Cc: David Airlie <airlied at linux.ie> > Cc: Ben Skeggs <bskeggs at redhat.com> > Cc: Francisco Jerez <currojerez at riseup.net> > Cc: Maarten Maathuis <madman2003 at gmail.com> > Cc: Xavi...

On Mon, 15 May 2017, Benjamin Tissoires <benjamin.tissoires at gmail.com> wrote: > I'll answer everything in the other thread, where there are slightly > more other points raised: https://lkml.org/lkml/2017/5/15/10 If you are discussing changes impacting i915, please keep intel-gfx list in the loop. Thanks, Jani. -- Jani Nikula, Intel Open Source Technology Center

Both nouveau and i915, the only 2 kernel space lid notification listeners, invoke acpi_lid_open() API to obtain _LID returning value instead of using the notified value. So this patch moves this logic from listeners to lid driver, always notify kernel space listeners using _LID returning value. This is a no-op cleanup, but facilitates administrators to configure to notify kernel drivers wit...

Hi Lv, On May 27 2017 or thereabouts, Lv Zheng wrote: > Both nouveau and i915, the only 2 kernel space lid notification listeners, > invoke acpi_lid_open() API to obtain _LID returning value instead of using > the notified value. > > So this patch moves this logic from listeners to lid driver, always notify > kernel space listeners using _LID returning value. > > This is a no-op cleanup, but facilitates administrators to configur...