search for: acpi_evaluate_dsm

On Thu, May 4, 2017 at 4:21 AM, Andy Shevchenko <andriy.shevchenko at linux.intel.com> wrote: > acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16 > bytes. Instead we convert them to use uuid_le type. At the same time we > convert current users. > > acpi_str_to_uuid() becomes useless after the conversion and it's safe to > get rid of it. > > The conversion fixes a pot...

acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16 bytes. Instead we convert them to use uuid_le type. At the same time we convert current users. acpi_str_to_uuid() becomes useless after the conversion and it's safe to get rid of it. The conversion fixes a potential bug in int340x_thermal as...

...nouveau/nouveau_acpi.c > +++ b/drm/nouveau/nouveau_acpi.c > @@ -88,12 +88,12 @@ static int nouveau_evaluate_optimus_dsm(acpi_handle handle, int func, int arg, u > for (i = 0; i < 4; i++) > args_buff[i] = (arg >> i * 8) & 0xFF; > > - obj = acpi_evaluate_dsm_typed(handle, nouveau_op_dsm_muid, nouveau_op_dsm_rid, > - func, &argv4, ACPI_TYPE_BUFFER); > + obj = acpi_evaluate_dsm(handle, nouveau_op_dsm_muid, nouveau_op_dsm_rid, > + func, &argv4); > if (!obj)...

...nouveau/nouveau_acpi.c >>> @@ -88,12 +88,12 @@ static int nouveau_evaluate_optimus_dsm(acpi_handle handle, int func, int arg, u >>> for (i = 0; i < 4; i++) >>> args_buff[i] = (arg >> i * 8) & 0xFF; >>> >>> - obj = acpi_evaluate_dsm_typed(handle, nouveau_op_dsm_muid, nouveau_op_dsm_rid, >>> - func, &argv4, ACPI_TYPE_BUFFER); >>> + obj = acpi_evaluate_dsm(handle, nouveau_op_dsm_muid, nouveau_op_dsm_rid, >>> + func, &argv4)...

...e = ACPI_TYPE_BUFFER, > - .buffer.length = 4, > - .buffer.pointer = args_buff > - }; > - > - /* ACPI is little endian, AABBCCDD becomes {DD,CC,BB,AA} */ > - for (i = 0; i < 4; i++) > - args_buff[i] = (arg >> i * 8) & 0xFF; > - > *result = 0; > obj = acpi_evaluate_dsm_typed(handle, nouveau_op_dsm_muid, 0x00000100, > - func, &argv4, ACPI_TYPE_BUFFER); > + func, NULL, ACPI_TYPE_PACKAGE); The last parameter you give to `acpi_evaluate_dsm_typed()` is the return type you expect (see [3]), which will be a buffer if func is 0, and is implem...

On Thu, May 04, 2017 at 12:21:51PM +0300, Andy Shevchenko wrote: > acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16 > bytes. Instead we convert them to use uuid_le type. At the same time we > convert current users. > > acpi_str_to_uuid() becomes useless after the conversion and it's safe to > get rid of it. > > The conversion fixes a p...

On Fri, May 5, 2017 at 9:20 AM, Dan Williams <dan.j.williams at intel.com> wrote: > On Thu, May 4, 2017 at 2:21 AM, Andy Shevchenko > <andriy.shevchenko at linux.intel.com> wrote: >> acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16 >> bytes. Instead we convert them to use uuid_le type. At the same time we >> convert current users. >> >> acpi_str_to_uuid() becomes useless after the conversion and it's safe to >> get rid of it. >> >&gt...

https://bugs.freedesktop.org/show_bug.cgi?id=76319 Priority: medium Bug ID: 76319 Assignee: nouveau at lists.freedesktop.org Summary: [NVE6] MMIO FAULT, black screen on K2100M QA Contact: xorg-team at lists.x.org Severity: blocker Classification: Unclassified OS: Linux (All) Reporter: d-bugzilla at moens.cc

...} -static int nouveau_dsm(acpi_handle handle, int func, int arg) +static int nouveau_mux_dsm(acpi_handle handle, int func, int arg) { int ret = 0; union acpi_object *obj; @@ -137,7 +137,7 @@ static int nouveau_dsm(acpi_handle handle, int func, int arg) .integer.value = arg, }; - obj = acpi_evaluate_dsm_typed(handle, nouveau_dsm_muid, 0x00000102, + obj = acpi_evaluate_dsm_typed(handle, nouveau_mux_dsm_muid, 0x00000102, func, &argv4, ACPI_TYPE_INTEGER); if (!obj) { acpi_handle_info(handle, "failed to evaluate _DSM\n"); @@ -153,30 +153,30 @@ static int nouveau_dsm(acpi_...

...er = args_buff > > - }; > > - > > - /* ACPI is little endian, AABBCCDD becomes {DD,CC,BB,AA} */ > > - for (i = 0; i < 4; i++) > > - args_buff[i] = (arg >> i * 8) & 0xFF; > > - > > *result = 0; > > obj = acpi_evaluate_dsm_typed(handle, nouveau_op_dsm_muid, > 0x00000100, > > - func, &argv4, ACPI_TYPE_BUFFER); > > + func, NULL, ACPI_TYPE_PACKAGE); > > The last parameter you give to `acpi_evaluate_dsm_typed()` is the return &gt...

On Thu, May 4, 2017 at 2:21 AM, Andy Shevchenko <andriy.shevchenko at linux.intel.com> wrote: > acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16 > bytes. Instead we convert them to use uuid_le type. At the same time we > convert current users. > > acpi_str_to_uuid() becomes useless after the conversion and it's safe to > get rid of it. > > The conversion fixes a pot...

...} -static int nouveau_dsm(acpi_handle handle, int func, int arg) +static int nouveau_mux_dsm(acpi_handle handle, int func, int arg) { int ret = 0; union acpi_object *obj; @@ -137,7 +137,7 @@ static int nouveau_dsm(acpi_handle handle, int func, int arg) .integer.value = arg, }; - obj = acpi_evaluate_dsm_typed(handle, nouveau_dsm_muid, 0x00000102, + obj = acpi_evaluate_dsm_typed(handle, nouveau_mux_dsm_muid, 0x00000102, func, &argv4, ACPI_TYPE_INTEGER); if (!obj) { acpi_handle_info(handle, "failed to evaluate _DSM\n"); @@ -153,30 +153,30 @@ static int nouveau_dsm(acpi_...

https://bugs.freedesktop.org/show_bug.cgi?id=70354 Priority: medium Bug ID: 70354 Assignee: nouveau at lists.freedesktop.org Summary: Failed to initialise context object: 2D_NVC0 (0) (for my GeForce GT 750M) QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: