Displaying 5 results from an estimated 5 matches for "acn_channels".
2017 Apr 10
2
[Patch] Non-diegetic support for channel mapping 254
...OPUS_UNIMPLEMENTED is used for things that may one day be implemented.
Done.
Also, many sure you catch all non-sensical values. For example, what if
channels is set to 1000?
Done.
3) From the draft, it seems like you can only have two nondiegetic
channels, so instead of:
+ nb_streams = acn_channels + ((nondiegetic_channels / 2) % 2);
+ nb_coupled_streams = nondiegetic_channels / 2;
Why not just have:
+ nb_streams = acn_channels + nondiegetic_channels;
+ nb_coupled_streams = nondiegetic_channels != 0;
Done
4) About this change:
- if (!validate_layout(&st->layout) ||...
2017 Apr 07
2
[Patch] Non-diegetic support for channel mapping 254
Hello all,
Attached is a proposed patch for Opus that allows support for encoding
non-diegetic stereo audio as a coupled stream for use with channel mapping
254. It also rejects channel counts that are not (n+1)^2 + 2j, where n is 0
to 14 and j is either 0 or 1 (See IETF public draft doc attached for
clarification).
Please let me know any suggestions / concerns / comments.
Thank you for your
2017 Apr 07
0
[Patch] Non-diegetic support for channel mapping 254
...urn OPUS_BAD_ARG.
OPUS_UNIMPLEMENTED is used for things that may one day be implemented.
Also, many sure you catch all non-sensical values. For example, what if
channels is set to 1000?
3) From the draft, it seems like you can only have two nondiegetic
channels, so instead of:
+ nb_streams = acn_channels + ((nondiegetic_channels / 2) % 2);
+ nb_coupled_streams = nondiegetic_channels / 2;
Why not just have:
+ nb_streams = acn_channels + nondiegetic_channels;
+ nb_coupled_streams = nondiegetic_channels != 0;
4) About this change:
- if (!validate_layout(&st->layout) ||
!valid...
2017 Apr 24
0
[Patch] Non-diegetic support for channel mapping 254
...;
>
> Also, many sure you catch all non-sensical values. For example, what if
> channels is set to 1000?
>
>
> Done.
>
>
> 3) From the draft, it seems like you can only have two nondiegetic
> channels, so instead of:
> + nb_streams = acn_channels + ((nondiegetic_channels / 2) % 2);
> + nb_coupled_streams = nondiegetic_channels / 2;
>
> Why not just have:
> + nb_streams = acn_channels + nondiegetic_channels;
> + nb_coupled_streams = nondiegetic_channels != 0;
>
> Done
>
>
>...
2017 Apr 25
2
[Patch] Non-diegetic support for channel mapping 254
...all non-sensical values. For example, what
> if
> > channels is set to 1000?
> >
> >
> > Done.
> >
> >
> > 3) From the draft, it seems like you can only have two nondiegetic
> > channels, so instead of:
> > + nb_streams = acn_channels + ((nondiegetic_channels / 2) % 2);
> > + nb_coupled_streams = nondiegetic_channels / 2;
> >
> > Why not just have:
> > + nb_streams = acn_channels + nondiegetic_channels;
> > + nb_coupled_streams = nondiegetic_channels != 0;
> >
&g...