Displaying 5 results from an estimated 5 matches for "access_group_inner".
2020 Jun 24
6
[RFC] Compiled regression tests.
Am Mi., 24. Juni 2020 um 10:12 Uhr schrieb David Blaikie <dblaikie at gmail.com>:
> > As mentioned in the Differential, generating the tests automatically
> > will lose information about what actually is intended to be tested,
>
> Agreed - and I didn't mean to suggest tests should be automatically
> generated. I work pretty hard in code reviews to encourage tests to
2020 Jul 01
2
[RFC] Compiled regression tests.
...line, and we have no CHECK-SAME-DAG or CHECK-DAG-SAME. Even if we had
> it, the actual line that changed is textually the same and FileCheck would
> need to backtrack deep into the following lines for alternative placeholder
> substitutions. It would look like
>
> CHECK-SAME-DAG: ![[ACCESS_GROUP_INNER:[0-9]+]]
> CHECK-SAME-DAG: ,
> CHECK-SAME-DAG: ![[ACCESS_GROUP_OUTER:[0-9]+]]
Would this not work?
CHECK-SAME: ![[ACCESS_GROUP_INNER:[0-9]+]]
CHECK-SAME: ![[ACCESS_GROUP_OUTER:[0-9]+]]
I don't think CHECK-SAME is sensitive to order within the line. This
works for me in my metadata tes...
2020 Jul 01
5
[RFC] Compiled regression tests.
...the instruction is marked parallel for both loops.
Even the change should have no effect on correctness, `ninja check-llvm` fails:
test/Transforms/Inline/parallel-loop-md-merge.ll
string not found in input
; CHECK: ![[ACCESSES_INNER]] = !{!"llvm.loop.parallel_accesses", ![[ACCESS_GROUP_INNER]]}
^
<stdin>:45:1: note: scanning from here
!7 = !{!"llvm.loop.parallel_accesses", !5}
^
<stdin>:45:1: note: with "ACCESSES_INNER" equal to "7"
!7 = !{!"llvm.loop.parallel_accesses", !5}
^
<stdin>:45:...
2020 Jul 01
6
[RFC] Compiled regression tests.
...loops.
>
> Even the change should have no effect on correctness, `ninja
> check-llvm` fails:
>
> test/Transforms/Inline/parallel-loop-md-merge.ll
>
> string not found in input
> ; CHECK: ![[ACCESSES_INNER]] = !{!"llvm.loop.parallel_accesses",
> ![[ACCESS_GROUP_INNER]]}
> ^
> <stdin>:45:1: note: scanning from here
> !7 = !{!"llvm.loop.parallel_accesses", !5}
> ^
> <stdin>:45:1: note: with "ACCESSES_INNER" equal to "7"
> !7 = !{!"llvm.loop.parallel_accesses", !...
2020 Jul 06
2
[RFC] Compiled regression tests.
Michael Kruse via llvm-dev <llvm-dev at lists.llvm.org> writes:
>> Would this not work?
>>
>> CHECK-SAME: ![[ACCESS_GROUP_INNER:[0-9]+]]
>> CHECK-SAME: ![[ACCESS_GROUP_OUTER:[0-9]+]]
>>
>> I don't think CHECK-SAME is sensitive to order within the line. This
>> works for me in my metadata tests but maybe I've just been lucky.
>
> AFAIU this will assume ACCESS_GROUP_INNER to appear befor...