search for: acceptpromiscuous

...eader; > + > +/** > + * Open a socket > + * > + * @param:socket, the socket to open > + * > + * @out: error code, 0 on success, -1 on failure > + */ > +int core_udp_open(struct pxe_pvt_inode *socket) > +{ > + memset(&udata, 0, sizeof(udata)); > + udata.AcceptPromiscuous = TRUE; > + udata.AcceptAnyPort = TRUE; Why promiscuous? That seems to want to accept it on any local address and put the NIC into promiscuous mode, avoiding the default MAC filter in the NIC. This should be uncessary as we're not capturinig. > +/** > + * Establish a connection...

...; > + * > > + * @param:socket, the socket to open > > + * > > + * @out: error code, 0 on success, -1 on failure > > + */ > > +int core_udp_open(struct pxe_pvt_inode *socket) > > +{ > > > + memset(&udata, 0, sizeof(udata)); > > + udata.AcceptPromiscuous = TRUE; > > + udata.AcceptAnyPort = TRUE; > > Why promiscuous? That seems to want to accept it on any local address > and put the NIC into promiscuous mode, avoiding the default MAC filter > in the NIC. This should be uncessary as we're not capturinig. If I remember cor...

...truct pxe_pvt_ino /* Re-use the existing local port number */ udata.StationPort = socket->net.efi.localport; - udata.UseDefaultAddress = TRUE; + udata.UseDefaultAddress = FALSE; memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); udata.RemotePort = port; udata.AcceptPromiscuous = TRUE; udata.TimeToLive = 64; + ip = IPInfo.myip; + memcpy(&udata.StationAddress, &ip, sizeof(ip)); + ip = IPInfo.netmask; + memcpy(&udata.SubnetMask, &ip, sizeof(ip)); status = core_udp_configure(udp, &udata, L"core_udp_connect"); if (sta...

...ult MAC filter > in the NIC.? This should be uncessary as we're not capturinig. If I remember correctly, this was required for TFTP boot because otherwise it's impossible to accept DHCP packets when we have no IP address assigned. I'm not suggesting that is the intention of the AcceptPromiscuous flag, only that it was the observed behaviour on my test machine. <<< That's probably required by the DHCP layer within the FW, but whenever there's a TFTP transfer (either triggered by the FW or NBP) sure we must already have a defined IP then it shouldn't be necessary....

...the existing local port number */ > udata.StationPort = socket->net.efi.localport; > > - udata.UseDefaultAddress = TRUE; > + udata.UseDefaultAddress = FALSE; > memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); > udata.RemotePort = port; > udata.AcceptPromiscuous = TRUE; > udata.TimeToLive = 64; > + ip = IPInfo.myip; > + memcpy(&udata.StationAddress, &ip, sizeof(ip)); > + ip = IPInfo.netmask; > + memcpy(&udata.SubnetMask, &ip, sizeof(ip)); > > status = core_udp_configure(udp, &udata, L"core...

...o.netmask; + memcpy(&udata.SubnetMask, &tip, sizeof(tip)); + } else { + /*on different subnets*/ + udata.UseDefaultAddress = TRUE; + } + } + memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); udata.RemotePort = port; udata.AcceptPromiscuous = TRUE; @@ -350,6 +374,7 @@ void core_udp_sendto(struct pxe_pvt_inod EFI_STATUS status; struct efi_binding *b; EFI_UDP4 *udp; + uint32_t tip; (void)socket; @@ -372,7 +397,30 @@ void core_udp_sendto(struct pxe_pvt_inod /* Re-use the existing local port number */...

...>this; - memset(&udata, 0, sizeof(udata)); - - /* Re-use the existing local port number */ - udata.StationPort = socket->net.efi.localport; - - udata.UseDefaultAddress = TRUE; - memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); - udata.RemotePort = port; - udata.AcceptPromiscuous = TRUE; - udata.TimeToLive = 64; - - status = core_udp_configure(udp, &udata, L"core_udp_connect"); - if (status != EFI_SUCCESS) { - Print(L"Failed to configure UDP: %d\n", status); - return; - } + EFI_STATUS status; + UDP_IO* udp_io; + + udp_io = (UDP_...

...----------- next part -------------- diff --git a/efi/udp.c b/efi/udp.c index 59bb426..60a8fe9 100644 --- a/efi/udp.c +++ b/efi/udp.c @@ -41,8 +41,7 @@ int core_udp_open(struct pxe_pvt_inode *socket) udp = (EFI_UDP4 *)udp_reader->this; memset(&udata, 0, sizeof(udata)); - udata.AcceptPromiscuous = TRUE; - udata.AcceptAnyPort = TRUE; + udata.AcceptBroadcast = TRUE; status = uefi_call_wrapper(udp->Configure, 2, udp, &udata); if (status != EFI_SUCCESS) @@ -50,6 +49,18 @@ int core_udp_open(struct pxe_pvt_inode *socket) socket->net.efi.binding = b; + /* +...

I did change both instances of txdata->GatewayAddress, but I think something may be wrong in my toolchain. If I extract syslinux.zip and attempt to make from there (without modifying any files), the cached DHCP packet isn't read on the same subnet. I receive "Succeed to download NBP file." twice before anything from syslinux is loaded, so I believe the duplicate request for

The variable 'ok' is never used and generates a warning. Remove it. Also ntfssect.c is designed to be compiled in non Unicode mode when using MSVC compilers, so remove all ambiguity about it (LPCTSTR -> LPCSTR, use of 'A' API calls) so that it doesn't break when compiled in Unicode mode, which is what Rufus uses with MSVC. -------------- next part --------------

...data, 0, sizeof(udata)); /* Re-use the existing local port number */ udata.StationPort = socket->net.efi.localport; -- udata.UseDefaultAddress = TRUE; ++ udata.UseDefaultAddress = FALSE; memcpy(&udata.RemoteAddress, &ip, sizeof(ip)); udata.RemotePort = port; udata.AcceptPromiscuous = TRUE; udata.TimeToLive = 64; ++ ip = IPInfo.myip; ++ memcpy(&udata.StationAddress, &ip, sizeof(ip)); ++ ip = IPInfo.netmask; ++ memcpy(&udata.SubnetMask, &ip, sizeof(ip)); status = core_udp_configure(udp, &udata, L"core_udp_connect"); if (status != E...