search for: acc_acl

This is a PoC patch for NFSv4/ZFS ACLs. The objective of the patch is that rsync --acls support NFSv4/ZFS ACLs without requiring a new command line option NFSv4 ACLs can't be represented using POSIX draft ACLs, if an NFSv4 ACL is present a separate POSIX draft ACL will not be present and there are new APIs to access NFSv4 ACLs. So we need to distinguish between NFSv4 ACLs and POSIX ACLs in

...rsions 3.0.6, 3.0.7 & HEAD, it is in generator.c. There is an error path that takes a 'goto' that skips the initialization of sx struct, then the cleanup tries to free random memory with a call to free_acl(&sx). In acls.c the free is void free_acl(stat_x *sxp) { if (sxp->acc_acl) { rsync_acl_free(sxp->acc_acl); free(sxp->acc_acl); <<<<<<< uninitialized In version 3.0.6 the 'bad' goto is at line 1315: rprintf(FERROR_XFER, "skipping daemon...

...p level structure, including the pointer to sx.xattr. The free_xattr(&real_sx) descends into real_sx.attr (which is pointing to the same location as sx.xattr) and frees up the malloced memory, and then the free_xattr(&sx) tries to do the same thing and we go "pop!". Note that sx.acc_acl and sx.def_acl have the same issue (I'm not using acls so I'm not seeing the problem there). I had a look at doing a deep copy of sx into real_sx as my first thought, however that quickly turned into a maze of twisty little mallocs, all alike, and I'm not sure the complexity is necessa...

Hi, I'm using 2.6.9 but I get: recv_files phase=1 generate_files phase=2 recv_files phase=2 recv_files finished generate_files phase=3 deleting in home delete_in_dir(home) [generator] make_file(home/administ,*,2) Internal error: wrong write used in receiver. _exit_cleanup(code=2, file=io.c, line=1204): entered _exit_cleanup(code=19, file=main.c, line=1182): entered rsync error: received