Displaying 5 results from an estimated 5 matches for "abs_socket".
2018 Jun 21
2
[PATCH v3] lib: libvirt: Convert all drive socket parameters to an absolute path (RHBZ#1588451).
https://bugzilla.redhat.com/show_bug.cgi?id=1588451
v2 was here:
https://www.redhat.com/archives/libguestfs/2018-June/msg00067.html
This is a greatly simplified version, which just changes the libvirt
backend to make the path absolute. None of the tests need to be
adjusted.
Rich.
2018 Jun 21
0
[PATCH v3] lib: libvirt: Convert all drive socket parameters to an absolute path (RHBZ#1588451).
...struct_libvirt_xml_disk_source_hosts (guestfs_h *g,
}
case drive_transport_unix: {
+ /* libvirt requires sockets to be specified as an absolute path
+ * (RHBZ#1588451).
+ */
+ const char *socket = src->servers[i].u.socket;
+ CLEANUP_FREE char *abs_socket = realpath (socket, NULL);
+
+ if (abs_socket == NULL) {
+ perrorf (g, _("realpath: could not convert ‘%s’ to absolute path"),
+ socket);
+ return -1;
+ }
+
attribute ("transport", "unix");
- attribute (...
2018 Oct 04
0
[PATCH v2 2/4] common/utils: Move libxml2 writer macros to a common header file.
...attribute ("port", "%d", src->servers[i].port);
break;
}
@@ -1722,7 +1659,7 @@ construct_libvirt_xml_disk_source_hosts (guestfs_h *g,
}
attribute ("transport", "unix");
- attribute ("socket", abs_socket);
+ attribute ("socket", "%s", abs_socket);
break;
}
}
@@ -1758,11 +1695,11 @@ construct_libvirt_xml_appliance (guestfs_h *g,
attribute ("device", "disk");
start_element ("source") {
- attribute ("...
2018 Oct 04
2
[PATCH 0/2] Use common macros to help with libxml2 writer.
Consolidate and extend the use of funky start_element() etc macros.
Rich.
2018 Oct 04
6
[PATCH v2 0/4] common/utils: Move libxml2 writer macros to a common header file.
v1 was here:
https://www.redhat.com/archives/libguestfs/2018-October/msg00047.html
However it was broken in a few ways. First of all the documentation
was broken because "/**" enhanced comments were not permitted on
macros. This is fixed in the new 1/4 patch.
Secondly we didn't use single_element() everywhere possible, which
is fixed in the new 4/4 patch.
Lastly I've