Displaying 11 results from an estimated 11 matches for "abs_residual_partition_sums".
2015 May 18
1
A condition in precompute_partition_info_sums_()
The commit http://git.xiph.org/?p=flac.git;a=commitdiff;h=0a0a10f358345f749e4a05021301461994f1ffc5
(from 31 Mar 2007) adds the following conditional:
if(FLAC__bitmath_ilog2(default_partition_samples) + bps < 32)
And the commit http://git.xiph.org/?p=flac.git;a=commitdiff;h=f081524c19eeafd08f4db6ee5d52a9634c60f475
has this:
if(FLAC__bitmath_ilog2(default_partition_samples) +
2016 May 02
1
[PATCH] workaround for a bug in MSVC 2015 U2
...a comment
> above the workaround.
:sigh: I hoped that somebody else will find what's wrong and will create a bugreport...
Well, here is the link: https://connect.microsoft.com/VisualStudio/feedback/details/2659191/incorrect-code-generation-for-x86-64
It seems that MSVC miscompiles
abs_residual_partition_sums[partition] = (FLAC__uint32)_mm_cvtsi128_si32(mm_sum);
into
movq QWORD PTR [rsi], xmm2
So it incorrectly copies 8 bytes from mm_sum to abs_residual_partition_sums[partition]
(it should copy 4 lower bytes and zero out 4 upper bytes).
It should be something like
movd eax, xmm2
m...
2014 Jan 26
1
PATCH for FLAC__precompute_partition..., part 2
Just realized that it's also possible to do the same with "if(bps <= 16)"
branch of code and remove FLAC__uint32 abs_residual_partition_sum variable.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: precomp_part2.patch
Type: application/octet-stream
Size: 5153 bytes
Desc: not available
Url :
2014 Mar 09
1
PATCH: coding style fixes
a) A previous patch for stream_encoder_intrin_xxxx.c removes
definitions of abs_residual_partition_sum variables but leaves
unnecessary empty line after it. The first attached patch removes them.
b) The second attached patch fixes coding style for lpc_asm.nasm:
mov{space}ebp, esp
to
mov{tab}ebp, esp
etc.
-------------- next part --------------
A non-text attachment was scrubbed...
2016 May 02
2
[PATCH] workaround for a bug in MSVC 2015 U2
Erik de Castro Lopo wrote:
>> As I wrote earlier, MSVC 2015 U2 incorrectly compiles
>> stream_encoder_intrin_*.c files for x86-64 platform.
>> As a result, flac works, but compression ratio is close to 1.
>> This patch disables some compiler optimizations, and
>> compression ratio reverts back to normal values.
>
> Rather than having the same chunk of code in
2016 May 02
3
[PATCH] MSVC2015U2 workaround, version 2
Here's a new version of a patch that fixes a problem with MSVC2105 update2,
but it doesn't disable any optimization, so the resulting encoding
performance should be almost unaffected by this workaround.
MSVC compiles
abs_residual_partition_sums[partition] = (FLAC__uint32)_mm_cvtsi128_si32(mm_sum);
into this:
movq QWORD PTR [rsi], xmm2
while it should be
movd eax, xmm2
mov QWORD PTR [rsi], rax
With this patch, MSVC emits
movq QWORD PTR [rsi], xmm2
mov DWORD PTR [rsi+4], r9d
so the price of t...
2014 Jun 19
7
[PATCH] stream_encoder : Improve selection of residual accumulator width
...+ /* WATCHOUT: "+ bps + FLAC__MAX_EXTRA_RESIDUAL_BPS" is the maximum
+ * assumed size of the average residual magnitude */
+ if(FLAC__bitmath_ilog2(default_partition_samples) + bps + FLAC__MAX_EXTRA_RESIDUAL_BPS < 32) {
FLAC__precompute_partition_info_sums_32bit_asm_ia32_(residual, abs_residual_partition_sums, residual_samples + predictor_order, predictor_order, min_partition_order, max_partition_order);
return;
}
@@ -3884,10 +3883,9 @@ void precompute_partition_info_sums_(
/* first do max_partition_order */
{
unsigned partition, residual_sample, end = (unsigned)(-(int)predictor_order);
- /...
2007 Apr 08
0
FLAC 24 bit test results
...ions; would require moving this out into a separate function, then checking its capacity against the need of the current blocksize&min/max_partition_order (and maybe predictor order) */
ok = ok && FLAC__memory_alloc_aligned_uint64_array(new_blocksize * 2, &encoder->private_->abs_residual_partition_sums_unaligned, &encoder->private_->abs_residual_partition_sums);
- if(encoder->protected_->do_escape_coding)
- ok = ok && FLAC__memory_alloc_aligned_unsigned_array(new_blocksize * 2, &encoder->private_->raw_bits_per_partition_unaligned, &encoder->private_->r...
2007 Apr 05
2
FLAC 24 bit test results
On Thu, 2007-04-05 at 02:27 -0700, Brian Willoughby wrote:
> Josh (Green),
>
> Seems like the longest example in your list is a 15-second file. I
> would like to see the same problem exhibited in a file that is of a
> normal length. I have been recording full performances lasting
> hours, and flac always compresses the files below 70% of the original
> size.
>
2012 Apr 05
2
[PATCH 2/2] V2: Use a single definition of MIN and MAX in sources
...ion_order_from_blocksize_limited_max_and_predictor_order(max_partition_order, blocksize, predictor_order);
- min_partition_order = min(min_partition_order, max_partition_order);
+ min_partition_order = flac_min(min_partition_order, max_partition_order);
precompute_partition_info_sums_(residual, abs_residual_partition_sums, residual_samples, predictor_order, min_partition_order, max_partition_order, bps);
@@ -3735,7 +3726,7 @@ unsigned find_best_partition_order_(
unsigned partition;
/* save best parameters and raw_bits */
- FLAC__format_entropy_coding_method_partitioned_rice_contents_ensure_size(prc, max(6...
2012 Apr 07
1
[PATCH 2/2] Update and improve autotools build
- INCLUDES is deprecated, and CPPFLAGS is an user-defined
variable, use the proper AM_CPPFLAGS instead
- Remove FLAC__INLINE definition, providing proper
replacement for MSVC compilers.
- Detect if we have C99 's lround and provide a replacement
for windows...
---
configure.ac | 32 ++++++++--------------------
examples/c/decode/file/Makefile.am