search for: ab7760fc

...d sees something interesting to break > out of its poll() loop, regardless of whether it also sees something > interesting from the server after having sent NBD_CMD_DISC, and > regardless of whether I need to add in more gnutls_bye() calls to > either nbdkit or libnbd. > > Fixes: ab7760fc > Signed-off-by: Eric Blake <eblake@redhat.com> > --- > > May be incomplete: I might also need to break out of the reader loop > when read() returns 0. > > plugins/nbd/nbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/plugins/nbd/...

...bnbd && make check PATH=/path/to/nbdkit' and 'cd /path/to/nbdkit && /path/to/libnbd/run make check' will hang without this series. In short, this series is restoring the shutdown(SHUT_WR) call that got lost from plugins/nbd/nbd.c when nbdkit switched to libnbd in commit ab7760fc. Eric Blake (2): sockets: Add .shut_writes callback states: Add state for shutdown/gnutls_bye after NBD_CMD_DISC lib/internal.h | 4 +++- generator/state_machine.ml | 19 +++++++++++++++++-- generator/states-issue-command.c | 20 ++++++++++++++++++-- lib/crypto.c...

I still need more soak time on testing, to see whether I can: a) reproduce the hang with patch 2 not applied b) feel confident that patch 2 is sufficient to fix the race, or else determine that I also need to augment the loop condition in the reader thread to additionally break out of the loop when the pipe-to-self sees EOF even when nbd_aio_is_dead() has not yet been satisfied I'm also

...he socket first, we end up with two processes deadlocked on each other. (nbdkit as server has used gnutls_bye since commit bd9a52e0; qemu however does not use it.) Other commits such as 14ba4154, c70616f8, and 430f8141 show that getting the shutdown sequence race-free has not been trivial. Fixes: ab7760fc Signed-off-by: Eric Blake <eblake@redhat.com> --- plugins/nbd/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/nbd/nbd.c b/plugins/nbd/nbd.c index ba1e7188..0ea2a4a2 100644 --- a/plugins/nbd/nbd.c +++ b/plugins/nbd/nbd.c @@ -532,7 +532,7 @@ nbdplug_open (int...

.../path/to/nbdkit:$PATH > and 'cd /path/to/nbdkit && > /path/to/libnbd/run make check' will hang without this series. > > In short, this series is restoring the shutdown(SHUT_WR) call that got > lost from plugins/nbd/nbd.c when nbdkit switched to libnbd in commit > ab7760fc. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

...uarantee that the reader thread sees something interesting to break out of its poll() loop, regardless of whether it also sees something interesting from the server after having sent NBD_CMD_DISC, and regardless of whether I need to add in more gnutls_bye() calls to either nbdkit or libnbd. Fixes: ab7760fc Signed-off-by: Eric Blake <eblake@redhat.com> --- May be incomplete: I might also need to break out of the reader loop when read() returns 0. plugins/nbd/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/nbd/nbd.c b/plugins/nbd/nbd.c index e5b8f338..23a7da06...