search for: a7949972a

Compare it to the right variable, not to the pointer itself. Fixes commit 3637c42f4e521eb647d7dfae7f48eb1689d0af54. --- rescue/escape.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rescue/escape.c b/rescue/escape.c index a7949972a..3bb69578b 100644 --- a/rescue/escape.c +++ b/rescue/escape.c @@ -49,7 +49,7 @@ parse_escape_key (const char *arg) return 0; len = strlen (arg); - if (arg == 0) + if (len == 0) return -1; switch (arg[0]) { -- 2.13.6

...@@ -152,10 +152,10 @@ CLEANFILES += \ cleanups.c \ cleanups.h \ guestfs-internal-all.h \ - guestfs-internal-frontend.h \ ignore-value.h \ stamp-extra-files \ - utils.c + utils.c \ + utils.h clean-local: rm -rf build dist diff --git a/rescue/escape.c b/rescue/escape.c index f7f7d84c4..a7949972a 100644 --- a/rescue/escape.c +++ b/rescue/escape.c @@ -30,7 +30,7 @@ #include "c-ctype.h" #include "guestfs.h" -#include "guestfs-internal-frontend.h" +#include "guestfs-utils.h" #include "rescue.h" diff --git a/rescue/rescue.c b/rescue/res...

This is just the utilities part of the patch series from: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html I believe this addresses everything raised in comments on that patch series. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid