search for: a4ebd2445eda

On Sun, Nov 24, 2019 at 03:03:52PM -0800, Jakub Kicinski wrote: > On Sun, 24 Nov 2019 16:48:35 -0500, Michael S. Tsirkin wrote: > > diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c > > index a4ebd2445eda..8e06e7407854 100644 > > --- a/arch/m68k/emu/nfeth.c > > +++ b/arch/m68k/emu/nfeth.c > > @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) > > return 0; > > } > > > > -static void nfeth_tx_timeout(struct net_device...

On Sun, 24 Nov 2019 16:48:35 -0500, Michael S. Tsirkin wrote: > diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c > index a4ebd2445eda..8e06e7407854 100644 > --- a/arch/m68k/emu/nfeth.c > +++ b/arch/m68k/emu/nfeth.c > @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) > return 0; > } > > -static void nfeth_tx_timeout(struct net_device *dev) > +static void nfeth_tx_ti...

...by: Michael S. Tsirkin <mst at redhat.com> --- Changes from v2: added headers Changes from v1: Fix errors found by kbuild: generalize the pattern a bit, to pick up a couple of instances missed by the previous version. diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c index a4ebd2445eda..8e06e7407854 100644 --- a/arch/m68k/emu/nfeth.c +++ b/arch/m68k/emu/nfeth.c @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) return 0; } -static void nfeth_tx_timeout(struct net_device *dev) +static void nfeth_tx_timeout(struct net_device *dev, int txqueu...

...by: Michael S. Tsirkin <mst at redhat.com> --- Changes from v2: added headers Changes from v1: Fix errors found by kbuild: generalize the pattern a bit, to pick up a couple of instances missed by the previous version. diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c index a4ebd2445eda..8e06e7407854 100644 --- a/arch/m68k/emu/nfeth.c +++ b/arch/m68k/emu/nfeth.c @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) return 0; } -static void nfeth_tx_timeout(struct net_device *dev) +static void nfeth_tx_timeout(struct net_device *dev, int txqueu...

On Sun, Nov 24, 2019 at 03:03:52PM -0800, Jakub Kicinski wrote: > On Sun, 24 Nov 2019 16:48:35 -0500, Michael S. Tsirkin wrote: > > diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c > > index a4ebd2445eda..8e06e7407854 100644 > > --- a/arch/m68k/emu/nfeth.c > > +++ b/arch/m68k/emu/nfeth.c > > @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) > > return 0; > > } > > > > -static void nfeth_tx_timeout(struct net_device...

...handler This allows incrementing the correct timeout statistic without any mess. Down the road, devices can learn to reset just the specific queue. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Warning: untested. diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c index a4ebd2445eda..8e06e7407854 100644 --- a/arch/m68k/emu/nfeth.c +++ b/arch/m68k/emu/nfeth.c @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) return 0; } -static void nfeth_tx_timeout(struct net_device *dev) +static void nfeth_tx_timeout(struct net_device *dev, int txqueu...

...t; --- > Warning: untested. > Question... Wouldn't be better to create a module parameter instead change the function scope? I'm asking it because how many modules would effectively take advantage of it? > > diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c > index a4ebd2445eda..8e06e7407854 100644 > --- a/arch/m68k/emu/nfeth.c > +++ b/arch/m68k/emu/nfeth.c > @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) > return 0; > } > > -static void nfeth_tx_timeout(struct net_device *dev) > +static void nfeth_t...

Hi Michael, Em sex., 22 de nov. de 2019 ?s 07:31, Michael S. Tsirkin <mst at redhat.com> escreveu: > > On Thu, Nov 21, 2019 at 10:36:36PM -0300, Julio Faracco wrote: > > Driver virtio_net is not handling error events for TX provided by > > dev_watchdog. This event is reached when transmission queue is having > > problems to transmit packets. This could happen for any

Hi Michael, Em sex., 22 de nov. de 2019 ?s 07:31, Michael S. Tsirkin <mst at redhat.com> escreveu: > > On Thu, Nov 21, 2019 at 10:36:36PM -0300, Julio Faracco wrote: > > Driver virtio_net is not handling error events for TX provided by > > dev_watchdog. This event is reached when transmission queue is having > > problems to transmit packets. This could happen for any

...t grep ndo_tx_timeout. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Changes from v1: Fix errors found by kbuild: generalize the pattern a bit, to pick up a couple of instances missed by the previous version. diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c index a4ebd2445eda..8e06e7407854 100644 --- a/arch/m68k/emu/nfeth.c +++ b/arch/m68k/emu/nfeth.c @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) return 0; } -static void nfeth_tx_timeout(struct net_device *dev) +static void nfeth_tx_timeout(struct net_device *dev, int txqueu...

On Sun, 24 Nov 2019 18:29:49 -0500, Michael S. Tsirkin wrote: > netdev: pass the stuck queue to the timeout handler > > This allows incrementing the correct timeout statistic without any mess. > Down the road, devices can learn to reset just the specific queue. FWIW Acked-by: Jakub Kicinski <jakub.kicinski at netronome.com>

...> net/bluetooth/bnep/netdev.c | 2 +- > > net/sched/sch_generic.c | 2 +- > > 229 files changed, 296 insertions(+), 285 deletions(-) > > > > diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c > > index a4ebd2445eda..d2875e32abfc 100644 > > --- a/arch/m68k/emu/nfeth.c > > +++ b/arch/m68k/emu/nfeth.c > > @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) > > return 0; > > } > > > > -static void nfeth_tx_timeout(struct net_devic...

.../lec.c | 2 +- net/bluetooth/bnep/netdev.c | 2 +- net/sched/sch_generic.c | 2 +- 234 files changed, 293 insertions(+), 290 deletions(-) diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c index a4ebd2445eda..d2875e32abfc 100644 --- a/arch/m68k/emu/nfeth.c +++ b/arch/m68k/emu/nfeth.c @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) return 0; } -static void nfeth_tx_timeout(struct net_device *dev) +static void nfeth_tx_timeout(struct net_device *dev, unsigned i...

.../lec.c | 2 +- net/bluetooth/bnep/netdev.c | 2 +- net/sched/sch_generic.c | 2 +- 234 files changed, 293 insertions(+), 290 deletions(-) diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c index a4ebd2445eda..d2875e32abfc 100644 --- a/arch/m68k/emu/nfeth.c +++ b/arch/m68k/emu/nfeth.c @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) return 0; } -static void nfeth_tx_timeout(struct net_device *dev) +static void nfeth_tx_timeout(struct net_device *dev, unsigned i...

.../lec.c | 2 +- net/bluetooth/bnep/netdev.c | 2 +- net/sched/sch_generic.c | 2 +- 234 files changed, 293 insertions(+), 290 deletions(-) diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c index a4ebd2445eda..d2875e32abfc 100644 --- a/arch/m68k/emu/nfeth.c +++ b/arch/m68k/emu/nfeth.c @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) return 0; } -static void nfeth_tx_timeout(struct net_device *dev) +static void nfeth_tx_timeout(struct net_device *dev, unsigned i...

.../lec.c | 2 +- net/bluetooth/bnep/netdev.c | 2 +- net/sched/sch_generic.c | 2 +- 235 files changed, 296 insertions(+), 293 deletions(-) diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c index a4ebd2445eda..d2875e32abfc 100644 --- a/arch/m68k/emu/nfeth.c +++ b/arch/m68k/emu/nfeth.c @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) return 0; } -static void nfeth_tx_timeout(struct net_device *dev) +static void nfeth_tx_timeout(struct net_device *dev, unsigned i...

.../lec.c | 2 +- net/bluetooth/bnep/netdev.c | 2 +- net/sched/sch_generic.c | 2 +- 236 files changed, 297 insertions(+), 294 deletions(-) diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c index a4ebd2445eda..d2875e32abfc 100644 --- a/arch/m68k/emu/nfeth.c +++ b/arch/m68k/emu/nfeth.c @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) return 0; } -static void nfeth_tx_timeout(struct net_device *dev) +static void nfeth_tx_timeout(struct net_device *dev, unsigned i...

This series add two important features. One of them changes the .ndo_tx_timeout to include an extra parameter to identify the stuck queue. Many drivers are using a nester loop to identify which queue is stooped/stucked. This is a redundant work since dev_watchdog is doing exactly the same thing. This is so interesting for other drivers to in terms of code optimization. The second part (second

This series add two important features. One of them changes the .ndo_tx_timeout to include an extra parameter to identify the stuck queue. Many drivers are using a nester loop to identify which queue is stooped/stucked. This is a redundant work since dev_watchdog is doing exactly the same thing. This is so interesting for other drivers to in terms of code optimization. The second part (second

A bunch of drivers want to know which tx queue triggered a timeout, and virtio wants to do the same. We actually have the info to hand, let's just pass it on to drivers. Note: tested with an experimental virtio patch by Julio. That patch itself isn't ready yet though, so not included. Other drivers compiled only. Michael S. Tsirkin (3): netdev: pass the stuck queue to the timeout