search for: a2a0d0eb

...ition 4 is the extended partition. > +nbdkit -f -v -D partitioning.regions=1 -U - \ > + --filter=partition \ > + partitioning \ > + partitioning1-p1 \ > + partitioning1-p2 \ > + partitioning1-p3 \ > + partitioning1-p4 \ > + type-guid=A2A0D0EB-E5B9-3344-87C0-68B6B72699C7 \ Does type-guid even work with mbr? > + file-data \ > + type-guid=AF3DC60F-8384-7247-8E79-3D69D8477DE4 \ > + partitioning1-p5 \ > + partitioning1-p6 \ > + partition-type=mbr \ > + partition=6 \ > + --run &...

...re even giving them the > magic number. (I also don't know if the "Bad message" claim from the > nbd plugin is worth improving, but that's unrelated to this series). I think this would require some rather deeper changes to the way filters work. > > + type-guid=A2A0D0EB-E5B9-3344-87C0-68B6B72699C7 \ > > Does type-guid even work with mbr? No, this is an error -- in existing code. I'll add an extra patch in v3 to catch this. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtual...

...Note we select partition 6 because partition 4 is the extended partition. +nbdkit -f -v -D partitioning.regions=1 -U - \ + --filter=partition \ + partitioning \ + partitioning1-p1 \ + partitioning1-p2 \ + partitioning1-p3 \ + partitioning1-p4 \ + type-guid=A2A0D0EB-E5B9-3344-87C0-68B6B72699C7 \ + file-data \ + type-guid=AF3DC60F-8384-7247-8E79-3D69D8477DE4 \ + partitioning1-p5 \ + partitioning1-p6 \ + partition-type=mbr \ + partition=6 \ + --run 'qemu-img convert $nbd partitioning1.out' + +cmp file-data partit...

This is a revised version of the two series previously posted here: https://www.redhat.com/archives/libguestfs/2019-January/msg00137.html https://www.redhat.com/archives/libguestfs/2019-January/msg00139.html There have been many smaller changes but the highlights are: - Using SECTOR_SIZE instead of hard-coding 512 everywhere. - Additional safety checks that the EBR chain doesn't jump

This implements support for MBR logical partitions in nbdkit-partition-filter, complementing existing support in the partitioning plugin. Rich.