Displaying 5 results from an estimated 5 matches for "a1a0438b".
2020 Mar 23
2
Re: [PATCH nbdkit 3/3] python: Remove extraneous static keyword
...function is intended to be exported, therefore
> the static keyword is not needed and prevents building on MSYS2.
> ---
> plugins/python/python.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plugins/python/python.c b/plugins/python/python.c
> index a1a0438b..adc1aaa5 100644
> --- a/plugins/python/python.c
> +++ b/plugins/python/python.c
> @@ -224,7 +224,7 @@ static struct PyModuleDef moduledef = {
> NULL
> };
>
> -static PyMODINIT_FUNC
> +PyMODINIT_FUNC
> create_nbdkit_module (void)
> {
> PyObject *m;
> -...
2020 Mar 23
0
[PATCH nbdkit 3/3] python: Remove extraneous static keyword
....com>
The create_nbdkit_module function is intended to be exported, therefore
the static keyword is not needed and prevents building on MSYS2.
---
plugins/python/python.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/python/python.c b/plugins/python/python.c
index a1a0438b..adc1aaa5 100644
--- a/plugins/python/python.c
+++ b/plugins/python/python.c
@@ -224,7 +224,7 @@ static struct PyModuleDef moduledef = {
NULL
};
-static PyMODINIT_FUNC
+PyMODINIT_FUNC
create_nbdkit_module (void)
{
PyObject *m;
--
2.25.0
2020 Mar 23
0
Re: [PATCH nbdkit 3/3] python: Remove extraneous static keyword
...d, therefore
> > the static keyword is not needed and prevents building on MSYS2.
> > ---
> > plugins/python/python.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/plugins/python/python.c b/plugins/python/python.c
> > index a1a0438b..adc1aaa5 100644
> > --- a/plugins/python/python.c
> > +++ b/plugins/python/python.c
> > @@ -224,7 +224,7 @@ static struct PyModuleDef moduledef = {
> > NULL
> > };
> >
> > -static PyMODINIT_FUNC
> > +PyMODINIT_FUNC
> > create_nbdkit_module...
2020 Mar 23
6
[PATCH nbdkit 0/3] msys2 support for review
I pushed a few of the msys2 patches upstream. I changed the way that
$(SHARED_LDFLAGS) works so it's more to my liking, and the others were
pushed unchanged. Three patches remain which I'm posting on the
mailing list for proper review.
Rich.
2020 Mar 19
5
[nbdkit PATCH 0/2] More caching of initial setup
When I added .can_FOO caching in 1.16, I missed the case that the sh
plugin itself was calling .can_flush twice in some situations (in
order to default .can_fua). Then right after, I regressed it to call
.can_zero twice (in order to default .can_fast_zero). I also missed
that .thread_model could use better caching, because at the time, I
did not add testsuite coverage. Fix that now.
Eric Blake