Displaying 4 results from an estimated 4 matches for "a00c5e6f44".
2020 Aug 09
3
multiple vms with same PCI passthrough
...ng hypervisor: QEMU 4.2.1
(fc32 default install)
The upstream code seems also to test definitions rather than active uses
of the PCI device.
My potentially naive patch to correct this (but not the failing test cases)
would be:
diff --git a/src/util/virpci.c b/src/util/virpci.c
index 47c671daa0..a00c5e6f44 100644
--- a/src/util/virpci.c
+++ b/src/util/virpci.c
@@ -1597,7 +1597,7 @@ int
virPCIDeviceListAdd(virPCIDeviceListPtr list,
virPCIDevicePtr dev)
{
- if (virPCIDeviceListFind(list, dev)) {
+ if (virPCIDeviceBusContainsActiveDevices(dev, list)) {
virReportErro...
2020 Aug 16
0
multiple vms with same PCI passthrough
...ng hypervisor: QEMU 4.2.1
(fc32 default install)
The upstream code seems also to test definitions rather than active uses
of the PCI device.
My potentially naive patch to correct this (but not the failing test cases)
would be:
diff --git a/src/util/virpci.c b/src/util/virpci.c
index 47c671daa0..a00c5e6f44 100644
--- a/src/util/virpci.c
+++ b/src/util/virpci.c
@@ -1597,7 +1597,7 @@ int
virPCIDeviceListAdd(virPCIDeviceListPtr list,
virPCIDevicePtr dev)
{
- if (virPCIDeviceListFind(list, dev)) {
+ if (virPCIDeviceBusContainsActiveDevices(dev, list)) {
virReportErro...
2020 Aug 17
0
Re: multiple vms with same PCI passthrough
...That isn't the case. You're misunderstanding what devices are on the
list. (see below for details)
>
> My potentially naive patch to correct this (but not the failing test
> cases) would be:
>
> diff --git a/src/util/virpci.c b/src/util/virpci.c
> index 47c671daa0..a00c5e6f44 100644
> --- a/src/util/virpci.c
> +++ b/src/util/virpci.c
> @@ -1597,7 +1597,7 @@ int
> virPCIDeviceListAdd(virPCIDeviceListPtr list,
> virPCIDevicePtr dev)
> {
> - if (virPCIDeviceListFind(list, dev)) {
> + if (virPCIDeviceBusContainsActiveD...
2020 Aug 18
2
Re: multiple vms with same PCI passthrough
...;re misunderstanding what devices are on the
> list. (see below for details)
>
> >
> > My potentially naive patch to correct this (but not the failing test
> > cases) would be:
> >
> > diff --git a/src/util/virpci.c b/src/util/virpci.c
> > index 47c671daa0..a00c5e6f44 100644
> > --- a/src/util/virpci.c
> > +++ b/src/util/virpci.c
> > @@ -1597,7 +1597,7 @@ int
> > virPCIDeviceListAdd(virPCIDeviceListPtr list,
> > virPCIDevicePtr dev)
> > {
> > - if (virPCIDeviceListFind(list, dev)) {
> >...