search for: _wstat

...review the patches (Aaron Ballman did a review but he doesn't have commit access). The problem is that ::stat function can't handle UTF8 paths on Windows. My solution was to get the command line arguments as UTF16 and convert them to UTF8 and then convert them back to UTF16 before calling ::_wstat. The problem is that stat structure is used throughout the code base, and ::_wstat has different parameter type. This solution is far from perfect. It seems to me that what you're discussing would solve this issue in a more general way (maybe even fix all the mess with struct stat *StatBuf bein...

...Aaron > Ballman did a review but he doesn't have commit access). The problem is that > ::stat function can't handle UTF8 paths on Windows. My solution was to get > the command line arguments as UTF16 and convert them to UTF8 and then > convert them back to UTF16 before calling ::_wstat. The problem is that stat > structure is used throughout the code base, and ::_wstat has different > parameter type. This solution is far from perfect. It seems to me that what > you're discussing would solve this issue in a more general way (maybe even > fix all the mess with struc...

...eate "Empl", which fails, setting errno to the code for "Permission denied", instead of EEXIST, the code for "file already exists", because it's not actually a file, and therefore can't exist as one. (Incidentally, the same challenge arises with the system call _wstat(), which also will return a -1, telling you that the share name doesn't exist.) The solution to this issue, then, is to skip not only the server name, but the share name as well, which is easily done with one more line of code: C:\Users\ecortens\Software\R-devel\src>svn diff Index: main/pl...

Nikola, Your patchset does not work; e>bin\clang.exe -S なかむら\たくみ.c error: error reading '邵コ・ェ邵コ荵昴・郢ァ蝎らクコ貅假ソ・邵コ・ソ.c' 1 error generated. - Would it be not enough in somewhere? I suspect clang still might be pathv1-dependent. (I guess, pathv1 would assume ansi) - raw_ostream does not handle utf8, but ansi, on win32. I would like to propose; - converting utf8 and utf16

...", which fails, setting errno to the code for "Permission denied", > instead of EEXIST, the code for "file already exists", because it's not > actually a file, and therefore can't exist as one. (Incidentally, the same > challenge arises with the system call _wstat(), which also will return a > -1, telling you that the share name doesn't exist.) > > The solution to this issue, then, is to skip not only the server name, but > the share name as well, which is easily done with one more line of code: > > C:\Users\ecortens\Software\R-devel\sr...

The patch should work for unicode filename, I just realized that it doesn't work for unicode directories. FileSystemStatCache calls ::stat for directories, and this doesn't work for utf8 input the same way ::open doesn't work. I tried to replace it with ::_wstat but this function has a different signature. I think we should take a different approach: 1. convert all command line input to utf8 2. rework FileSystemStatCache and MemoryBuffer to use llvm::sys::fs and never explicitly call ::open or ::stat llvm::sys::fs already has a status function but I'...

AFAIK Clang internals do assume utf8, and llvm::sys::path converts strings to utf16 on windows and calls W API functions. If somebody would like to take a look at my changes and comment on them. Here's a brief explanation of what I did: - Convert argv to utf8 using current system locale for win32 (this is done as soon as possible inside ExpandArgv). This makes the driver happy since calls to

On Tue, Dec 6, 2011 at 2:11 AM, Michael Spencer <bigcheesegs at gmail.com> wrote: > On Sun, Dec 4, 2011 at 9:06 AM, Manuel Klimek <klimek at google.com> wrote: >> On Sat, Dec 3, 2011 at 10:33 PM, Douglas Gregor <dgregor at apple.com> wrote: >>> Hi Manuel, >>> >>> On Nov 28, 2011, at 2:49 AM, Manuel Klimek wrote: >>> >>>>