search for: _test_checks

...I noticed that many Python scripts under utils/ have a shebang of `#!/usr/bin/python` (which is a symlink to python2.7 on many platforms) and some of them use Python 2 syntax that is not compatible with Python 3 (e.g. print statements; str/bytes) I created a revision to migrate utils/update_{llc_,}_test_checks.py from Python 2 to Python 3 https://reviews.llvm.org/D42450 , the arguments against making it Python 3 is: * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 pre-installed [0] but not Python 3. * Forcing scripts to use Python 3 (by doing so we can avoid some compatibility tro...

...many Python scripts under utils/ have a shebang of > `#!/usr/bin/python` (which is a symlink to python2.7 on many platforms) and some of them use Python 2 syntax that is not compatible with Python 3 (e.g. print statements; str/bytes) > > I created a revision to migrate utils/update_{llc_,}_test_checks.py from Python 2 to Python 3 https://reviews.llvm.org/D42450 <https://reviews.llvm.org/D42450> , the arguments against making it Python 3 is: > > * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 pre-installed [0] but not Python 3. > * Forcing scripts to use Py...

...many Python scripts under utils/ have a shebang of > `#!/usr/bin/python` (which is a symlink to python2.7 on many platforms) and some of them use Python 2 syntax that is not compatible with Python 3 (e.g. print statements; str/bytes) > > I created a revision to migrate utils/update_{llc_,}_test_checks.py from Python 2 to Python 3 https://reviews.llvm.org/D42450 , the arguments against making it Python 3 is: > > * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 pre-installed [0] but not Python 3. > * Forcing scripts to use Python 3 (by doing so we can avoid some co...

...on scripts under utils/ have a shebang of > `#!/usr/bin/python` (which is a symlink to python2.7 on many platforms) > and some of them use Python 2 syntax that is not compatible with Python 3 > (e.g. print statements; str/bytes) > > I created a revision to migrate utils/update_{llc_,}_test_checks.py from > Python 2 to Python 3 https://reviews.llvm.org/D42450 , the arguments > against making it Python 3 is: > > * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 > pre-installed [0] but not Python 3. > * Forcing scripts to use Python 3 (by doing so we can...

...scripts under utils/ have a shebang of >> `#!/usr/bin/python` (which is a symlink to python2.7 on many platforms) and some of them use Python 2 syntax that is not compatible with Python 3 (e.g. print statements; str/bytes) >> >> I created a revision to migrate utils/update_{llc_,}_test_checks.py from Python 2 to Python 3 https://reviews.llvm.org/D42450 , the arguments against making it Python 3 is: >> >> * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 pre-installed [0] but not Python 3. >> * Forcing scripts to use Python 3 (by doing so we can a...

...; `#!/usr/bin/python` (which is a symlink to python2.7 on many >> platforms) and some of them use Python 2 syntax that is not >> compatible with Python 3 (e.g. print statements; str/bytes) >> >> I created a revision to migrate >> utils/update_{llc_,}_test_checks.py from Python 2 to Python 3 >> https://reviews.llvm.org/D42450 <https://reviews.llvm.org/D42450> >> , the arguments against making it Python 3 is: >> >> * There are many Mac OS X users and Mac OS X 10.8 comes with >> Python 2.7 pre-installed [0]...

...>>> `#!/usr/bin/python` (which is a symlink to python2.7 on many platforms) >>> and some of them use Python 2 syntax that is not compatible with Python 3 >>> (e.g. print statements; str/bytes) >>> >>> I created a revision to migrate utils/update_{llc_,}_test_checks.py from >>> Python 2 to Python 3 https://reviews.llvm.org/D42450 , the arguments against >>> making it Python 3 is: >>> >>> * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 >>> pre-installed [0] but not Python 3. >>> * Fo...

...ls/ have a shebang of >> `#!/usr/bin/python` (which is a symlink to python2.7 on many platforms) >> and some of them use Python 2 syntax that is not compatible with Python 3 >> (e.g. print statements; str/bytes) >> >> I created a revision to migrate utils/update_{llc_,}_test_checks.py from >> Python 2 to Python 3 https://reviews.llvm.org/D42450 , the arguments against >> making it Python 3 is: >> >> * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 >> pre-installed [0] but not Python 3. >> * Forcing scripts to use Pyth...

...ls/ have a shebang of >> `#!/usr/bin/python` (which is a symlink to python2.7 on many platforms) >> and some of them use Python 2 syntax that is not compatible with Python 3 >> (e.g. print statements; str/bytes) >> >> I created a revision to migrate utils/update_{llc_,}_test_checks.py from >> Python 2 to Python 3 https://reviews.llvm.org/D42450 , the arguments against >> making it Python 3 is: >> >> * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 >> pre-installed [0] but not Python 3. >> * Forcing scripts to use Pyth...

...!/usr/bin/python` (which is a symlink to python2.7 on many platforms) >>>> and some of them use Python 2 syntax that is not compatible with Python 3 >>>> (e.g. print statements; str/bytes) >>>> >>>> I created a revision to migrate utils/update_{llc_,}_test_checks.py from >>>> Python 2 to Python 3 https://reviews.llvm.org/D42450 , the arguments against >>>> making it Python 3 is: >>>> >>>> * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 >>>> pre-installed [0] but not Python...

...>>> `#!/usr/bin/python` (which is a symlink to python2.7 on many platforms) >>> and some of them use Python 2 syntax that is not compatible with Python 3 >>> (e.g. print statements; str/bytes) >>> >>> I created a revision to migrate utils/update_{llc_,}_test_checks.py from >>> Python 2 to Python 3 https://reviews.llvm.org/D42450 , the arguments against >>> making it Python 3 is: >>> >>> * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 >>> pre-installed [0] but not Python 3. >>> * Fo...

...n` (which is a symlink to python2.7 on many platforms) >>>>> and some of them use Python 2 syntax that is not compatible with Python 3 >>>>> (e.g. print statements; str/bytes) >>>>> >>>>> I created a revision to migrate utils/update_{llc_,}_test_checks.py from >>>>> Python 2 to Python 3 https://reviews.llvm.org/D42450 , the arguments against >>>>> making it Python 3 is: >>>>> >>>>> * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 >>>>> pre-installed...

...dated. IME, many of our tests check way too much. Codegen tests are particularly egregious in this regard because many are (re-)generated and match whole functions of asm. One of the major problems with using FileCheck regexps in generated tests is that it's very difficult to take an update_*_test_checks.py output and whittle it down because the FileCheck regexps define and use variables which need to be massaged while altering the test. I have some patches that help alleviate this. > This problem goes away if the test method by default ignored value > names/MDNode numbers and software deve...

...n/python` (which is a symlink to python2.7 on many platforms) > >>> and some of them use Python 2 syntax that is not compatible with > Python 3 > >>> (e.g. print statements; str/bytes) > >>> > >>> I created a revision to migrate utils/update_{llc_,}_test_checks.py > from > >>> Python 2 to Python 3 https://reviews.llvm.org/D42450 , the arguments > against > >>> making it Python 3 is: > >>> > >>> * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 > >>> pre-installed [0] b...

...n/python` (which is a symlink to python2.7 on many platforms) > >>> and some of them use Python 2 syntax that is not compatible with > Python 3 > >>> (e.g. print statements; str/bytes) > >>> > >>> I created a revision to migrate utils/update_{llc_,}_test_checks.py > from > >>> Python 2 to Python 3 https://reviews.llvm.org/D42450 , the arguments > against > >>> making it Python 3 is: > >>> > >>> * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 > >>> pre-installed [0] b...

...sr/bin/python` (which is a symlink to python2.7 on many platforms) > >>> and some of them use Python 2 syntax that is not compatible with Python 3 > >>> (e.g. print statements; str/bytes) > >>> > >>> I created a revision to migrate utils/update_{llc_,}_test_checks.py from > >>> Python 2 to Python 3 https://reviews.llvm.org/D42450 <https://reviews.llvm.org/D42450> , the arguments against > >>> making it Python 3 is: > >>> > >>> * There are many Mac OS X users and Mac OS X 10.8 comes with Python 2.7 > &g...

The test as written is fragile because it requires a certain ordering. If the output order is not important, use CHECK-DAG rather than CHECK. This would be a failure to understand the testing tool. My experience, over a 40-year career, is that good software developers are generally not very good test-writers. These are different skills and good testing is frequently not taught. It’s easy to