search for: _remove

...e that we call put_device() if a call to > > register_virtio_device() fails. > > OK, that was the subtility I obviously missed. Reading through the > code, this seems correct (although I find the infrastructure a bit > unintuitive). No worries. > Shouldn't the cleanup in _remove() then be removed as well? Ah, I'd missed that. I believe that can be removed, yes. Should I spin a v2 with that folded in? Thanks, Mark.

...e that we call put_device() if a call to > > register_virtio_device() fails. > > OK, that was the subtility I obviously missed. Reading through the > code, this seems correct (although I find the infrastructure a bit > unintuitive). No worries. > Shouldn't the cleanup in _remove() then be removed as well? Ah, I'd missed that. I believe that can be removed, yes. Should I spin a v2 with that folded in? Thanks, Mark.

...There's a bunch of options: > > - nouveau somehow manages to keep the crtc on without a framebuffer > > - nouveau somehow leaks a drm_framebuffer, but removes it from the fb_list > > - something else > > Found it. nouveau_fbcon_destroy() doesn't call drm_framebuffer_remove(). > If I add that, the crtc gets properly disabled on unload. > > It does call drm_framebuffer_cleanup(). That's why there was no WARN, > drm_mode_config_cleanup() only WARNs if a framebuffer was left on the > mode_config.fb_list. > > radeon and amdgpu have the same prob...

...d on Airplane? And instead of just passing in a list of objects that only specify the id of the associated object to update the list, shouldn''t the client (since they are providing a patch) be able to only specify which members are be deleted? Possibly support could be added for a new _remove key on the object to be removed from a list? That would seem to be a good name. That way you could either use the existing _destroy key that allows you to destroy the associated object or could use the new _remove key to just indicate that in your patch request you are specifying to remove it f...

...t; - nouveau somehow manages to keep the crtc on without a framebuffer > > > > - nouveau somehow leaks a drm_framebuffer, but removes it from the fb_list > > > > - something else > > > > > > Found it. nouveau_fbcon_destroy() doesn't call drm_framebuffer_remove(). > > > If I add that, the crtc gets properly disabled on unload. > > > > > > It does call drm_framebuffer_cleanup(). That's why there was no WARN, > > > drm_mode_config_cleanup() only WARNs if a framebuffer was left on the > > > mode_config.fb_lis...

Recent rework of the virtio_mmio probe path balanced a devm_ioremap() with an iounmap() rather than its devm variant. This ends up corrupting the devm datastructures, and results in the following boot failure on arm64 under QEMU 2.9.0: [ 3.450397] ------------[ cut here ]------------ [ 3.453822] Trying to vfree() nonexistent vm area (00000000c05b4844) [ 3.460534] WARNING: CPU: 1 PID: 1

Recent rework of the virtio_mmio probe path balanced a devm_ioremap() with an iounmap() rather than its devm variant. This ends up corrupting the devm datastructures, and results in the following boot failure on arm64 under QEMU 2.9.0: [ 3.450397] ------------[ cut here ]------------ [ 3.453822] Trying to vfree() nonexistent vm area (00000000c05b4844) [ 3.460534] WARNING: CPU: 1 PID: 1

On Tue, 12 Dec 2017 13:29:02 +0000 Mark Rutland <mark.rutland at arm.com> wrote: > On Tue, Dec 12, 2017 at 02:09:52PM +0100, Cornelia Huck wrote: > > Shouldn't the cleanup in _remove() then be removed as well? > > Ah, I'd missed that. > > I believe that can be removed, yes. > > Should I spin a v2 with that folded in? I think it has the same devm_ioremap vs. iounmap discrepancy, so it should probably be folded in.

...\ \ + /* Remove i'th element. i=0 => beginning i=size-1 => end */ \ + static inline int \ + name##_remove (name *v, size_t i) \ + { \ + if (i >= v->size) return -1; \ + memmove (&v->ptr[i], &v->ptr[i+1], (v->size-i) * sizeof (type))...

...r more of the associated pictures from the person using nested forms as suggested by Ryan Bates. However delete will delete the picture not remove the associatioon I can do it in the controller, but it should be done in the same way as delete is performed using attribute _delete Anyone knowing if a _remove attribute is implemented or know any other way to solve the problem (e.g. that could be a command allow_remove=true) Another problem is that it seems as nested forms do not validate the attributes of the associated object in this case picture. I have solved the problem by a fix in the controller,...

...ptions: > > > - nouveau somehow manages to keep the crtc on without a framebuffer > > > - nouveau somehow leaks a drm_framebuffer, but removes it from the fb_list > > > - something else > > > > Found it. nouveau_fbcon_destroy() doesn't call drm_framebuffer_remove(). > > If I add that, the crtc gets properly disabled on unload. > > > > It does call drm_framebuffer_cleanup(). That's why there was no WARN, > > drm_mode_config_cleanup() only WARNs if a framebuffer was left on the > > mode_config.fb_list. > > > > r...

...ackages with `.hpp` files in CRAN. Hopefully you can provide some clarification as to the reasoning of current stance on this as the documentation doesn't provide any direction. Research indicates that the footnote may no longer reflect the current state of R or CRAN and that it may be time to _remove the statement from the documentation rather than punting and editing to reflect `c++11`_. Knowing that the time to manage the upcoming release schedule and the changes to CRAN is more than likely keeping you to busy to research a seemingly insignificant edge case I apologize for the length of this...

...turn rc; > -unmap: > - iounmap(vm_dev->base); > -free_mem: > - devm_release_mem_region(&pdev->dev, mem->start, > - resource_size(mem)); > -free_vmdev: > - devm_kfree(&pdev->dev, vm_dev); > + > return rc; > } > Shouldn't the cleanup in _remove() then be removed as well?

...ing yet, but I'm done for today and wanted to at least document my ideas). I might also add a convenience function for nbdkit_extents_offset, since we have a number of filters that repeat the same code for translating all extents from the plugin by an offset. Eric Blake (3): vector: Add VECT_remove extents: Add nbdkit_extents_aligned() RFC swab: Re-enable .extents docs/nbdkit-filter.pod | 18 +++++++++ include/nbdkit-filter.h | 5 +++ common/utils/vector.h | 10 +++++ server/extents.c | 80 +++++++++++++++++++++++++++++++++++++- server/nbdkit.syms | 1 +...

On Wed, May 25, 2016 at 12:51 PM, Lukas Wunner <lukas at wunner.de> wrote: > > On Tue, May 24, 2016 at 11:30:42PM +0200, Daniel Vetter wrote: >> On Tue, May 24, 2016 at 06:03:27PM +0200, Lukas Wunner wrote: >> > When a drm_crtc structure is destroyed with drm_crtc_cleanup(), the DRM >> > core does not turn off the crtc first and neither do the drivers. With

...\ + \ + /* Remove i'th element. i=0 => beginning i=size-1 => end */ \ + static inline void \ + name##_remove (name *v, size_t i) \ + { \ + assert (i < v->size); \ + memmove (&v->ptr[i], &v->ptr[i+1], (v->size-i) * sizeof (type))...

...<label>_Edit</label> <help>Edit an existing contact in your Contact list...</help> </object> <object class="wxMenuItem" name="claoRemove"> <label>_Remove</label> <help>Remove an Existing contact....</help> </object> </object> <object class="separator"/> <object class="wxMenuItem" name="claShowOff...

Complete migration of nouveau_event_get/_put from add/remove semantics to enable/disable semantics. Introduce nouveau_event_handler_install/_remove interface to add/remove non-local-scope event handlers (ie., those stored in parent containers). This change in semantics makes explicit the handler lifetime, and distinguishes "one-of" event handlers (such as gpio) from "many temporary" event handlers (such as uevent). Signed-...

...vdev->dev; - index++; + vblk->index = index; /* configure queue flush support */ if (virtio_has_feature(vdev, VIRTIO_BLK_F_FLUSH)) @@ -516,6 +535,10 @@ out_free_vq: vdev->config->del_vqs(vdev); out_free_vblk: kfree(vblk); +out_free_index: + spin_lock(&vd_index_lock); + ida_remove(&vd_index_ida, index); + spin_unlock(&vd_index_lock); out: return err; } @@ -529,6 +552,10 @@ static void __devexit virtblk_remove(struct virtio_device *vdev) /* Nothing should be pending. */ BUG_ON(!list_empty(&vblk->reqs)); + spin_lock(&vd_index_lock); + ida_remove(&a...

...vdev->dev; - index++; + vblk->index = index; /* configure queue flush support */ if (virtio_has_feature(vdev, VIRTIO_BLK_F_FLUSH)) @@ -516,6 +535,10 @@ out_free_vq: vdev->config->del_vqs(vdev); out_free_vblk: kfree(vblk); +out_free_index: + spin_lock(&vd_index_lock); + ida_remove(&vd_index_ida, index); + spin_unlock(&vd_index_lock); out: return err; } @@ -529,6 +552,10 @@ static void __devexit virtblk_remove(struct virtio_device *vdev) /* Nothing should be pending. */ BUG_ON(!list_empty(&vblk->reqs)); + spin_lock(&vd_index_lock); + ida_remove(&a...