search for: _put

...and amdgpu. Alex > Note: I've included r-b, a-b tags, as these patches are identical to v1 > except for the file: drivers/gpu/drm/i915/i915_gem_object.h > > This patch set replaces the occurrences of drm_*_reference() and > drm_*_unreference() with the new drm_*_get() and drm_*_put() > functions. > All patches in the series do the same thing, converting to the new APIs. > I created patches per DRM driver as suggested by Daniel Vetter. > > This patch set was generated by scripts/coccinelle/api/drm-get-put.cocci > > Previous thread can be reached at: >...

Most nouveau event handlers have storage in 'static' containers (structures with lifetimes nearly equivalent to the drm_device), but are dangerously reused via nouveau_event_get/_put. For example, if nouveau_event_get is called more than once for a given handler, the event handler list will be corrupted. Migrate nouveau_event_get/_put from add/remove semantics to enable/disable semantics. Signed-off-by: Peter Hurley <peter at hurleysoftware.com> --- drivers/gpu/drm/nou...

...of buffer full. I changed that behaviour exactly because > of burst issues and the like. Other than that, I don't think there > should be any other possible race (assuming CPU cache coherence). Weeeeelll.. Actually, now that you mention it, the histogram shifting is a race as well. In _put, the lines jitter->shortterm_margin[i] *= .98; jitter->longterm_margin[i] *= .995; jitter->shortterm_margin[int_margin] += .02; jitter->longterm_margin[int_margin] += .005; are read-accumulate-write operations. Let's assume the +40 bin has...

From: Fengguang Wu <fengguang.wu at intel.com> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and drm_*_unreference() helpers. Generated by: scripts/coccinelle/api/drm-get-put.cocci Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> --- tree: https://github.com/thierryreding/li...

> Err, unless I'm totally wrong, there are a few race conditions. > > Assume the buffer is full of packets newer than the current pointer, and > one that is at the current pointer. > > get and put start at the same time. > > get will find the correct buffer index. Now, just after it finds it's > index, assume we switch to the put thread. > > Put needs

Hi, I see you're changing the jitter buffer around quite a bit. Could you let us know when it's ready for general testing? (At the moment it doesn't handle missing packets at all) Best wishes, Thorvald

...RCU conversion include: 1) ensuring the > object lifetime exceeds the lockless access; 2) preventing > premature object reuse; and 3) verifying that stale object > use not present logical errors. > > Because object reuse is not safe in RCU-based operations, > the nouveau_event_get/_put interface is migrated from > add/remove semantics to enable/disable semantics with a separate > install/remove step (which also serves to document the > handler lifetime). This also corrects an unsafe interface design > where handlers can mistakenly be reused while in use. > > The...

This patch set replaces the occurrences of drm_*_reference() and drm_*_unreference() with the new drm_*_get() and drm_*_put() functions. All patches in the series do the same thing, converting to the new APIs. I created patches per DRM driver as suggested by Daniel Vetter. Background: In the kernel, reference counting APIs use *_get(), *_put() style naming to reference-count the objects. But DRM subsystem uses a diffe...

I am experimenting with a combined form. I wish to force the HTTP verb for this form to PUT. However, it always uses POST when submitted and I cannot determine why. The view template code is: <%=form_for( @user, :html => { :class => :edit_user_role, :id => :edit_user_role_form, :method => :put }, :url => user_roles_url( @user ) )

On Mon, Jan 15, 2018 at 01:47:07PM +0100, Julia Lawall wrote: > From: Fengguang Wu <fengguang.wu at intel.com> > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > drm_*_unreference() helpers. > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > Signed-off-by: Fengguang Wu <fengguang.wu at intel.com> > Signed-off-by: Julia Lawall <julia.lawall at lip6.fr> > --- > &gt...

From: kbuild test robot <fengguang.wu at intel.com> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and drm_*_unreference() helpers. Generated by: scripts/coccinelle/api/drm-get-put.cocci Fixes: 30ed49b55b6e ("drm/nouveau/kms/nv50-: move code underneath dispnv50/") Signed-off-by: kbuild test robot <fengguang.wu at intel.com> Signed-off-by:...

...ut.cocci b/scripts/coccinelle/api/drm-get-put.cocci > deleted file mode 100644 > index 3a09c97ad87d..000000000000 > --- a/scripts/coccinelle/api/drm-get-put.cocci > +++ /dev/null > @@ -1,78 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0 > -/// > -/// Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > -/// drm_*_unreference() helpers. > -/// > -// Confidence: High > -// Copyright: (C) 2017 NVIDIA Corporation > -// Options: --no-includes --include-headers > -// > - > -virtual patch > -virtual report > - > - at depends o...

...e current version was working. Can you tell me what happens exactly (without output if possible) so I can fix it? Also, I'd be very interesting in getting test "data" for the jitter buffer. By that I mean, just a log of how you are calling it. More specifically: - Every time you call _put(), print the timestamp and span of the packet - Every time you call _get(), print the desired_span argument (it's a new argument) - Every time you call _tick(), with no argument. For example, the file could look like: PUT 1000 100 GET 100 TICK PUT 1100 100 GET 100 TICK ... That would help me...

...rking. Can you tell me what happens exactly (without output if > possible) so I can fix it? Also, I'd be very interesting in getting test > "data" for the jitter buffer. By that I mean, just a log of how you are > calling it. More specifically: > > - Every time you call _put(), print the timestamp and span of the packet > - Every time you call _get(), print the desired_span argument (it's a > new argument) > - Every time you call _tick(), with no argument. > > For example, the file could look like: > > PUT 1000 100 > GET 100 > TICK > P...

...version. Typical hurdles to RCU conversion include: 1) ensuring the object lifetime exceeds the lockless access; 2) preventing premature object reuse; and 3) verifying that stale object use not present logical errors. Because object reuse is not safe in RCU-based operations, the nouveau_event_get/_put interface is migrated from add/remove semantics to enable/disable semantics with a separate install/remove step (which also serves to document the handler lifetime). This also corrects an unsafe interface design where handlers can mistakenly be reused while in use. The nouveau driver currently sup...

drm_*_reference() and drm_*_unreference() functions are just compatibility alias for drm_*_get() and drm_*_put() adn should not be used by new code. So convert all users of compatibility functions to use the new APIs. Signed-off-by: Cihangir Akturk <cakturk at gmail.com> --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 2 +- drivers/gpu/drm/nouveau/nouveau_abi16.c | 2 +- drivers/gpu/drm/nouveau/...

Looks good to me! Reviewed-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de> On 8/3/17 1:58 PM, Cihangir Akturk wrote: > drm_*_reference() and drm_*_unreference() functions are just > compatibility alias for drm_*_get() and drm_*_put() adn should not be > used by new code. So convert all users of compatibility functions to use > the new APIs. > > Signed-off-by: Cihangir Akturk <cakturk at gmail.com> > --- > drivers/gpu/drm/nouveau/dispnv04/crtc.c | 2 +- > drivers/gpu/drm/nouveau/nouveau_abi16.c...

Complete migration of nouveau_event_get/_put from add/remove semantics to enable/disable semantics. Introduce nouveau_event_handler_install/_remove interface to add/remove non-local-scope event handlers (ie., those stored in parent containers). This change in semantics makes explicit the handler lifetime, and distinguishes "one-of"...

...duplicating the elf loading code in each device driver a slim rproc driver has been created. This driver is designed to be used by other device drivers such as fdma, or demux whose IP is based around a slim core. The device driver can call slim_rproc_alloc() to allocate a slim rproc and slim_rproc_put() when finished. This driver takes care of ioremapping the slim registers (dmem, imem, slimcore, peripherals), whose offsets and sizes can change between IP's. It also obtains and enables any clocks used by the device. This approach avoids having a double mapping of the registers as slim_rproc...

...ode in each device driver a slim > rproc driver has been created. > > This driver is designed to be used by other device drivers > such as fdma, or demux whose IP is based around a slim core. > The device driver can call slim_rproc_alloc() to allocate > a slim rproc and slim_rproc_put() when finished. > > This driver takes care of ioremapping the slim > registers (dmem, imem, slimcore, peripherals), whose offsets > and sizes can change between IP's. It also obtains and enables > any clocks used by the device. This approach avoids having > a double mapping...