search for: _prepare

...patch, you have > added a new flag: VRING_AVAIL_F_NO_URGENT_INTERRUPT > I don't think it's necessary, see below. > > As such, I think this patch should be split: > - original patch adding support for urgent descriptors > - a patch adding virtqueue_enable/disable_cb_urgent(_prepare)? Not sure this is a good idea, since the api of first patch is in-completed. > >> --- >> drivers/virtio/virtio_ring.c | 75 +++++++++++++++++++++++++++++++++++++--- >> include/linux/virtio.h | 14 ++++++++ >> include/uapi/linux/virtio_ring.h | 5 ++- >...

...patch, you have > added a new flag: VRING_AVAIL_F_NO_URGENT_INTERRUPT > I don't think it's necessary, see below. > > As such, I think this patch should be split: > - original patch adding support for urgent descriptors > - a patch adding virtqueue_enable/disable_cb_urgent(_prepare)? Not sure this is a good idea, since the api of first patch is in-completed. > >> --- >> drivers/virtio/virtio_ring.c | 75 +++++++++++++++++++++++++++++++++++++--- >> include/linux/virtio.h | 14 ++++++++ >> include/uapi/linux/virtio_ring.h | 5 ++- >...

...at as compared to my original patch, you have added a new flag: VRING_AVAIL_F_NO_URGENT_INTERRUPT I don't think it's necessary, see below. As such, I think this patch should be split: - original patch adding support for urgent descriptors - a patch adding virtqueue_enable/disable_cb_urgent(_prepare)? > --- > drivers/virtio/virtio_ring.c | 75 +++++++++++++++++++++++++++++++++++++--- > include/linux/virtio.h | 14 ++++++++ > include/uapi/linux/virtio_ring.h | 5 ++- > 3 files changed, 89 insertions(+), 5 deletions(-) > > diff --git a/drivers/virtio/vir...

...ficially, by adding udelay() in virtqueue_enable_cb() after virtio_mb(). However, we must call napi_complete to clear NAPI_STATE_SCHED before polling the virtqueue for used buffers, otherwise napi_schedule_prep in a callback will fail, causing us to lose RX events. To fix, call virtqueue_enable_cb_prepare with NAPI_STATE_SCHED set (under napi lock), later call virtqueue_poll with NAPI_STATE_SCHED clear (outside the lock). Reported-by: Jason Wang <jasowang at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 inserti...

...ficially, by adding udelay() in virtqueue_enable_cb() after virtio_mb(). However, we must call napi_complete to clear NAPI_STATE_SCHED before polling the virtqueue for used buffers, otherwise napi_schedule_prep in a callback will fail, causing us to lose RX events. To fix, call virtqueue_enable_cb_prepare with NAPI_STATE_SCHED set (under napi lock), later call virtqueue_poll with NAPI_STATE_SCHED clear (outside the lock). Reported-by: Jason Wang <jasowang at redhat.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 inserti...

...EXPORT_SYMBOL_GPL(virtqueue_disable_cb); +void virtqueue_disable_cb_urgent(struct virtqueue *_vq) +{ + struct vring_virtqueue *vq = to_vvq(_vq); + + vq->vring.avail->flags |= VRING_AVAIL_F_NO_URGENT_INTERRUPT; +} +EXPORT_SYMBOL_GPL(virtqueue_disable_cb_urgent); + /** * virtqueue_enable_cb_prepare - restart callbacks after disable_cb * @vq: the struct virtqueue we're talking about. @@ -626,6 +672,19 @@ unsigned virtqueue_enable_cb_prepare(struct virtqueue *_vq) } EXPORT_SYMBOL_GPL(virtqueue_enable_cb_prepare); +unsigned virtqueue_enable_cb_prepare_urgent(struct virtqueue *_vq) +{ +...

...EXPORT_SYMBOL_GPL(virtqueue_disable_cb); +void virtqueue_disable_cb_urgent(struct virtqueue *_vq) +{ + struct vring_virtqueue *vq = to_vvq(_vq); + + vq->vring.avail->flags |= VRING_AVAIL_F_NO_URGENT_INTERRUPT; +} +EXPORT_SYMBOL_GPL(virtqueue_disable_cb_urgent); + /** * virtqueue_enable_cb_prepare - restart callbacks after disable_cb * @vq: the struct virtqueue we're talking about. @@ -626,6 +672,19 @@ unsigned virtqueue_enable_cb_prepare(struct virtqueue *_vq) } EXPORT_SYMBOL_GPL(virtqueue_enable_cb_prepare); +unsigned virtqueue_enable_cb_prepare_urgent(struct virtqueue *_vq) +{ +...

...display output source from via_lvds_mode_set Version bumped to 0.5.123 Added viaDVP1SetDisplaySource Added viaDVP0SetDisplaySource LVDS FP and VT1632 are now deciding display output source Version bumped to 0.5.124 Not setting display output source inside via_lvds_prepare Version bumped to 0.5.125 Added viaDFPHighSetDelayTap Added viaDFPHighSetDisplaySource Added viaLVDS2SetDithering Set LVDS2 output color dithering from via_lvds_mode_set Version bumped to 0.5.126 Updated VIA Technologies defined flat panel screen resolution...

Hello all: We free old transmitted packets in ndo_start_xmit() currently, so any packet must be orphaned also there. This was used to reduce the overhead of tx interrupt to achieve better performance. But this may not work for some protocols such as TCP stream. TCP depends on the value of sk_wmem_alloc to implement various optimization for small packets stream such as TCP small queue and auto

Hello all: We free old transmitted packets in ndo_start_xmit() currently, so any packet must be orphaned also there. This was used to reduce the overhead of tx interrupt to achieve better performance. But this may not work for some protocols such as TCP stream. TCP depends on the value of sk_wmem_alloc to implement various optimization for small packets stream such as TCP small queue and auto