search for: _parse_file

...llvm-gcc4.2-objects/ gcc/../../llvm-gcc4.2-2.4.source/gcc/gengtype.c:725: more undefined references to `_lexer_line' follow build/gengtype.o: In function `main': /cygdrive/r/android/llvm/llvm-gcc4.2-objects/gcc/../../llvm- gcc4.2-2.4.source/gcc/gengtype.c:3070: undefined reference to `_parse_file' /cygdrive/r/android/llvm/llvm-gcc4.2-objects/gcc/../../llvm- gcc4.2-2.4.source/gcc/gengtype.c:3070: undefined reference to `_parse_file' build/gengtype-yacc.o: In function `yyparse': /cygdrive/r/android/llvm/llvm-gcc4.2-objects/gcc/../../llvm- gcc4.2-2.4.source/gcc/gengtype-yacc.y:...

...; gcc/../../llvm-gcc4.2-2.4.source/gcc/gengtype.c:725: more undefined > references to `_lexer_line' follow > build/gengtype.o: In function `main': > /cygdrive/r/android/llvm/llvm-gcc4.2-objects/gcc/../../llvm- > gcc4.2-2.4.source/gcc/gengtype.c:3070: undefined reference to > `_parse_file' > /cygdrive/r/android/llvm/llvm-gcc4.2-objects/gcc/../../llvm- > gcc4.2-2.4.source/gcc/gengtype.c:3070: undefined reference to > `_parse_file' > build/gengtype-yacc.o: In function `yyparse': > /cygdrive/r/android/llvm/llvm-gcc4.2-objects/gcc/../../llvm- > gcc4.2-2.4.s...

.../../../llvm-gcc4.2-2.4.source/gcc/gengtype.c:725: more undefined > references to `_lexer_line' follow > build/gengtype.o: In function `main': > /cygdrive/r/android/llvm/llvm-gcc4.2-objects/gcc/../../llvm- > gcc4.2-2.4.source/gcc/gengtype.c:3070: undefined reference to > `_parse_file' > /cygdrive/r/android/llvm/llvm-gcc4.2-objects/gcc/../../llvm- > gcc4.2-2.4.source/gcc/gengtype.c:3070: undefined reference to > `_parse_file' > build/gengtype-yacc.o: In function `yyparse': > /cygdrive/r/android/llvm/llvm-gcc4.2-objects/gcc/../../llvm- > gcc4.2-2...

This is just the utilities part of the patch series from: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html I believe this addresses everything raised in comments on that patch series. Rich.

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -

This is a combination of: https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html [PATCH 00/12] Refactor utility functions. plus: https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html [PATCH v3 00/19] Allow APIs to be implemented in OCaml. with the second patches rebased on top of the utility refactoring, and some other adjustments and extensions. This passes

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid