search for: _option

Rename <purpose>_OPTION to OPT_<purpose> for two reasons: - it is more idiomatic for enum constants to have the same prefix than for them to have the same suffix, - we hew away three characters (length-wise) from each option name, which happens to reduce the max width of "copy/main.c" to 79 character...

On Fri, Apr 14, 2023 at 09:59:53AM +0200, Laszlo Ersek wrote: > Two of the enum constants that denote command line options are > inconsistently named with the rest: all identifiers should be > <purpose>_OPTION, but LONG_OPTIONS and SHORT_OPTIONS (which are supposed > to list the long and short options) don't conform. Rename them. > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2172516 > Signed-off-by: Laszlo Ersek <lersek at redhat.com> > --- > copy/main.c | 12 +++...

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2172516 I figured I'd work on the libnbd line wrapping in shorter waves than how long the nbdkit patch series was. Laszlo Laszlo Ersek (4): copy: rename (LONG|SHORT)_OPTIONS to (LONG|SHORT)_OPTIONS_OPTION copy: rename <purpose>_OPTION to OPT_<purpose> copy: fix layout of "long_options" table copy: rewrap error message about stuck NBD server copy/main.c | 76 ++++++++++---------- copy/nbd-ops.c | 5 +- 2 files changed, 42 insertions(+)...

On 4/14/23 10:11, Richard W.M. Jones wrote: > On Fri, Apr 14, 2023 at 09:59:53AM +0200, Laszlo Ersek wrote: >> Two of the enum constants that denote command line options are >> inconsistently named with the rest: all identifiers should be >> <purpose>_OPTION, but LONG_OPTIONS and SHORT_OPTIONS (which are supposed >> to list the long and short options) don't conform. Rename them. >> >> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2172516 >> Signed-off-by: Laszlo Ersek <lersek at redhat.com> >> --- >&gt...

Two of the enum constants that denote command line options are inconsistently named with the rest: all identifiers should be <purpose>_OPTION, but LONG_OPTIONS and SHORT_OPTIONS (which are supposed to list the long and short options) don't conform. Rename them. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2172516 Signed-off-by: Laszlo Ersek <lersek at redhat.com> --- copy/main.c | 12 ++++++------ 1 file changed, 6 i...

...; > > > > >> > > > > > > > > > 0-glusterfsd-mgmt: disconnected from remote-host: localhost >> > > > > > > > > > >> > > > > > > > > > \[2018-02-13 08:16:13.943827\] I \[afr.c:94:fix\_quorum\_options\] >> > > > > > > > > > >> > > > > > > > > > 0-myvolume-replicate-0: reindeer: incoming qtype = none >> > > > > > > > > > >> > > > > > > > > > \[2018-02-13 08:16:13.94...

...; > > > > > > > > > > > > > > > > 0-glusterfsd-mgmt: disconnected from remote-host: localhost > > > > > > > > > > > > > > > > > > > > \[2018-02-13 08:16:13.943827\] I \[afr.c:94:fix\_quorum\_options\] > > > > > > > > > > > > > > > > > > > > 0-myvolume-replicate-0: reindeer: incoming qtype = none > > > > > > > > > > > > > > > > > > > > \[2018-02-13 08:16:13.943857\] I \[afr...

...; > > > > > > > > > > > > 0-glusterfsd-mgmt: disconnected from remote-host: localhost > > > > > > > > > > > > > > > > > > > > > > > > \[2018-02-13 08:16:13.943827\] I \[afr.c:94:fix\_quorum\_options\] > > > > > > > > > > > > > > > > > > > > > > > > 0-myvolume-replicate-0: reindeer: incoming qtype = none > > > > > > > > > > > > > > > > > > > > > > > &gt...

...ocket >>>>>>>>> [2018-02-13 08:16:09.940519] I [glusterfsd-mgmt.c:2134:mgmt_rpc_notify] >>>>>>>>> 0-glusterfsd-mgmt: disconnected from remote-host: localhost >>>>>>>>> [2018-02-13 08:16:13.943827] I [afr.c:94:fix_quorum_options] >>>>>>>>> 0-myvolume-replicate-0: reindeer: incoming qtype = none >>>>>>>>> [2018-02-13 08:16:13.943857] I [afr.c:116:fix_quorum_options] >>>>>>>>> 0-myvolume-replicate-0: reindeer: quorum_count = 2147483647 >>...