search for: _oge_use_projection

Hi Drew, Some comments on the libopusenc patch: + int _oge_use_projection(int channel_mapping); These functions are part of libopusenc, so I'd expect them to have an ope prefix like the other functions in the libopusenc library. + if (_oge_use_projection(h->channel_mapping)) + { + len=27+(h->channels*(h->nb_streams+h->nb_coupled)*2); + } + else...

Hi Drew, I think the libopusenc patch is better, but there's still a few issues left: 1) The static MAX_PACKET_BUFFER_SIZE value is still problematic because if you link libopusenc with a new version of libopus that supports higher order projection or just more projection channels for order 3, then you will overflow the buffer. I think what you'd want is a _ope_opus_header_get_size() call

Just to confirm, I would use opeint_* for all the OpusGenericEncoder-related functions? On Tue, Mar 20, 2018 at 8:38 AM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > Hi Mark, Drew, > > On 03/20/2018 02:40 AM, Mark Harris wrote: > > + int _oge_use_projection(int channel_mapping); > > > > These functions are part of libopusenc, so I'd expect them to have an > > ope prefix like the other functions in the libopusenc library. > > I'd like to avoid using the ope_ prefix for functions that's aren't in > the public A...

...h an underscore. > > > > On Tue, Mar 20, 2018 at 8:38 AM Jean-Marc Valin <jmvalin at jmvalin.ca > > <mailto:jmvalin at jmvalin.ca>> wrote: > > > > Hi Mark, Drew, > > > > On 03/20/2018 02:40 AM, Mark Harris wrote: > > > + int _oge_use_projection(int channel_mapping); > > > > > > These functions are part of libopusenc, so I'd expect them to have > an > > > ope prefix like the other functions in the libopusenc library. > > > > I'd like to avoid using the ope_ prefix for functi...

...n at jmvalin.ca> > > > <mailto:jmvalin at jmvalin.ca <mailto:jmvalin at jmvalin.ca>>> wrote: > > > > > > Hi Mark, Drew, > > > > > > On 03/20/2018 02:40 AM, Mark Harris wrote: > > > > + int _oge_use_projection(int channel_mapping); > > > > > > > > These functions are part of libopusenc, so I'd expect them > > to have an > > > > ope prefix like the other functions in the libopusenc > library. > > > > > >...

...lt;mailto:jmvalin at jmvalin.ca <mailto:jmvalin at jmvalin.ca>>> wrote: >>> > > >>> > > Hi Mark, Drew, >>> > > >>> > > On 03/20/2018 02:40 AM, Mark Harris wrote: >>> > > > + int _oge_use_projection(int channel_mapping); >>> > > > >>> > > > These functions are part of libopusenc, so I'd expect them >>> > to have an >>> > > > ope prefix like the other functions in the libopusenc >>> librar...

Hi Mark, Drew, On 03/20/2018 02:40 AM, Mark Harris wrote: > + int _oge_use_projection(int channel_mapping); > > These functions are part of libopusenc, so I'd expect them to have an > ope prefix like the other functions in the libopusenc library. I'd like to avoid using the ope_ prefix for functions that's aren't in the public API. Right now there are othe...

...t don't use something that starts with an underscore. > On Tue, Mar 20, 2018 at 8:38 AM Jean-Marc Valin <jmvalin at jmvalin.ca > <mailto:jmvalin at jmvalin.ca>> wrote: > > Hi Mark, Drew, > > On 03/20/2018 02:40 AM, Mark Harris wrote: > > + int _oge_use_projection(int channel_mapping); > > > > These functions are part of libopusenc, so I'd expect them to have an > > ope prefix like the other functions in the libopusenc library. > > I'd like to avoid using the ope_ prefix for functions that's aren't in...

...t jmvalin.ca <mailto:jmvalin at jmvalin.ca> > > <mailto:jmvalin at jmvalin.ca <mailto:jmvalin at jmvalin.ca>>> wrote: > > > >     Hi Mark, Drew, > > > >     On 03/20/2018 02:40 AM, Mark Harris wrote: > >     > + int _oge_use_projection(int channel_mapping); > >     > > >     > These functions are part of libopusenc, so I'd expect them > to have an > >     > ope prefix like the other functions in the libopusenc library. > > > >     I'd like to avoid using th...

...> > > <mailto:jmvalin at jmvalin.ca <mailto:jmvalin at jmvalin.ca>>> wrote: >> > > >> > > Hi Mark, Drew, >> > > >> > > On 03/20/2018 02:40 AM, Mark Harris wrote: >> > > > + int _oge_use_projection(int channel_mapping); >> > > > >> > > > These functions are part of libopusenc, so I'd expect them >> > to have an >> > > > ope prefix like the other functions in the libopusenc >> library. >> >...

...te: >>>>>>> > > >>>>>>> > > Hi Mark, Drew, >>>>>>> > > >>>>>>> > > On 03/20/2018 02:40 AM, Mark Harris wrote: >>>>>>> > > > + int _oge_use_projection(int channel_mapping); >>>>>>> > > > >>>>>>> > > > These functions are part of libopusenc, so I'd expect >>>>>>> them >>>>>>> > to have an >>>>>>> &gt...