Displaying 2 results from an estimated 2 matches for "_oge_create".
2018 Mar 19
3
[PATCH] Support for Ambisonics
Hi Drew,
I think the libopusenc patch is better, but there's still a few issues left:
1) The static MAX_PACKET_BUFFER_SIZE value is still problematic because
if you link libopusenc with a new version of libopus that supports
higher order projection or just more projection channels for order 3,
then you will overflow the buffer. I think what you'd want is a
_ope_opus_header_get_size() call
2018 Mar 20
2
[PATCH] Support for Ambisonics
...t from the OggOpusEnc structure, this structure or
its two pointer fields could simply be added to OggOpusEnc. This
would also avoid an unnecessary level of indirection in every place
where the encoder is used.
+ st->family=0;
The family field in this structure is set to the wrong family in
_oge_create(). However the real family is in the OggOpusEnc
structure; the family field in this structure is not actually used
except to compare the value to 253 to determine whether to use the
"ms" or "pr" pointer. It would be simpler to omit the incorrectly-set
family field and just che...