search for: _minimum_

Just an attempt to avoid overflows with an explicit check, I don't know if there's a better way to identify corrupt input here. James Zern (2): op_pcm_seek: fix int64 overflow op_fetch_and_process_page: fix int64 overflow src/opusfile.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) -- 2.15.0.448.gf294e3d99a-goog

On Tue, Nov 28, 2017 at 3:22 PM, James Zern <jzern at google.com> wrote: > On Mon, Nov 20, 2017 at 1:07 PM, James Zern <jzern at google.com> wrote: >> Just an attempt to avoid overflows with an explicit check, I don't know if >> there's a better way to identify corrupt input here. >> >> James Zern (2): >> op_pcm_seek: fix int64 overflow

What kind of connection delays are people seeing with Ossh 2.2.0p1?? One of the programmers here is seeing delays of up to 25s, which is clearly unacceptable. He's localized the problem to seeding the random number generator - it appears that the _minimum_ number of commands needed to seed the random number generator is 16. On his hosts (for a variety of reasons), many of those commands time out. We're reconfiguring OSSH to avoid the commands that time out, but we've also considered alternate methods of seeding the random number generator....

..._pcm_offset-diff; + /*Check for overflow.*/ + if(diff<0&&OP_UNLIKELY(OP_INT64_MAX+diff<_pcm_offset)){ + discard_count=0; + } + else discard_count=_pcm_offset-diff; /*We use a threshold of 90 ms instead of 80, since 80 ms is the _minimum_ we would have discarded after a full seek. Assuming 20 ms frames (the default), we'd discard 90 ms on average.*/ -- 2.15.0.448.gf294e3d99a-goog

...;> + if(diff<0&&OP_UNLIKELY(OP_INT64_MAX+diff<_pcm_offset)){ >> + discard_count=0; >> + } >> + else discard_count=_pcm_offset-diff; >> /*We use a threshold of 90 ms instead of 80, since 80 ms is the >> _minimum_ we would have discarded after a full seek. >> Assuming 20 ms frames (the default), we'd discard 90 ms on >> average.*/ >> if(discard_count>=0&&OP_UNLIKELY(discard_count<90*48)){ > > > I think that better than adding a custom overflow c...

...heck for overflow.*/ > + if(diff<0&&OP_UNLIKELY(OP_INT64_MAX+diff<_pcm_offset)){ > + discard_count=0; > + } > + else discard_count=_pcm_offset-diff; > /*We use a threshold of 90 ms instead of 80, since 80 ms is the > _minimum_ we would have discarded after a full seek. > Assuming 20 ms frames (the default), we'd discard 90 ms on average.*/ > if(discard_count>=0&&OP_UNLIKELY(discard_count<90*48)){ I think that better than adding a custom overflow check here, we should use if(OP...

Hi all R-users, If I have a matrix with numeric elements as follows, the values are rounded when I try to refer to a specifici element using [], the value is rounded. The same thing happens if the matrix is read from a file, the values are stored to the correct precision but then when I try to refer to a specific element (such as using [], it is rounded. How do I avoid this rounding?