search for: _klibc_in_open_c

Hi, number three, where I first thought it was a GCC bug but is apparently bad code in klibc. Submitted with permission: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47533#c6 Patch attached again (sorry) not just because that is easier with my mail system but also to keep original author intact. bye, //mirabilos -- > emacs als auch vi zum Kotzen finde (joe rules) und pine f?r den einzig >

.../open64.c > new file mode 100644 > index 0000000..6ca603e > --- /dev/null > +++ b/usr/klibc/open64.c > @@ -0,0 +1,22 @@ > +/* > + * open64.c > + * > + * For 64 bit systems without the open syscall, pass straight > + * through into openat. > + */ > + > +#define _KLIBC_IN_OPEN_C > +#include <unistd.h> > +#include <fcntl.h> > +#include <sys/syscall.h> > + > +#if !defined(__NR_open) && _BITSIZE == 64 > + > +__extern int openat(int, const char *, int, ...); > + > +int open(const char *pathname, int flags, mode_t mode) >...

...but "struct flock" has actually been defined with a long off_t, so it's really "struct flock64". It just happens @@ -35,6 +38,8 @@ # define F_SETLKW F_SETLKW64 #endif +#endif /* _BITSIZE == 32 */ + /* This is defined here as well as in <unistd.h> */ #ifndef _KLIBC_IN_OPEN_C __extern int open(const char *, int, ...);

...har *, size_t); __extern int chown(const char *, uid_t, gid_t); __extern int fchown(int, uid_t, gid_t); __extern int lchown(const char *, uid_t, gid_t); __extern char *getcwd(char *, size_t); +__extern int fchownat(int, const char *, uid_t, gid_t, int); /* Also in <fcntl.h> */ #ifndef _KLIBC_IN_OPEN_C diff --git a/usr/klibc/SYSCALLS.def b/usr/klibc/SYSCALLS.def index 9b07aa2..55d8e36 100644 --- a/usr/klibc/SYSCALLS.def +++ b/usr/klibc/SYSCALLS.def @@ -109,7 +109,7 @@ int swapoff(const char *); int access(const char *, int); int faccessat(int, const char *, int, int); int link(const char *, co...

Hello, This series introduces arm64 support to klibc. I've rebased the work from Neil Williams and Anil Singhar into the following three patches. Most of the code changes are due to new syscall implementations being needed for arm64 as a only a minimal set of syscalls are defined in the arm64 kernel. This series is to be applied against the latest klibc, just after 25a66fa README.klibc:

...if /* __NR_mknod */ diff --git a/usr/klibc/open64.c b/usr/klibc/open64.c new file mode 100644 index 0000000..6ca603e --- /dev/null +++ b/usr/klibc/open64.c @@ -0,0 +1,22 @@ +/* + * open64.c + * + * For 64 bit systems without the open syscall, pass straight + * through into openat. + */ + +#define _KLIBC_IN_OPEN_C +#include <unistd.h> +#include <fcntl.h> +#include <sys/syscall.h> + +#if !defined(__NR_open) && _BITSIZE == 64 + +__extern int openat(int, const char *, int, ...); + +int open(const char *pathname, int flags, mode_t mode) +{ + return openat(AT_FDCWD, pathname, flags, mode...

...--- a/usr/klibc/open.c +++ b/usr/klibc/open.c @@ -3,14 +3,39 @@ * * On 32-bit platforms we need to pass O_LARGEFILE to the open() * system call, to indicate that we're 64-bit safe. + * + * For 64 bit systems without the open syscall, pass straight + * through into openat. */ #define _KLIBC_IN_OPEN_C #include <unistd.h> #include <fcntl.h> #include <bitsize.h> +#include <sys/syscall.h> + +#ifndef __NR_open +#if _BITSIZE == 32 + +extern int __openat(int, const char *, int, mode_t); + +int open(const char *pathname, int flags, mode_t mode) +{ + return __openat(AT_FDCWD,...

Hello, Here is V2 of the arm64 support for klibc patch set. Notable changes since the original series: * fp regs dropped from setjmp/longjmp * chmod, lstat and stat re-implemented with *at functions. * open64 merged into open. As with the original, this series is to be applied against the latest klibc, just after 25a66fa README.klibc: update build information V2 has been tested on x86_64