search for: _install_capability

...statement for GrubLegacy (matching what is used in the Grub2 package). This is required to prevent an undefined subroutine error for the augeas_error call in list_kernels(). There are also a few minor typo fixups: - A message string in _configure_kernel was missing the $ before a variable - In _install_capability, the expression that filters out 'xen' should actually filter out '-xen' - Two typos in comments were irritating me ;) --- lib/Sys/VirtConvert/Converter/RedHat.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/Sys/VirtConvert/Converter/RedH...

...e vmlinuz file. As the above pattern change doesn't really effect SUSE, I was hoping you could check the output under RedHat and let me know if you'd like '$path: ' removed from my version. One other item I was hoping you could doublecheck is in the filtering out of xen/xenU in _install_capability. Shouldn't the xen/xenU portion of the release string actually be '-xen/xenU'? In other words, would the inclusion of the hypen in the following code also be applicable for RedHat? if (defined($kernel_release) && $kernel_rel...

...onvert::Converter::Linux::GrubLegacy->new($g, $root) } unless defined($grub); v2vdie __('No grub configuration found') unless defined($grub); @@ -611,13 +710,15 @@ sub convert _unconfigure_hv($g, $root); # Try to install the virtio capability - my $virtio = _install_capability('virtio', $g, $root, $config, $meta, $grub); + my $virtio = + _install_capability('virtio', $g, $root, $config, $meta, $grub); # Get an appropriate kernel, or install one if none is available my $kernel = _configure_kernel($virtio, $g, $root, $config, $meta, $...

...e X driver, check if X itself is actually installed. If it - # is, ensure the qxl driver is installed. + # is, ensure the specified driver is installed. if ($updated && ($g->exists('/usr/bin/X') || $g->exists('/usr/bin/X11/X')) && - !_install_capability('qxl', $g, $root, $config, $meta, $grub)) + !_install_capability($driver, $g, $root, $config, $meta, $grub)) { - logmsg WARN, __('Display driver was updated to qxl, but unable to '. - 'install qxl driver. X may not function correctly'...

In preparation for an upcoming patch which adds support for SUSE guest conversions, it makes sense to have an intermediate steps that changes the RedHat.pm converter into a more generic Linux converter. The SUSE changes will then be limited in scope to only what is required for SUSE support. This series of patches accomplishes the following: - Renames RedHat.pm to Linux.pm - Modifies Linux.pm

...l free to remove ^$path. However, for robustness I ditch the leading ^ from your replacement. The difference will be down to a different version of file included in the libguestfs appliance on SUSE. > One other item I was hoping you could doublecheck is in the filtering out of > xen/xenU in _install_capability. Shouldn't the xen/xenU portion of the release > string actually be '-xen/xenU'? In other words, would the inclusion of the > hypen in the following code also be applicable for RedHat? > > if (defined($kernel_release) && >...

If a volume is not an exact multiple of 512 bytes, qemu-img will report its size rounded down to a 512 byte boundary. However, when copying, the file is still read until EOF, which will return more data than was expected. This change prevents that causing a failure in itself. The situation is still not resolved, however, as there are still situations where this will cause a failure. For example,

This is a new conversion module to convert SUSE Linux and openSUSE guests. The converter is based on the RedHat module, and should offer the same functionality on both SUSE and RedHat hosts. There are a few additional messages in this module, such as reporting of packages when installing through zypper or the local virt-v2v repo. These messages don't necessarily flow unless verbose switches

...unless defined($grub); + v2vdie __('No grub configuration found') unless defined($grub); + + # Un-configure HV specific attributes which don't require a direct + # replacement + _unconfigure_hv($g, $root); + + # Try to install the virtio capability + my $virtio = _install_capability('virtio', $g, $root, $config, $meta, $grub); + + # Get an appropriate kernel, or install one if none is available + my $kernel = _configure_kernel($virtio, $g, $root, $config, $meta, $grub); + + # Install user custom packages + if (! _install_capability('user-custom', $g...

...2vdie __('No grub configuration found') unless defined($grub); > + > + # Un-configure HV specific attributes which don't require a direct > + # replacement > + _unconfigure_hv($g, $root); > + > + # Try to install the virtio capability > + my $virtio = _install_capability('virtio', $g, $root, $config, $meta, $grub); > + > + # Get an appropriate kernel, or install one if none is available > + my $kernel = _configure_kernel($virtio, $g, $root, $config, $meta, $grub); > + > + # Install user custom packages > + if (! _install_capabi...

...unless defined($grub); + v2vdie __('No grub configuration found') unless defined($grub); + + # Un-configure HV specific attributes which don't require a direct + # replacement + _unconfigure_hv($g, $root); + + # Try to install the virtio capability + my $virtio = _install_capability('virtio', $g, $root, $config, $meta, $grub); + + # Get an appropriate kernel, or install one if none is available + my $kernel = _configure_kernel($virtio, $g, $root, $config, $meta, $grub); + + # Install user custom packages + if (! _install_capability('user-custom', $g...

Thanks for the comments, Matt. On Thursday, October 03, 2013 05:34:27 PM Matthew Booth wrote: > > - # There should be an installed virtio capable kernel if virtio was > > installed - die("virtio configured, but no virtio kernel found") > > + # Warn if there is no installed virtio capable kernel. It is safe to > > + # continue and attempt to install a

...ent") unless defined($meta); @@ -112,7 +117,7 @@ sub convert # Un-configure HV specific attributes which don't require a direct # replacement - _unconfigure_hv($g, $desc); + _unconfigure_hv($g, $root, $desc); # Try to install the virtio capability my $virtio = _install_capability('virtio', $g, $config, $meta, $desc); @@ -125,7 +130,7 @@ sub convert _configure_display_driver($g); _remap_block_devices($meta, $virtio, $g, $desc); _configure_kernel_modules($g, $desc, $virtio, $modpath); - _configure_boot($kernel, $virtio, $g, $desc); + _configure_bo...

The following series of patches adds support for converting SUSE guests through virt-v2v. These changes should not impact non-SUSE guest conversions. Mike Latimer (4): Add perl-Bootloader support to grub packages Add conversion support for SUSE guests Add SUSE to capabilities db and conf Add SUSE support documentation lib/Sys/VirtConvert/Converter/Linux.pm | 480