Displaying 3 results from an estimated 3 matches for "_ge".
Did you mean:
_gc
2016 May 17
2
Re: [PATCH 1/2] src: start unifying version handling
On Tue, May 17, 2016 at 03:41:10PM +0200, Pino Toscano wrote:
> +extern bool guestfs_int_version_is (const struct version *v, int maj, int min, int mic);
I think calling this function "is" is a bit misleading. I think
we should have _ge and _le functions (cf my patch).
This comparison for example is wrong:
> /* qemu 1.1 claims to support virtio-scsi but in reality it's broken. */
> - if (data->qemu_version_major == 1 && data->qemu_version_minor < 2)
> + if (!guestfs_int_version_is (&data-&g...
2016 May 18
0
Re: [PATCH 1/2] src: start unifying version handling
...Richard W.M. Jones wrote:
> On Tue, May 17, 2016 at 03:41:10PM +0200, Pino Toscano wrote:
> > +extern bool guestfs_int_version_is (const struct version *v, int maj, int min, int mic);
>
> I think calling this function "is" is a bit misleading. I think
> we should have _ge and _le functions (cf my patch).
Makes sense, renamed to _ge.
> This comparison for example is wrong:
>
> > /* qemu 1.1 claims to support virtio-scsi but in reality it's broken. */
> > - if (data->qemu_version_major == 1 && data->qemu_version_minor < 2)...
2016 May 17
3
[PATCH 0/2] src: introduce an helper version struct
Hi,
this adds an helper version struct, and uses it in the backends (for the
libvirt and qemu versions) and inspection code. This also moves common
code to that, so it is not repeated in many places.
This should help with the small refactoring proposed with
https://www.redhat.com/archives/libguestfs/2016-May/msg00070.html
Thanks,
Pino Toscano (2):
src: start unifying version handling