search for: _fullpath

...files the answer is not generally well-defined and I'm sure what the best approach would be. S+ has a match.path() function that is like match() but the equality test is that the strings refer to the same file. On Unix it checks that the inode and device numbers are the same; on Windows that _fullpath() returns the same thing for both paths. E.g., > match.path(c("c:/PROGRA~1", "c:\\temp", "C:/Program Files/../Program Files"), c("C:\\Program Files", "C:\\Temp")) [1] 1...

...t back to UTF-8. If you need to be pedantic about recognizing whether two paths are the same on Windows you also need to call GetFullPathName in order to expand any 8.3 path components, but this is an expensive function so I wouldn't do it unless absolutely necessary. There is also a call to _fullpath in there that needs to be changed to _wfullpath. The rest of the patch looks good. On Sep 23, 2011, at 9:57 AM, Nikola Smiljanic wrote: > Here's a new patch that fixes all the issues mentioned before. Note that this isn't final, I didn't want to replace all calls to ::stat so that...

...t; > If you need to be pedantic about recognizing whether two paths are the same on Windows you also need to call GetFullPathName in order to expand any 8.3 path components, but this is an expensive function so I wouldn't do it unless absolutely necessary. > > There is also a call to _fullpath in there that needs to be changed to _wfullpath. > > The rest of the patch looks good. > > On Sep 23, 2011, at 9:57 AM, Nikola Smiljanic wrote: > >> Here's a new patch that fixes all the issues mentioned before. Note that this isn't final, I didn't want to replac...

...u need to be pedantic about recognizing whether two paths are the same > on Windows you also need to call GetFullPathName in order to expand any 8.3 > path components, but this is an expensive function so I wouldn't do it > unless absolutely necessary. > > There is also a call to _fullpath in there that needs to be changed to > _wfullpath. > > The rest of the patch looks good. > > On Sep 23, 2011, at 9:57 AM, Nikola Smiljanic wrote: > > Here's a new patch that fixes all the issues mentioned before. Note that > this isn't final, I didn't want to rep...

...If you need to be pedantic about recognizing whether two paths are the same on Windows you also need to call GetFullPathName in order to expand any 8.3 path components, but this is an expensive function so I wouldn't do it unless absolutely necessary. >> >> There is also a call to _fullpath in there that needs to be changed to _wfullpath. >> >> The rest of the patch looks good. >> >> On Sep 23, 2011, at 9:57 AM, Nikola Smiljanic wrote: >> >>> Here's a new patch that fixes all the issues mentioned before. Note that this isn't final, I d...

...c about recognizing whether two paths are the >> same on Windows you also need to call GetFullPathName in order to expand any >> 8.3 path components, but this is an expensive function so I wouldn't do it >> unless absolutely necessary. >> >> There is also a call to _fullpath in there that needs to be changed to >> _wfullpath. >> >> The rest of the patch looks good. >> >> On Sep 23, 2011, at 9:57 AM, Nikola Smiljanic wrote: >> >> Here's a new patch that fixes all the issues mentioned before. Note that >> this isn't...

...whether two paths are the >>> same on Windows you also need to call GetFullPathName in order to expand any >>> 8.3 path components, but this is an expensive function so I wouldn't do it >>> unless absolutely necessary. >>> >>> There is also a call to _fullpath in there that needs to be changed to >>> _wfullpath. >>> >>> The rest of the patch looks good. >>> >>> On Sep 23, 2011, at 9:57 AM, Nikola Smiljanic wrote: >>> >>> Here's a new patch that fixes all the issues mentioned before. Note...

...need to be pedantic about recognizing whether two paths are the same on Windows you also need to call GetFullPathName in order to expand any 8.3 path components, but this is an expensive function so I wouldn't do it unless absolutely necessary. >>> >>> There is also a call to _fullpath in there that needs to be changed to _wfullpath. >>> >>> The rest of the patch looks good. >>> >>> On Sep 23, 2011, at 9:57 AM, Nikola Smiljanic wrote: >>> >>>> Here's a new patch that fixes all the issues mentioned before. Note that t...

...e the >>>> same on Windows you also need to call GetFullPathName in order to expand any >>>> 8.3 path components, but this is an expensive function so I wouldn't do it >>>> unless absolutely necessary. >>>> >>>> There is also a call to _fullpath in there that needs to be changed to >>>> _wfullpath. >>>> >>>> The rest of the patch looks good. >>>> >>>> On Sep 23, 2011, at 9:57 AM, Nikola Smiljanic wrote: >>>> >>>> Here's a new patch that fixes all the is...

...c about recognizing whether two paths are the >> same on Windows you also need to call GetFullPathName in order to expand any >> 8.3 path components, but this is an expensive function so I wouldn't do it >> unless absolutely necessary. >> >> There is also a call to _fullpath in there that needs to be changed to >> _wfullpath. >> >> The rest of the patch looks good. >> >> On Sep 23, 2011, at 9:57 AM, Nikola Smiljanic wrote: >> >> Here's a new patch that fixes all the issues mentioned before. Note that >> this isn't...

Here's a new patch that fixes all the issues mentioned before. Note that this isn't final, I didn't want to replace all calls to ::stat so that it's easier to review. I have only one more questions: 1. _wopen accepts _stat64i32 instead of stat structure. These two are exactly the same, the only difference is that stat uses time_t and _stat64i32 uses __time64_t (time_t is a

On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> wrote: > OK since this approach makes sense I'll shoot with my questions :) > 1. Where should get_utf8_argv go and is the name of this function OK? Right > now the function is inside llvm::sys::fs namespace because I need access to > Windows.h, should I leave it there. I don't think it belongs

...be pedantic about recognizing whether two paths are the same on Windows you also need to call GetFullPathName in order to expand any 8.3 path components, but this is an expensive function so I wouldn't do it unless absolutely necessary. >>>> >>>> There is also a call to _fullpath in there that needs to be changed to _wfullpath. >>>> >>>> The rest of the patch looks good. >>>> >>>> On Sep 23, 2011, at 9:57 AM, Nikola Smiljanic wrote: >>>> >>>>> Here's a new patch that fixes all the issues menti...