search for: _ftol2

Hi Joe & Michael, In rev. 151382 you have changed the fptoui implementation of the x86 codegen for win32. Before the change fptoui was lowered to flds 16(%esp) fisttpll 8(%esp) movl 8(%esp), %eax After the change fptoui is lowered to flds 40(%esp) calll _ftol2 Please note that the assumption that _ftol2 doesn't modify ECX isn't true on sandybridge platform. Could you share with me the reasons behind this change? Did you get better performance after this change? Thanks, Asaf --------------------------------------------------------------------- I...

...should go with something like 1. > > Please investigate if there are other libcalls like this. If so, we should work out a proper solution instead of the inlineasm hack. The integer runtime functions (_allmul, _alldiv, etc. for 64-bit integer arithmetic) all appear to be straight-up stdcall. _ftol2 is the only weird one. (There is an _ftol routine with the same calling convention as _ftol2, but AFAIK it's only for backward compatibility with older MSVC runtimes.) I'm far from an MSVC expert, though. Are there any docs for X86FloatingPoint? At a glance the FISTP etc. definitions look...

...10:12 AM, Joe Groff wrote: > 2012/1/19 Jakob Stoklund Olesen <stoklund at 2pi.dk>: >> How many of these libcalls do you need to implement? What exactly is the calling convention? Which registers are clobbered etc. > > There is only one (that I know about so far). The MSVCRT `_ftol2` > function implements floating-point-to-unsigned conversion for i386 > targets, and LLVM 3.0 calls it with the cdecl calling convention for > `fptoui to i64` when targeting i386-pc-win32. However, it has its own > calling convention: The input value is taken from ST0 and popped off &gt...

2012/1/19 Jakob Stoklund Olesen <stoklund at 2pi.dk>: > How many of these libcalls do you need to implement? What exactly is the calling convention? Which registers are clobbered etc. There is only one (that I know about so far). The MSVCRT `_ftol2` function implements floating-point-to-unsigned conversion for i386 targets, and LLVM 3.0 calls it with the cdecl calling convention for `fptoui to i64` when targeting i386-pc-win32. However, it has its own calling convention: The input value is taken from ST0 and popped off of the x87 stack, and t...

Hi everyone. On i386--win32 targets, LLVM tries to use the MSVCRT routine _ftol2 for floating-point to unsigned conversions, but this function has a nonstandard calling convention LLVM doesn't understand. It takes its input operand on the x87 stack as ST0, which it pops off of the stack before returning. The return value is given in EDX:EAX. In effect, I need to call it lik...

On Jan 18, 2012, at 8:56 PM, Joe Groff wrote: > 2012/1/18 Jakob Stoklund Olesen <stoklund at 2pi.dk>: >> This should work: >> %1 = call i64 asm "call __ftol2", "=A,{st},~{dirflag},~{fpsr},~{flags},~{st}" (double %x) nounwind > > Forgive me for being slow, but what would be the best way to implement > the equivalent of that inline asm as a custom lowering for an > instruction? Can I just create a CallInst and tell it to lower...

On Jan 20, 2012, at 1:58 PM, Joe Groff wrote: > The integer runtime functions (_allmul, _alldiv, etc. for 64-bit > integer arithmetic) all appear to be straight-up stdcall. _ftol2 is > the only weird one. (There is an _ftol routine with the same calling > convention as _ftol2, but AFAIK it's only for backward compatibility > with older MSVC runtimes.) I'm far from an MSVC expert, though. Thanks. > Are there any docs for X86FloatingPoint? X86FloatingPoi...

On Jan 18, 2012, at 3:50 PM, Joe Groff wrote: > Hi everyone. On i386--win32 targets, LLVM tries to use the MSVCRT > routine _ftol2 for floating-point to unsigned conversions, but this > function has a nonstandard calling convention LLVM doesn't understand. > It takes its input operand on the x87 stack as ST0, which it pops off > of the stack before returning. The return value is given in EDX:EAX. > In effect, I...

2012/1/18 Jakob Stoklund Olesen <stoklund at 2pi.dk>: > This should work: > %1 = call i64 asm "call __ftol2", "=A,{st},~{dirflag},~{fpsr},~{flags},~{st}" (double %x) nounwind Thanks Jakob, the ~{st} constraint does the trick. It wasn't clear to me that "clobbers" means "pops" for x87 registers. -Joe

2012/1/18 Jakob Stoklund Olesen <stoklund at 2pi.dk>: > This should work: > %1 = call i64 asm "call __ftol2", "=A,{st},~{dirflag},~{fpsr},~{flags},~{st}" (double %x) nounwind Forgive me for being slow, but what would be the best way to implement the equivalent of that inline asm as a custom lowering for an instruction? Can I just create a CallInst and tell it to lower that instead, or do...

On Tue, Jan 24, 2012 at 4:32 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote: > Yes, your definition of the new instruction looks sane. > > However, you shouldn't expand the instruction right away in EmitInstrWithCustomInserter(), and leaving the pseudo and call instructions side by side is not going to work. > > Just leave the pseudo-instruction alone until it hits

On Fri, Jan 20, 2012 at 2:10 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote: > X86FloatingPoint.cpp with comments is all you get. Thanks for your help, Jakob. Attached is a first-pass attempt at a patch. I don't want to post to -commits yet because I have no idea if this is fully correct, but it seems to work in simple test cases. Am I on the right track? Could this patch ever

On Jan 24, 2012, at 2:30 PM, Joe Groff wrote: > On Fri, Jan 20, 2012 at 2:10 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote: >> X86FloatingPoint.cpp with comments is all you get. > > Thanks for your help, Jakob. Attached is a first-pass attempt at a > patch. I don't want to post to -commits yet because I have no idea if > this is fully correct, but it seems

Hi Ralph, Two diffs. One for vorbis.def and the other for vorbisfile.def. Hope they work!! regards John -------------- next part -------------- A non-text attachment was scrubbed... Name: vorbisdef.diff Type: application/octet-stream Size: 256 bytes Desc: vorbisdef.diff Url : http://lists.xiph.org/pipermail/vorbis-dev/attachments/20031001/3b7df5ad/vorbisdef-0001.obj -------------- next part

The calls represent the MSVC _ftol2 function I think. On Thu, Jul 18, 2013 at 11:34 PM, Peter Newman <peter at uformia.com> wrote: > (Changing subject line as diagnosis has changed) > > I'm attaching the compiled code that I've been getting, both with > CodeGenOpt::Default and CodeGenOpt::None . The cras...

...d Recovery -- endless loop 4561 winecfg crash with ATI fglrx kernel driver on firegl based graphics cards 8938 Regression in SCIM input 9664 Missing icon during MS Office 2000 installation 11466 Bookworm Deluxe crashes on startup 11676 Urban Assault fails to load due to msvcrt.dll._ftol2 13505 iTunes 7.6 crashes when previewing video 14174 Warhammer 40K - upper line blank (text rendered incorrectly) 14916 Dameware NTutilities crashes 16090 Fritz 11 Crashes on exit with builtin shdocvw 16543 PopCap: FATAL ERROR: Invalid command line parameter 17707 wine crashes whe...

...devenum: Scan special device categories more often. powrprof: Add stubs for PowerGetActiveScheme and PowerReadDCValue. advapi32: Fix RegGetValue on REG_BINARY data. userenv: Implement DestroyEnvironmentBlock. includes: Fix typo in mmdeviceapi.idl. msvcrt: Forward _ftol2 to ntdll._ftol. avrt: Add stub for AvSetMmThreadPriority. dwmapi: Silence a noisy fixme. Marcus Meissner (4): winhttp: On NULL request, skip the other tests (Coverity). msi: Call Custom function via wrapper. ws2_32: Check namelen before dereferencing it in TRACE (Cove...

Hmm, I'm not able to get those .ll files to compile if I disable SSE and I end up with SSE instructions(including sqrtpd) if I don't disable it. On Thu, Jul 18, 2013 at 10:53 PM, Peter Newman <peter at uformia.com> wrote: > Is there something specifically required to enable SSE? If it's not > detected as available (based from the target triple?) then I don't think