search for: _format_time

...ation date - my $now = gmtime(); - my $vmcreation = sprintf("%02d/%02d/%d %02d:%02d:%02d", - $now->mday(), $now->mon() + 1, $now->year() + 1900, - $now->hour(), $now->min(), $now->sec()); + my $vmcreation = _format_time(gmtime()); my $osuuid = Sys::VirtV2V::Target::RHEV::UUIDHelper::get_uuid(); @@ -651,6 +648,14 @@ EOF $nfs->check_exit(); } +sub _format_time +{ + my ($time) = @_; + return sprintf("%04d/%02d/%02d %02d:%02d:%02d", + $time->year() + 1900, $time...

...ertions(+), 4 deletions(-) diff --git a/lib/Sys/VirtV2V/Target/RHEV.pm b/lib/Sys/VirtV2V/Target/RHEV.pm index 867923b..9dd9013 100644 --- a/lib/Sys/VirtV2V/Target/RHEV.pm +++ b/lib/Sys/VirtV2V/Target/RHEV.pm @@ -562,7 +562,7 @@ sub create_guest # Generate a creation date my $vmcreation = _format_time(gmtime()); - my $osuuid = Sys::VirtV2V::Target::RHEV::UUIDHelper::get_uuid(); + my $vmuuid = Sys::VirtV2V::Target::RHEV::UUIDHelper::get_uuid(); my $ovf = new XML::DOM::Parser->parse(<<EOF); <ovf:Envelope @@ -597,7 +597,7 @@ sub create_guest <VmType>1</...

This will allow use of raw data from os description in addition to libvirt XML when writing guest output. --- lib/Sys/VirtV2V/Target/LibVirt.pm | 2 +- lib/Sys/VirtV2V/Target/RHEV.pm | 2 +- v2v/virt-v2v.pl | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Sys/VirtV2V/Target/LibVirt.pm b/lib/Sys/VirtV2V/Target/LibVirt.pm index

If a volume is not an exact multiple of 512 bytes, qemu-img will report its size rounded down to a 512 byte boundary. However, when copying, the file is still read until EOF, which will return more data than was expected. This change prevents that causing a failure in itself. The situation is still not resolved, however, as there are still situations where this will cause a failure. For example,

...torage domains don't have names sub volume_exists { - my $self = shift; - my ($name) = @_; - return 0; } -=item get_volume (name) +=item get_volume(name) Not defined for RHEV output @@ -675,7 +751,7 @@ sub create_guest # Generate a creation date my $vmcreation = _format_time(gmtime()); - my $vmuuid = Sys::VirtV2V::Target::RHEV::UUIDHelper::get_uuid(); + my $vmuuid = rhev_util::get_uuid(); my $ostype = _get_os_type($desc); @@ -755,20 +831,20 @@ EOF $self->_disks($ovf, $dom); $self->_networks($ovf, $dom); - my $nfs = Sys::VirtV2V::Ta...