search for: _fin

...us_ifft_float_neon(const kiss_fft_state *st, + const kiss_fft_cpx *fin, + kiss_fft_cpx *fout); + #if !defined(OPUS_HAVE_RTCD) #define OVERRIDE_OPUS_FFT (1) @@ -58,6 +63,9 @@ void opus_fft_float_neon(const kiss_fft_state *st, #define opus_fft(_st, _fin, _fout, arch) \ ((void)(arch), opus_fft_float_neon(_st, _fin, _fout)) +#define opus_ifft(_st, _fin, _fout, arch) \ + ((void)(arch), opus_ifft_float_neon(_st, _fin, _fout)) + #endif /* OPUS_HAVE_RTCD */ #endif /* HAVE_ARM_NE10 */ diff --git a/celt/arm/mdct_arm.h b/celt/arm/mdct_arm.h ind...

...us_ifft_float_neon(const kiss_fft_state *st, + const kiss_fft_cpx *fin, + kiss_fft_cpx *fout); + #if !defined(OPUS_HAVE_RTCD) #define OVERRIDE_OPUS_FFT (1) @@ -58,6 +63,9 @@ void opus_fft_float_neon(const kiss_fft_state *st, #define opus_fft(_st, _fin, _fout, arch) \ ((void)(arch), opus_fft_float_neon(_st, _fin, _fout)) +#define opus_ifft(_st, _fin, _fout, arch) \ + ((void)(arch), opus_ifft_float_neon(_st, _fin, _fout)) + #endif /* OPUS_HAVE_RTCD */ #endif /* HAVE_ARM_NE10 */ diff --git a/celt/arm/mdct_arm.h b/celt/arm/mdct_arm.h ind...

Hello All, I extended the libNE10 optimizations for float towards mdct_backwards/opus_ifft. I am able to get about 14.26% improvement for Decode use case now on my Beaglebone Black. Please see [1] for measurements. Questions 1. Since this patch needs to go in after Encode [2] patch) should I submit this as patch series? 2. Since Jonathan Lennox posted intrinsics cleanup [3] patch, should

...t_alloc_arch(_st, arch) \ - ((void)(arch), opus_fft_alloc_arm_float_neon(_st)) + ((void)(arch), opus_fft_alloc_arm_neon(_st)) #define opus_fft_free_arch(_st, arch) \ - ((void)(arch), opus_fft_free_arm_float_neon(_st)) + ((void)(arch), opus_fft_free_arm_neon(_st)) #define opus_fft(_st, _fin, _fout, arch) \ - ((void)(arch), opus_fft_float_neon(_st, _fin, _fout)) + ((void)(arch), opus_fft_neon(_st, _fin, _fout)) #define opus_ifft(_st, _fin, _fout, arch) \ - ((void)(arch), opus_ifft_float_neon(_st, _fin, _fout)) + ((void)(arch), opus_ifft_neon(_st, _fin, _fout)) #endif /* O...

Hi All, As per Timothy's suggestion, disabling mdct_forward for fixed point. Only effects armv7,armv8: Extend fixed fft NE10 optimizations to mdct Rest of patches are same as in [1] For reference, latest wip code for opus is at [2] Still working with NE10 team at ARM to get corner cases of mdct_forward. Will update with another patch when issue in NE10 gets fixed. Regards, Vish [1]:

Hi All, Changes from RFC v2 [1] armv7,armv8: Extend fixed fft NE10 optimizations to mdct - Overflow issue fixed by Phil at ARM. Ne10 wip at [2]. Should be upstream soon. - So, re-enabled using fixed fft for mdct_forward which was disabled in RFCv2 armv7,armv8: Optimize fixed point fft using NE10 library - Thanks to Jonathan Lennox, fixed some build fixes on iOS and some copy-paste errors Rest

Hello Timothy / Jean-Marc / opus-dev, This patch series is follow up on work I posted on [1]. In addition to what was posted on [1], this patch series mainly integrates Fixed point FFT implementations in NE10 library into opus. You can view my opus wip code at [2]. Note that while I found some issues both with the NE10 library(fixed fft) and with Linaro toolchain (armv8 intrinsics), the work

...cpx *fin, + kiss_fft_cpx *fout); +#if !defined(OPUS_HAVE_RTCD) +#define OVERRIDE_OPUS_FFT (1) + +#define opus_fft_alloc_arch(_st, arch) \ + opus_fft_alloc_arm_float_neon(_st) + +#define opus_fft_free_arch(_st, arch) opus_fft_free_arm_float_neon(_st) + +#define opus_fft(_st, _fin, _fout, arch) \ + opus_fft_float_neon(_st, _fin, _fout) + +#endif /* OPUS_HAVE_RTCD */ + +#endif /* HAVE_ARM_NE10 */ +#endif /* FIXED_POINT */ + +#endif diff --git a/celt/arm/mdct_arm.h b/celt/arm/mdct_arm.h new file mode 100644 index 0000000..d0a8a8c --- /dev/null +++ b/celt/arm/mdct_arm.h @@ -0...

...0 fft/ifft/mdct_forward/backward patches, I thought it would be better to just post all new patches as a patch series. Please let me know if anyone disagrees with this approach. You can see wip branch of all latest patches at https://git.linaro.org/people/viswanath.puttagunta/opus.git Branch: rfcv1_final_armv8 aarch64: Enable intrinsics for aarch64 - enables intrinsics (includes Ne10) optimizations for aarch64. armv7(float): Optimize encode usecase using NE10 library - Changes from RFCv4 [1]: Caught compile issue while enabling armv8 in celt/arm/mdct_arm.h armv7(float): Optimize decode usec...

...] For reference, you can use the Ne10 pre-built libraries at [3] Note that I am working with Phil at ARM to get my patch at [4] upstreamed to Ne10. [1]: http://lists.xiph.org/pipermail/opus/2015-March/002941.html [2]: https://git.linaro.org/people/viswanath.puttagunta/opus.git Branch: rfcv1_final_xcorr_fixed_armv8 [3]: http://people.linaro.org/~viswanath.puttagunta/opus/NE10_root/ [4]: git://git.linaro.org/people/viswanath.puttagunta/Ne10.git Branch: rfcv1_rc1_armv8 Jonathan Lennox (1): Intrinsics/RTCD related fixes. Mostly x86 Viswanath Puttagunta (4): armv7(float): Optimize...

Hello opus-dev, I've been cooking up this patchset to integrate NE10 library into opus. Current patchset focuses on encode use case mainly effecting performance of clt_mdct_forward() and opus_fft() (for float only) Glad to report the following on Encode use case: (Measured on my Beaglebone Black Cortex-A8 board) - Performance improvement for encode use case ~= 12.34% (Based on time -p

...s_fft_cpx *fout); +#if !defined(OPUS_HAVE_RTCD) +#define OVERRIDE_OPUS_FFT (1) + +#define opus_fft_alloc_arch(_st, arch) \ + ((void)(arch), opus_fft_alloc_arm_float_neon(_st)) + +#define opus_fft_free_arch(_st, arch) \ + ((void)(arch), opus_fft_free_arm_float_neon(_st)) + +#define opus_fft(_st, _fin, _fout, arch) \ + ((void)(arch), opus_fft_float_neon(_st, _fin, _fout)) + +#endif /* OPUS_HAVE_RTCD */ + +#endif /* HAVE_ARM_NE10 */ +#endif /* FIXED_POINT */ + +#endif diff --git a/celt/arm/mdct_arm.h b/celt/arm/mdct_arm.h new file mode 100644 index 0000000..33f7bb6 --- /dev/null +++ b/celt/arm/...

...s_fft_cpx *fout); +#if !defined(OPUS_HAVE_RTCD) +#define OVERRIDE_OPUS_FFT (1) + +#define opus_fft_alloc_arch(_st, arch) \ + ((void)(arch), opus_fft_alloc_arm_float_neon(_st)) + +#define opus_fft_free_arch(_st, arch) \ + ((void)(arch), opus_fft_free_arm_float_neon(_st)) + +#define opus_fft(_st, _fin, _fout, arch) \ + ((void)(arch), opus_fft_float_neon(_st, _fin, _fout)) + +#endif /* OPUS_HAVE_RTCD */ + +#endif /* HAVE_ARM_NE10 */ +#endif /* FIXED_POINT */ + +#endif diff --git a/celt/arm/mdct_arm.h b/celt/arm/mdct_arm.h new file mode 100644 index 0000000..33f7bb6 --- /dev/null +++ b/celt/arm/...

...s_fft_cpx *fout); +#if !defined(OPUS_HAVE_RTCD) +#define OVERRIDE_OPUS_FFT (1) + +#define opus_fft_alloc_arch(_st, arch) \ + ((void)(arch), opus_fft_alloc_arm_float_neon(_st)) + +#define opus_fft_free_arch(_st, arch) \ + ((void)(arch), opus_fft_free_arm_float_neon(_st)) + +#define opus_fft(_st, _fin, _fout, arch) \ + ((void)(arch), opus_fft_float_neon(_st, _fin, _fout)) + +#endif /* OPUS_HAVE_RTCD */ + +#endif /* HAVE_ARM_NE10 */ +#endif /* FIXED_POINT */ + +#endif diff --git a/celt/arm/mdct_arm.h b/celt/arm/mdct_arm.h new file mode 100644 index 0000000..7d60fed --- /dev/null +++ b/celt/arm/...

Changes from RFC PATCH v3 - Just rebased on tip - For all else, please see notes from RFC PATCH v3 at http://lists.xiph.org/pipermail/opus/2015-March/002902.html - latest wip opus tree/branch https://git.linaro.org/people/viswanath.puttagunta/Ne10.git branch: rfcv4_final_fft_ne10 Viswanath Puttagunta (1): armv7(float): Optimize encode usecase using NE10 library Makefile.am | 34 +-- celt/arm/arm_celt_map.c | 47 +++- celt/arm/celt_ne10_fft.c | 120 ++++++++++ celt/arm/celt_ne10_mdct.c | 158 +...

...ors/warnings coming out of Ne10 library? You can find my working Ne10 repo at [1] You can find my working opus repo at [2] Commands I used to build opus: Download code $ git clone git://git.linaro.org/people/viswanath.puttagunta/opus.git $ cd opus $ git checkout -b local_rfcv2 remotes/origin/rfcv2_final_opus_fft_ne10 Compile code $ ./autogen.sh $ mkdir ../build $ cd ../build $ export PATH=$PATH:<path_to_arm-linux-gnueabihf_bin_dir> $ ../opus/configure --host=arm-linux-gnueabihf --enable-intrinsics --with-NE10-libraries=<path_to_Ne10_libraries> --with-NE10-includes=<path_to_Ne10_i...

...or ARMv7 targets performance will not be improved. - For my performance testing, see my wip Ne10 branch below that applies -funsafe-math-optimizations - For references below are my wip trees for this RFCv3 patch https://git.linaro.org/people/viswanath.puttagunta/opus.git Branch: rfcv3_final_opus_fft_ne10 https://git.linaro.org/people/viswanath.puttagunta/Ne10.git rfcv3_final_ne10_fft Viswanath Puttagunta (1): armv7(float): Optimize encode usecase using NE10 library Makefile.am | 34 +-- celt/arm/arm_celt_map.c | 47 +++- celt/arm/...