search for: _fill

...working trunk I never would have committed a change which could reasonably have been expect to cause any real breakage. As far as controversial goes, I probably should have put it in scare quotes. The kind of controversial I'm talking about is the name of the function I added (I don't like _fill() much myself, but nothing better seemed obvious) or the decision to add a somewhat kludgey additional input function rather than break the ABI and add a one shot control. If the new function stays it will likely need a test case. I'm not going to write one until the decision is final that we...

...r 100G disk with no data on it, that > is one hole extent spanning the whole disk (where there is no space for > improvement) this does not add any noticeable overhead. > > Signed-off-by: Martin Kletzander <mkletzan@redhat.com> > --- > v2: > - Errors are set in _add and _fill functions > - Return values are checked for only -1 > - Added a test > - Indentation fixed > - Fixed access before lock > > + > +/* This lock protects the global state. */ > +static pthread_mutex_t lock = PTHREAD_MUTEX_INITIALIZER; > + > +/* The real size of the...

...> route. ... without testing the change (to demonstrate it works, or is useful, or ... anything) ... > As far as controversial goes, I probably should have put it in scare > quotes. The kind of controversial I'm talking about is the name of the > function I added (I don't like _fill() much myself, but nothing better > seemed obvious) or the decision to add a somewhat kludgey additional > input function rather than break the ABI and add a one shot control. ... with misleading check in comments. However it is rather moot since ... > Nothing is broken. The libogg te...

...to the first extents request). For 100G disk with no data on it, that is one hole extent spanning the whole disk (where there is no space for improvement) this does not add any noticeable overhead. Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- v2: - Errors are set in _add and _fill functions - Return values are checked for only -1 - Added a test - Indentation fixed - Fixed access before lock configure.ac | 2 + filters/cacheextents/Makefile.am | 64 ++++++ filters/cacheextents/cacheextents.c | 196 ++++++++++++++...