search for: _features_

Hello, alsa-plugins currently includes speex/speex_types.h, but that doesn't work with speexdsp versions >= 1.2rc2, since speex_types.h has been replaced with speexdsp_types.h. I made a patch for alsa-plugins, so that it includes speexdsp_types.h instead. I also bumped the speexdsp version check from "1.2" to "1.2rc2" in configure.ac, since speexdsp_types.h didn't

...t_triple" is certainly not an expectation or feature of any target; rather, it is an expectation of certain tools when used in certain ways (mainly: llc or llvm-mc without an explicit triple) and therefore it is an expectation of how certain tests are _written_. This has little to do with the _features_ verified by those tests. In particular, configuring a GPU-only LLVM with a default triple for that GPU will still fail all the same tests that Mehdi tripped over. Inventing "default_triple" lets us trick the test suite into skipping the tests that the GPU target would fail anyway. Thi...

...didn't actually verify that, but considering that > pkg-config thinks that "1.2rc2" >= "1.2", it's pretty likely that "1.2" > < "1.2rc2" in pkg-config's mind). This is just one of the reasons why things like this should be testing for _features_ not for versions :) Though possibly the more interesting question is why alsa-plugins is including speex_types.h directly at all? It should really only need that if it's including some other speex header - in which case it should already be getting included by that header anyway ... > As...

On 09/04/2015 10:25 AM, Robinson, Paul via llvm-dev wrote: > >> -----Original Message----- >> From: James Y Knight [mailto:jyknight at google.com] >> Sent: Friday, September 04, 2015 10:12 AM >> To: Mehdi Amini; Mehdi Amini via llvm-dev >> Cc: Robinson, Paul >> Subject: Re: [llvm-dev] Testing "normal" cross-compilers versus GPU >> backends