search for: _f_log_all

...set_config/get_config is missing. It looks to me they are not >>>>> hard, just implementing the access to dev_cfg. It's key to make >>>>> kernel virtio driver to work. >>>>> >>>>> And in the new version of virito-mdev, features like _F_LOG_ALL >>>>> should be advertised through get_mdev_features. >>>> IMHO, currently the driver can work without set/get_config, >>>> vhost_mdev doesn't call them for now. >>> >>> >>> Yes, but it was required by virtio_mdev for host driv...

On Thu, Oct 17, 2019 at 06:48:34PM +0800, Jason Wang wrote: > + * @get_vq_state: Get the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * Returns virtqueue state (last_avail_idx) > + * @get_vq_align: Get the virtqueue align requirement > + * for the device > + * @mdev: mediated device > + * Returns virtqueue algin

...t; for vhost-mdev in kernel to do vhost backend specific setups? > Or do you have any other thoughts? Good point. It's just a quick POC, I plan to add vhost features in the next release: 1) set/get virtqueue state (e.g vring base) 2) dirty page tracking 3) for vhost features, if you mean _F_LOG_ALL, it could be done by 2), for IOTLB, it requires more thought on the API since current IOTLB API is no implemented through ioctl ... > > Besides, I'm also wondering, what's the purpose of making > above registers part of UAPI? Sorry if it brings confusion. If we do vhost-mdev...

On Tue, Sep 10, 2019 at 04:19:34PM +0800, Jason Wang wrote: > This path introduces a new mdev transport for virtio. This is used to > use kernel virtio driver to drive the mediated device that is capable > of populating virtqueue directly. > > A new virtio-mdev driver will be registered to the mdev bus, when a > new virtio-mdev device is probed, it will register the device with

On Tue, Sep 10, 2019 at 04:19:34PM +0800, Jason Wang wrote: > This path introduces a new mdev transport for virtio. This is used to > use kernel virtio driver to drive the mediated device that is capable > of populating virtqueue directly. > > A new virtio-mdev driver will be registered to the mdev bus, when a > new virtio-mdev device is probed, it will register the device with

...ign, >>> +}; >> >> >> set_config/get_config is missing. It looks to me they are not hard, >> just implementing the access to dev_cfg. It's key to make kernel >> virtio driver to work. >> >> And in the new version of virito-mdev, features like _F_LOG_ALL >> should be advertised through get_mdev_features. > IMHO, currently the driver can work without set/get_config, vhost_mdev > doesn't call them for now. Yes, but it was required by virtio_mdev for host driver to work, and it looks to me it's not hard to add them. If possibl...

...fcvf_mdev_get_vendor_id, > + .get_vq_align = ifcvf_mdev_get_vq_align, > +}; set_config/get_config is missing. It looks to me they are not hard, just implementing the access to dev_cfg. It's key to make kernel virtio driver to work. And in the new version of virito-mdev, features like _F_LOG_ALL should be advertised through get_mdev_features. > + > +static int ifcvf_init_msix(struct ifcvf_adapter *adapter) > +{ > + int vector, i, ret, irq; > + struct pci_dev *pdev = to_pci_dev(adapter->dev); > + struct ifcvf_hw *vf = &adapter->vf; > + > + ret = pci_allo...

...+#define VHOST_MDEV_GET_QUEUE_NUM _IOW(VHOST_VIRTIO, 0x74, __u32) >> >> Do we need API for userspace to get backend capability? (that calls >> get_mdev_device_features()) > Vhost already has the features and backend features ioctls. Good point, we probably need a new bit for _F_LOG_ALL. But question still, how vhost-mdev know whether the parent support dirty page tracking? Thanks > In vhost-mdev, it might be better to still just use them to > expose the backend capability to userspace. > > Thanks for the review! > Tiwei > >> Thanks >> >> &g...

On Tue, Oct 22, 2019 at 09:30:16PM +0800, Jason Wang wrote: > On 2019/10/22 ??5:52, Tiwei Bie wrote: > > This patch introduces a mdev based hardware vhost backend. > > This backend is built on top of the same abstraction used > > in virtio-mdev and provides a generic vhost interface for > > userspace to accelerate the virtio devices in guest. > > > > This

On Tue, Oct 22, 2019 at 09:30:16PM +0800, Jason Wang wrote: > On 2019/10/22 ??5:52, Tiwei Bie wrote: > > This patch introduces a mdev based hardware vhost backend. > > This backend is built on top of the same abstraction used > > in virtio-mdev and provides a generic vhost interface for > > userspace to accelerate the virtio devices in guest. > > > > This