search for: _ctl_va_list

Hi Drew, Here's some comments on your patch (in no particular order): 1) I see that it's adding an #include of stdarg.h to opus_multistream.h Is that left over from the previous version? 2) Someone on this list might know better than I do on that one, but for the new _ctl_va_list() calls, I believe the convention is for va_start() and va_end() to appear in the caller rather than in in the va_list() function itself. 3) I'm not sure I understand why the opus_copy_channel_out*() functions had to be moved. 4) OpusPEncoder: I'd prefer a more explicit name: OpusProjecti...

Hi Drew, On 10/10/17 02:29 PM, Drew Allen wrote: > 2) Someone on this list might know better than I do on that one, but for > the new _ctl_va_list() calls, I believe the convention is for va_start() > and va_end() to appear in the caller rather than in in the va_list() > function itself. > > *My understanding is that it's impossible to pass ellipsis to another > function.* Basically, what I mean is that I *think* you shou...

...ess. Attached a new patch with those changes. On Tue, Oct 10, 2017 at 12:19 PM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > Hi Drew, > > On 10/10/17 02:29 PM, Drew Allen wrote: > > 2) Someone on this list might know better than I do on that one, but for > > the new _ctl_va_list() calls, I believe the convention is for va_start() > > and va_end() to appear in the caller rather than in in the va_list() > > function itself. > > > > *My understanding is that it's impossible to pass ellipsis to another > > function.* > > Basically, what...

...and an updated patch. > > 1) I see that it's adding an #include of stdarg.h to opus_multistream.h > Is that left over from the previous version? > > > *That was a typo. Fixed.* > > 2) Someone on this list might know better than I do on that one, but for > the new _ctl_va_list() calls, I believe the convention is for va_start() > and va_end() to appear in the caller rather than in in the va_list() > function itself. > > *My understanding is that it's impossible to pass ellipsis to another > function.* >From "man stdarg.h": " The obj...

...2:19 PM Jean-Marc Valin <jmvalin at jmvalin.ca > <mailto:jmvalin at jmvalin.ca>> wrote: > > Hi Drew, > > On 10/10/17 02:29 PM, Drew Allen wrote: > > 2) Someone on this list might know better than I do on that one, > but for > > the new _ctl_va_list() calls, I believe the convention is for > va_start() > > and va_end() to appear in the caller rather than in in the va_list() > > function itself. > > > > *My understanding is that it's impossible to pass ellipsis to another > > function...

...ks for the feedback. Attached are my comments and an updated patch. 1) I see that it's adding an #include of stdarg.h to opus_multistream.h Is that left over from the previous version? *That was a typo. Fixed.* 2) Someone on this list might know better than I do on that one, but for the new _ctl_va_list() calls, I believe the convention is for va_start() and va_end() to appear in the caller rather than in in the va_list() function itself. *My understanding is that it's impossible to pass ellipsis to another function.* 3) I'm not sure I understand why the opus_copy_channel_out*() functio...

Hello all, Attached is an up-to-date patch for supporting channel mapping 253. Please advise and Thank you for your time. Cheers, Drew -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20170919/055d9034/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: