search for: _cleanup

...------------------------------------------*/ static void _report_R (int *ids, int cnt, int supp, int *tal, void *data) { (...) if (flags & OF_LIST) { vec1 = (int*)realloc(ruleset->trnb, size1 *sizeof(int)); if (!vec1) { if (vec) free(vec); if (vec2) free(vec2); _cleanup(); error(msg(E_NOMEM));} ruleset->trnb = vec1; } (...) if (flags & OF_LIST) { /* if to list the transactions, */ h = ruleset->trtotal; if (supp < 0) { /* if bit vector representation */ for (i = 0; i < tacnt; i++) { /* traverse the bit vector...

...'BEGIN {system("dtrace -l -mlibc.so.1 > libc_dtrace");} pid$target:libc:_c??????:entry{}'' -c ''sleep 1'' % cat libc_dtrace ID PROVIDER MODULE FUNCTION NAME 42288 pid22010 libc.so.1 _cleanup entry 42289 pid22010 libc.so.1 _creat64 entry % /usr/ccs/bin/nm -n /lib/libc.so.1 | grep ''\|_c......$'' | grep FUNC [8747] | 260828| 500|FUNC |GLOB |0 |9 |_catgets [8845] | 261328| 148|FUNC |GLOB |0 |9 |_catopen [61...

...insertions(+), 49 deletions(-) create mode 100644 tests/generic/321 create mode 100644 tests/generic/321.out diff --git a/tests/generic/311 b/tests/generic/311 index 675d927..6802a96 100644 --- a/tests/generic/311 +++ b/tests/generic/311 @@ -41,17 +41,14 @@ status=1 # failure is the default! _cleanup() { - # If dmsetup load fails then we need to make sure to do resume here - # otherwise the umount will hang - $DMSETUP_PROG resume flakey-test > /dev/null 2>&1 - $UMOUNT_PROG $SCRATCH_MNT > /dev/null 2>&1 - $DMSETUP_PROG remove flakey-test > /dev/null 2>&1 + _cleanup...

...VTarget.pm +++ b/lib/Sys/VirtV2V/Connection/RHEVTarget.pm @@ -243,7 +243,6 @@ sub DESTROY package Sys::VirtV2V::Connection::RHEVTarget::Vol; -use File::Path qw(remove_tree); use File::Spec::Functions; use File::Temp qw(tempdir); use POSIX; @@ -373,6 +372,41 @@ sub _move_vols $class->_cleanup(); } +# We used to use remove_tree from File::Path here. Unfortunately it does +# something unexpected involving chdir which means it will fail bizarrely if the +# current directory (not the target directory) is not readable by the current +# user. +sub _remove_tree +{ + my $dir = shift; + +...

...0 0 180 1 drop_writes" + $DMSETUP_PROG create flakey-test --table "$FLAKEY_TABLE" || \ + _fatal "failed to create flakey device" +} + +_mount_flakey() +{ + mount -t $FSTYP $MOUNT_OPTIONS $FLAKEY_DEV $SCRATCH_MNT +} + +_unmount_flakey() +{ + $UMOUNT_PROG $SCRATCH_MNT +} + +_cleanup_flakey() +{ + # If dmsetup load fails then we need to make sure to do resume here + # otherwise the umount will hang + $DMSETUP_PROG resume flakey-test > /dev/null 2>&1 + $UMOUNT_PROG $SCRATCH_MNT > /dev/null 2>&1 + $DMSETUP_PROG remove flakey-test > /dev/null 2>&1 +}...

...it passes now. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- tests/btrfs/307 | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/btrfs/307 b/tests/btrfs/307 index 87314c6..15157b3 100644 --- a/tests/btrfs/307 +++ b/tests/btrfs/307 @@ -35,6 +35,7 @@ _cleanup() { cd / rm -f $tmp.* + umount $SCRATCH_MNT } # get standard environment, filters and checks -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.k...

Hello, quoted patch free's cipher_data malloc'd in calls to EVP_CipherInit() in ssh1_3des_init(), at least linked with openssl >= 0.9.7. It does not appear to me (superficial scan) that there is any harm in calling the _cleanup routine with earlier openssl. fwiw :laird --- openssh-3.7.1p2/cipher-3des1.c Tue Sep 23 05:24:21 2003 +++ src37m/cipher-3des1.c Mon Dec 15 08:26:30 2003 @@ -126,6 +126,11 @@ struct ssh1_3des_ctx *c; if ((c = EVP_CIPHER_CTX_get_app_data(ctx)) != NULL) { +#ifndef SSH_O...

...V2V/Target/RHEV.pm | 15 ++++++++++++--- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/lib/Sys/VirtV2V/Target/RHEV.pm b/lib/Sys/VirtV2V/Target/RHEV.pm index 295c19d..c9add0c 100644 --- a/lib/Sys/VirtV2V/Target/RHEV.pm +++ b/lib/Sys/VirtV2V/Target/RHEV.pm @@ -390,9 +390,18 @@ sub _cleanup return unless (defined($tmpdir)); - rmtree($tmpdir) or warn(user_message(__x("Unable to remove temporary ". - "directory {dir}", - dir => $tmpdir))); + eval { + rmtree(...

...are Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + umount $SCRATCH_MNT + rm -rf $TESTDIR1 + rm -rf $TESTDIR2 + btrfs subvolume delete $SUBVOL1 >> $seqres.full + btrfs subvolume delete $SUBVOL2 >> $seqres.full + cd / + rm -f $tmp.* +} + +# get standard environment, f...

Cleanup was not happening properly if a migration to RHEV was killed prematurely with a Ctrl-C. Firstly, the SIGINT and SIGQUIT handlers were not being registered early enough in virt-v2v.pl. Secondly, if Ctrl-C killed the guestfs qemu process first it would deliver a SIGPIPE to v2v, which caused an unclean shutdown without cleanup. Fixes RHBZ#596015 --- v2v/virt-v2v.pl | 17 ++++++++++++++---

...2016 at 12:51 PM, Lukas Wunner <lukas at wunner.de> wrote: > > > On Tue, May 24, 2016 at 11:30:42PM +0200, Daniel Vetter wrote: > > >> On Tue, May 24, 2016 at 06:03:27PM +0200, Lukas Wunner wrote: > > >> > When a drm_crtc structure is destroyed with drm_crtc_cleanup(), the DRM > > >> > core does not turn off the crtc first and neither do the drivers. With > > >> > nouveau, radeon and amdgpu, this causes a runtime pm ref to be leaked on > > >> > driver unload if at least one crtc was enabled. > > >> >...

On btrfs, do the following ------------------ # su user1 # cd btrfs-part/ # touch aaa # getfacl aaa # file: aaa # owner: user1 # group: user1 user::rw- group::rw- other::r-- # su user2 # cd btrfs-part/ # setfacl -m u::rwx aaa # getfacl aaa # file: aaa # owner: user1 # group: user1 user::rwx <- successed to setfacl group::rw- other::r-- ------------------ but we

...Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + rm -f $tmp.* +} + +trap "_cleanup ; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs btrfs +_supported_os Linux +_require_scratch + +_scratch_mkfs > /dev/null 2>&1...

...lt;lukas at wunner.de> wrote: > > > > > On Tue, May 24, 2016 at 11:30:42PM +0200, Daniel Vetter wrote: > > > > > > On Tue, May 24, 2016 at 06:03:27PM +0200, Lukas Wunner wrote: > > > > > > > When a drm_crtc structure is destroyed with drm_crtc_cleanup(), the DRM > > > > > > > core does not turn off the crtc first and neither do the drivers. With > > > > > > > nouveau, radeon and amdgpu, this causes a runtime pm ref to be leaked on > > > > > > > driver unload if at least one crtc was...

...Lukas Wunner <lukas at wunner.de> wrote: > > > > On Tue, May 24, 2016 at 11:30:42PM +0200, Daniel Vetter wrote: > > > > > On Tue, May 24, 2016 at 06:03:27PM +0200, Lukas Wunner wrote: > > > > > > When a drm_crtc structure is destroyed with drm_crtc_cleanup(), the DRM > > > > > > core does not turn off the crtc first and neither do the drivers. With > > > > > > nouveau, radeon and amdgpu, this causes a runtime pm ref to be leaked on > > > > > > driver unload if at least one crtc was enabled. > &...

...unk. > It's only needed in the balloon page case. > For the unused page case, we don't need it, since the free > page blocks are already chunks. > > > OK as far as it goes but you need much better isolation for it. > > Build a data structure with APIs such as _init, _cleanup, _add, _clear, > > _find_first, _find_next. > > Completely unrelated to pages, it just maintains bits. > > Then use it here. > > > > > > > static int oom_pages = OOM_VBALLOON_DEFAULT_PAGES; > > > module_param(oom_pages, int, S_IRUSR | S_IWUSR);...

...unk. > It's only needed in the balloon page case. > For the unused page case, we don't need it, since the free > page blocks are already chunks. > > > OK as far as it goes but you need much better isolation for it. > > Build a data structure with APIs such as _init, _cleanup, _add, _clear, > > _find_first, _find_next. > > Completely unrelated to pages, it just maintains bits. > > Then use it here. > > > > > > > static int oom_pages = OOM_VBALLOON_DEFAULT_PAGES; > > > module_param(oom_pages, int, S_IRUSR | S_IWUSR);...

...; > Suggested-by: Michael S. Tsirkin <mst at redhat.com> So we don't need the bitmap to talk to host, it is just a data structure we chose to maintain lists of pages, right? OK as far as it goes but you need much better isolation for it. Build a data structure with APIs such as _init, _cleanup, _add, _clear, _find_first, _find_next. Completely unrelated to pages, it just maintains bits. Then use it here. > --- > drivers/virtio/virtio_balloon.c | 384 +++++++++++++++++++++++++++++++++--- > include/uapi/linux/virtio_balloon.h | 13 ++ > 2 files changed, 374 insertions(+...

...; > Suggested-by: Michael S. Tsirkin <mst at redhat.com> So we don't need the bitmap to talk to host, it is just a data structure we chose to maintain lists of pages, right? OK as far as it goes but you need much better isolation for it. Build a data structure with APIs such as _init, _cleanup, _add, _clear, _find_first, _find_next. Completely unrelated to pages, it just maintains bits. Then use it here. > --- > drivers/virtio/virtio_balloon.c | 384 +++++++++++++++++++++++++++++++++--- > include/uapi/linux/virtio_balloon.h | 13 ++ > 2 files changed, 374 insertions(+...

...are Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + umount $SCRATCH_MNT + rm -rf $TESTDIR1 + rm -rf $TESTDIR2 + btrfs subvolume delete $SUBVOL1 >> $seqres.full + btrfs subvolume delete $SUBVOL2 >> $seqres.full + cd / + rm -f $tmp.* +} + +# get standard environment, f...