search for: _callback

...et+0x6a) > [0xf67c18fe] > #14 > /usr/local/samba/lib/libsmbconf.so.0(idmap_cache_set_sid2unixid+0x1bd) > [0xf67c6774] > #15 winbindd(wb_sids2xids_recv+0x1f1) [0xf7740cef] > #16 winbindd [0xf7749e7f] > #17 > /usr/local/samba/lib/private/libtevent.so.0(_tevent_req_notify > _callback+0x5c) > [0xf72691df] > #18 /usr/local/samba/lib/private/libtevent.so.0 [0xf7269298] > #19 /usr/local/samba/lib/private/libtevent.so.0(_tevent_req_done+0x20) > [0xf72692be] > #20 winbindd [0xf7740826] > #21 > /usr/local/samba/lib/private/libtevent.so.0(_tevent_req_notify > _c...

On 8/13/19 10:37 AM, Richard W.M. Jones wrote: > The original nbd_aio_* (non-callback) functions are removed and > replaced with the renamed callback variants. > > This is a simple mechanical change to the API: > > (1) Any existing call to nbd_aio_*_callback can simply be renamed to > nbd_aio_* > > (2) Any existing call to nbd_aio_* must have two extra NULL parameters > added before the final flags parameter. > > In non-C languages, only change (1) is required. It is still possible to compile for 0.9.6 and this patch simult...

On Mon, Aug 12, 2019 at 11:00:01PM +0100, Richard W.M. Jones wrote: > On Mon, Aug 12, 2019 at 01:53:56PM -0500, Eric Blake wrote: > > We then have the design question of whether to make an OClosure type, > > where C has two functions nbd_aio_pread and nbd_aio_pread_callback for > > convenience, but where other languages have only a single nbd.aio_pread > > where the callback parameter is optional (the Closure type for > > pread_structured chunk and for block_status extent will still be > > mandatory; it is only the completion callback that is c...

....so.0(+0x2ac58) > [0x7fdc30b37c58] > ?? #15 /usr/local/samba/lib/libdcerpc-server.so.0(+0x2bcda) > [0x7fdc30b38cda] > ?? #16 /usr/local/samba/lib/libdcerpc-server.so.0(+0x2d6fc) > [0x7fdc30b3a6fc] > ?? #17 > /usr/local/samba/lib/private/libtevent.so.0(_tevent_req_notify > _callback+0x6a) > [0x7fdc487ff7d2] > ?? #18 /usr/local/samba/lib/private/libtevent.so.0(+0x8933) > [0x7fdc487ff933] > ?? #19 > /usr/local/samba/lib/private/libtevent.so.0(_tevent_req_done+0x25) > [0x7fdc487ff960] > ?? #20 /usr/local/samba/lib/libdcerpc-binding.so.0(+0xea94) > [0x7fd...

It''s been a few days since I posted my last two emails (of which, no one replied to) so I''ve gone ahead and coded a working slider class as well as a ''resizeable'' class that allows a user to drag and resize the element. I also linked these two together as I want to have slider behavior that can resize the resizeable element. The end result is both the

...e that the socket is ready for reading/writing). I wonder if we should rename something here. My suggestions are either of the following or both: (I) Rename nbd_notify_read / nbd_notify_write to nbd_ready_to_read / nbd_ready_to_write. (II) Rename nbd_aio_<CMD>_notify to nbd_aio_<CMD>_callback. What do you think? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linu...

...th a normal stylesheet which has white-space:pre; set on pre/code blocks, you'll see an empty line after "This is Code". In my eyes that is wrong. It's pretty easy to prevent though, you'll just have to remove the newline before `</code></pre>` in _DoCodeBlocks(_callback). -- Milian Wolff http://milianw.de

...find information on this topic. I would like to add custom pragma's that generate particular LLVM IR. Here is an example: int a, b; /* ... */ #pragma mypragma shared(a, b) { a = b; b++; } would result in this (pseudo) LLVM IR: %1 alloca i32 %2 alloca i32 ... call void @start_callback () %3 call i32 @check_callback ( i32 %1 ) %4 call i32 @check_callback ( i32 %2 ) ... call void @end_callback () ... Note: All *_callback functions are implemented in a third party library. I guess that is it quite close to what was implemented for the OpenMP support, but I need something simple...

...?? #14 /usr/local/samba/lib/libdcerpc-server.so.0(+0x2ac58) [0x7fdc30b37c58] ?? #15 /usr/local/samba/lib/libdcerpc-server.so.0(+0x2bcda) [0x7fdc30b38cda] ?? #16 /usr/local/samba/lib/libdcerpc-server.so.0(+0x2d6fc) [0x7fdc30b3a6fc] ?? #17 /usr/local/samba/lib/private/libtevent.so.0(_tevent_req_notify_callback+0x6a) [0x7fdc487ff7d2] ?? #18 /usr/local/samba/lib/private/libtevent.so.0(+0x8933) [0x7fdc487ff933] ?? #19 /usr/local/samba/lib/private/libtevent.so.0(_tevent_req_done+0x25) [0x7fdc487ff960] ?? #20 /usr/local/samba/lib/libdcerpc-binding.so.0(+0xea94) [0x7fdc44c12a94] ?? #21 /usr/local/samba/lib/pri...

...e breaks API, requiring a number of changes: - Use symbolic constants instead of magic numbers/open-coded strings (well, the string for "base:allocation" was present before this libnbd bump) - Change callbacks to drop the valid_flag parameter - Add _is to nbd_read_only call - Drop the _callback suffix on nbd_aio_FOO calls - Add a struct for managing callback/user_data at once Signed-off-by: Eric Blake <eblake@redhat.com> --- Pushing, since we're releasing libnbd 0.9.8 today configure.ac | 4 +-- plugins/nbd/nbd.c | 85 +++++++++++++++++++++-------------------------- RE...

This applies on top of the OClosure v2 series posted a few minutes ago. Rich.

The original nbd_aio_* (non-callback) functions are removed and replaced with the renamed callback variants. This is a simple mechanical change to the API: (1) Any existing call to nbd_aio_*_callback can simply be renamed to nbd_aio_* (2) Any existing call to nbd_aio_* must have two extra NULL parameters added before the final flags parameter. In non-C languages, only change (1) is required. --- docs/libnbd.pod | 9 +- examples/batched-read-write.c...

On 8/12/19 1:13 PM, Richard W.M. Jones wrote: > On Mon, Aug 12, 2019 at 11:29:10AM -0500, Eric Blake wrote: >> On 8/12/19 11:08 AM, Richard W.M. Jones wrote: >>> + typedef void (*nbd_free_callback) (void *ptr, void *user_data); >>> + int nbd_add_free_callback (struct nbd_handle *h, >>> + void *ptr, >>> + nbd_free_callback cb, >>> + void *user_data); >> >> Do we wan...

On Mon, Aug 12, 2019 at 01:53:56PM -0500, Eric Blake wrote: > We then have the design question of whether to make an OClosure type, > where C has two functions nbd_aio_pread and nbd_aio_pread_callback for > convenience, but where other languages have only a single nbd.aio_pread > where the callback parameter is optional (the Closure type for > pread_structured chunk and for block_status extent will still be > mandatory; it is only the completion callback that is currently causing &gt...

...er of changes: > - Use symbolic constants instead of magic numbers/open-coded strings > (well, the string for "base:allocation" was present before this > libnbd bump) > - Change callbacks to drop the valid_flag parameter > - Add _is to nbd_read_only call > - Drop the _callback suffix on nbd_aio_FOO calls > - Add a struct for managing callback/user_data at once Seems reasonable. > @@ -160,11 +160,12 @@ nbdplug_config (const char *key, const char *value) > if (strcasecmp (value, "require") == 0 || > strcasecmp (value, "required&qu...

...d state machine may not notice the error until much later). I don't think nbd_read_to_error() sounds good, so keeping the name nbd_notify_FOO for notifying the state machine about a particular change in the fd seems best. > > (II) Rename nbd_aio_<CMD>_notify to nbd_aio_<CMD>_callback. which leaves this as our only sane option to rename. The bikeshedding rename sounds fine to me; it's a fairly simple change; it does bump API/ABI and will require another release, but we're still at the point where we can do it. I've also noticed that we have 'struct nbd_handle...

...e: > The definition of functions that take a callback is changed so that > the callback and user_data are combined into a single structure, eg: > > int64_t nbd_aio_pread (struct nbd_handle *h, > void *buf, size_t count, uint64_t offset, > - int (*completion_callback) (/*..*/), void *user_data, > + nbd_completion_callback completion_callback, > uint32_t flags); > > Several nbd_*_callback structures are defined. The one corresponding > to the example above is: > > typedef struct { > void *user_data; >...

...ated state (which means > + * that it first has a socket associated with it) we must initialize > + * and register the pollfd. > + */ > + if (!source->poll_registered && !nbd_aio_is_created (source->nbd)) { > + int fd; > + > + if (source->connecting_callback) { > + DEBUG (source, "calling connecting_callback"); > + source->connecting_callback (source); > + } If I understand nbd_aio_connect_tcp properly, there are cases where we end up trying several options presented from getaddrinfo() with a possible reset back to S...

...command completes, C<callback> > > will be invoked as described in L<libnbd(3)/Completion callbacks>. > > + > > Do we need wording anywhere (probably in the .pod, so we only state it > once) that mentions that the callback routine is not invoked if > nbd_aio_FOO_callback returns -1? I guess it's implicit from the fact that returning -1 indicates an error. In fact the relationship ought to be stronger than that - the command should run if and only if nbd_aio_FOO_callback returns >= 0. (That's not actually true at the moment because an error can happen...

...functions that take a callback is changed so that > > the callback and user_data are combined into a single structure, eg: > > > > int64_t nbd_aio_pread (struct nbd_handle *h, > > void *buf, size_t count, uint64_t offset, > > - int (*completion_callback) (/*..*/), void *user_data, > > + nbd_completion_callback completion_callback, > > uint32_t flags); > > > > Several nbd_*_callback structures are defined. The one corresponding > > to the example above is: > > > > typedef struct {...