search for: __vmalloc_node_range

...;] __warn+0xd8/0x100 > [ 1.970742] [<ffffffff81087b0d>] warn_slowpath_null+0x1d/0x20 > [ 1.970748] [<ffffffff811c0781>] vmap_page_range_noflush+0x2c1/0x350 > [ 1.970758] [<ffffffff811c083e>] map_vm_area+0x2e/0x40 > [ 1.970765] [<ffffffff811c1590>] __vmalloc_node_range+0x170/0x270 > [ 1.970774] [<ffffffff810fe754>] ? module_alloc_update_bounds+0x14/0x70 > [ 1.970781] [<ffffffff810fe754>] ? module_alloc_update_bounds+0x14/0x70 > [ 1.970792] [<ffffffff8105f143>] module_alloc+0x73/0xd0 > [ 1.970798] [<ffffffff810fe754...

...; [ 1.970742] [<ffffffff81087b0d>] warn_slowpath_null+0x1d/0x20 >>> [ 1.970748] [<ffffffff811c0781>] vmap_page_range_noflush+0x2c1/0x350 >>> [ 1.970758] [<ffffffff811c083e>] map_vm_area+0x2e/0x40 >>> [ 1.970765] [<ffffffff811c1590>] __vmalloc_node_range+0x170/0x270 >>> [ 1.970774] [<ffffffff810fe754>] ? module_alloc_update_bounds+0x14/0x70 >>> [ 1.970781] [<ffffffff810fe754>] ? module_alloc_update_bounds+0x14/0x70 >>> [ 1.970792] [<ffffffff8105f143>] module_alloc+0x73/0xd0 >>> [...

A recently created and fully functional CentOS 7.3 VM fails to boot after applying CR updates: ... ;-1f1;-1f CentOS Linux 7 (Core)1;-1f1;-1f CentOS Linux 7 (Core)1;-1f1;-1f CentOS Linux 7 (Core)1;-1f1;-1f CentOS Linux 7 (Core)1;-1f1;-1f CentOS Linux 7 (Core)1;-1f1;-1f CentOS Linux 7 (Core)1;-1f1;-1f CentOS Linux 7 (Core)1;-1f1;-1f CentOS Linux 7 (Core)1;-1f1;-1f CentOS Linux 7 (Core)1;-1f1;-1f

...;ffffffff810879c8>] __warn+0xd8/0x100 [ 1.970742] [<ffffffff81087b0d>] warn_slowpath_null+0x1d/0x20 [ 1.970748] [<ffffffff811c0781>] vmap_page_range_noflush+0x2c1/0x350 [ 1.970758] [<ffffffff811c083e>] map_vm_area+0x2e/0x40 [ 1.970765] [<ffffffff811c1590>] __vmalloc_node_range+0x170/0x270 [ 1.970774] [<ffffffff810fe754>] ? module_alloc_update_bounds+0x14/0x70 [ 1.970781] [<ffffffff810fe754>] ? module_alloc_update_bounds+0x14/0x70 [ 1.970792] [<ffffffff8105f143>] module_alloc+0x73/0xd0 [ 1.970798] [<ffffffff810fe754>] ? module_alloc...

...x100 >> [ 1.970742] [<ffffffff81087b0d>] warn_slowpath_null+0x1d/0x20 >> [ 1.970748] [<ffffffff811c0781>] vmap_page_range_noflush+0x2c1/0x350 >> [ 1.970758] [<ffffffff811c083e>] map_vm_area+0x2e/0x40 >> [ 1.970765] [<ffffffff811c1590>] __vmalloc_node_range+0x170/0x270 >> [ 1.970774] [<ffffffff810fe754>] ? module_alloc_update_bounds+0x14/0x70 >> [ 1.970781] [<ffffffff810fe754>] ? module_alloc_update_bounds+0x14/0x70 >> [ 1.970792] [<ffffffff8105f143>] module_alloc+0x73/0xd0 >> [ 1.970798] [<...

...742] [<ffffffff81087b0d>] warn_slowpath_null+0x1d/0x20 >>>> [ 1.970748] [<ffffffff811c0781>] vmap_page_range_noflush+0x2c1/0x350 >>>> [ 1.970758] [<ffffffff811c083e>] map_vm_area+0x2e/0x40 >>>> [ 1.970765] [<ffffffff811c1590>] __vmalloc_node_range+0x170/0x270 >>>> [ 1.970774] [<ffffffff810fe754>] ? module_alloc_update_bounds+0x14/0x70 >>>> [ 1.970781] [<ffffffff810fe754>] ? module_alloc_update_bounds+0x14/0x70 >>>> [ 1.970792] [<ffffffff8105f143>] module_alloc+0x73/0xd0 >&g...

...rpenter <dan.carpenter at oracle.com> > > Ouch. Thanks a lot for noticing this, and it's a good thing > you did before Linus merged it. > I'll squash this into Igor's patch and redo my pull request. > Is this function needed at all ? e.g. I followed vzalloc() to __vmalloc_node_range() a check for size==0 seems to be done there. re, wh >> >> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c >> index a9fe859..99d613b 100644 >> --- a/drivers/vhost/vhost.c >> +++ b/drivers/vhost/vhost.c >> @@ -686,7 +686,7 @@ static void *vhost_kvz...

...rpenter <dan.carpenter at oracle.com> > > Ouch. Thanks a lot for noticing this, and it's a good thing > you did before Linus merged it. > I'll squash this into Igor's patch and redo my pull request. > Is this function needed at all ? e.g. I followed vzalloc() to __vmalloc_node_range() a check for size==0 seems to be done there. re, wh >> >> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c >> index a9fe859..99d613b 100644 >> --- a/drivers/vhost/vhost.c >> +++ b/drivers/vhost/vhost.c >> @@ -686,7 +686,7 @@ static void *vhost_kvz...

...fffffff81087b0d>] warn_slowpath_null+0x1d/0x20 >>>>> [ 1.970748] [<ffffffff811c0781>] vmap_page_range_noflush+0x2c1/0x350 >>>>> [ 1.970758] [<ffffffff811c083e>] map_vm_area+0x2e/0x40 >>>>> [ 1.970765] [<ffffffff811c1590>] __vmalloc_node_range+0x170/0x270 >>>>> [ 1.970774] [<ffffffff810fe754>] ? module_alloc_update_bounds+0x14/0x70 >>>>> [ 1.970781] [<ffffffff810fe754>] ? module_alloc_update_bounds+0x14/0x70 >>>>> [ 1.970792] [<ffffffff8105f143>] module_alloc+0x73...

...t; > > > > Ouch. Thanks a lot for noticing this, and it's a good thing > > you did before Linus merged it. > > I'll squash this into Igor's patch and redo my pull request. > > > > Is this function needed at all ? > > e.g. I followed vzalloc() to __vmalloc_node_range() > > a check for size==0 seems to be done there. At least it looks like one could return the result of vzalloc directly? julia > > re, > wh > > > >> > >> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > >> index a9fe859..99d613b 10064...

There is only one caller for vhost_kvzalloc() and it expects NULL on allocation failure. Most people would probably expect that so let's change ERR_PTR(-ENOMEM) to NULL. Fixes: 4de7255f7d2b ('vhost: extend memory regions allocation to vmalloc') Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index

There is only one caller for vhost_kvzalloc() and it expects NULL on allocation failure. Most people would probably expect that so let's change ERR_PTR(-ENOMEM) to NULL. Fixes: 4de7255f7d2b ('vhost: extend memory regions allocation to vmalloc') Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index