search for: __sighandler_t

Kay Sievers wrote: > Hi, > this simple program compiled with klibc: > > #include <stdio.h> > int main(int argc, char* argv[]) > { > setenv("TESTENV", "happy", 1); > printf("TESTENV='%s'\n", getenv("TESTENV")); > } > > prints: > > ./env > TESTENV='(null)' > >

.../* Kernel defines SIGRTMAX as _NSIG, then keeps _NSIG + hidden under ifdefs... */ +#ifndef _NSIG +#undef SIGRTMIN +#undef SIGRTMAX +#endif + #include <klibc/archsignal.h> /* glibc seems to use sig_atomic_t as "int" pretty much on all architectures. @@ -67,6 +74,8 @@ __extern __sighandler_t __signal(int, __sighandler_t, int); __extern __sighandler_t sysv_signal(int, __sighandler_t); __extern __sighandler_t bsd_signal(int, __sighandler_t); +/* make sure classic code works */ +#define signal bsd_signal __extern int sigaction(int, const struct sigaction *, struct sigaction *); __exte...

Commit 8418552 ("[klibc] ia64: Fix shared build") missed this use of the GP register, although the code appears to have been dubious anyway, assuming the address of errno was the first thing pointed to by GP. --- usr/klibc/arch/ia64/vfork.S | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/usr/klibc/arch/ia64/vfork.S b/usr/klibc/arch/ia64/vfork.S index

...ged, 46 insertions(+), 2 deletions(-) diff --git a/usr/include/arch/ia64/klibc/archsignal.h b/usr/include/arch/ia64/klibc/archsignal.h index fbc961b..c52c41a 100644 --- a/usr/include/arch/ia64/klibc/archsignal.h +++ b/usr/include/arch/ia64/klibc/archsignal.h @@ -22,8 +22,9 @@ struct sigaction { __sighandler_t _sa_handler; void (*_sa_sigaction) (int, struct siginfo *, void *); } _u; - sigset_t sa_mask; int sa_flags; + int __pad0; + sigset_t sa_mask; }; #define sa_handler _u._sa_handler diff --git a/usr/klibc/sigaction.c b/usr/klibc/sigaction.c index 19a8a54..e4901ab 100644 --- a/usr/klibc...

hello, klibc/include/signal.h include asm/signal.h which prefixes the __sighandler_t definition with a __user annotation. __user not being defined previously leads to a compilation breakage. It's the only occurrence for now, so the following dirty work-around works here : add a "#define __user" at klibc/include/signal.h head. regards, -- christophe varoqui <ch...

...irtual/dmi/id' or '/sys/class/dmi/id' libvirtd: libxl_fork.c:350: sigchld_installhandler_core: Assertion `((void)"application must negotiate with libxl about SIGCHLD", !(sigchld_saved_action.sa_flags & 4) && (sigchld_saved_action.__sigaction_handler.sa_handler == ((__sighandler_t) 0) || sigchld_saved_action.__sigaction_handler.sa_handler == ((__sighandler_t) 1)))' failed. Aborted vmmachine ~ # VIRSH_DEBUG=0 virsh create xml create: file(optdata): xml libvirt: XML-RPC error : End of file while reading data: Input/output error error: Failed to create domain from xml erro...

...G) { + errno = EINVAL; + return -1; + } + + if (oact) { + old_entry = signal_descriptors[sig].entry; + } + + if (act && act->sa_handler != SIG_IGN && act->sa_handler != SIG_DFL) { + signal_descriptors[sig].entry = (uintptr_t)act->sa_handler; + act->sa_handler = + (__sighandler_t)(uintptr_t)&signal_descriptors[sig]; + } + + rv = ____rt_sigaction(sig, act, oact, size); + + if (oact && oact->sa_handler != SIG_IGN && + oact->sa_handler != SIG_DFL) { + oact->sa_handler = (__sighandler_t)old_entry; + } + + return rv; +}

...G) { + errno = EINVAL; + return -1; + } + + if (oact) { + old_entry = signal_descriptors[sig].entry; + } + + if (act && act->sa_handler != SIG_IGN && act->sa_handler != SIG_DFL) { + signal_descriptors[sig].entry = (uintptr_t)act->sa_handler; + act->sa_handler = + (__sighandler_t)(uintptr_t)&signal_descriptors[sig]; + } + + rv = ____rt_sigaction(sig, act, oact, size); + + if (oact && oact->sa_handler != SIG_IGN && + oact->sa_handler != SIG_DFL) { + oact->sa_handler = (__sighandler_t)old_entry; + } + + return rv; +}

...ed, 2 insertions(+), 2 deletions(-) diff --git a/usr/include/arch/ia64/klibc/archsignal.h b/usr/include/arch/ia64/klibc/archsignal.h index fbc961b4..7cfbf308 100644 --- a/usr/include/arch/ia64/klibc/archsignal.h +++ b/usr/include/arch/ia64/klibc/archsignal.h @@ -22,8 +22,8 @@ struct sigaction { __sighandler_t _sa_handler; void (*_sa_sigaction) (int, struct siginfo *, void *); } _u; - sigset_t sa_mask; - int sa_flags; + unsigned long sa_flags; + sigset_t sa_mask; }; #define sa_handler _u._sa_handler

...ed, 2 insertions(+), 2 deletions(-) diff --git a/usr/include/arch/ia64/klibc/archsignal.h b/usr/include/arch/ia64/klibc/archsignal.h index fbc961b4..7cfbf308 100644 --- a/usr/include/arch/ia64/klibc/archsignal.h +++ b/usr/include/arch/ia64/klibc/archsignal.h @@ -22,8 +22,8 @@ struct sigaction { __sighandler_t _sa_handler; void (*_sa_sigaction) (int, struct siginfo *, void *); } _u; - sigset_t sa_mask; - int sa_flags; + unsigned long sa_flags; + sigset_t sa_mask; }; #define sa_handler _u._sa_handler

...act, oact, size); + if (rv) + signal_descriptors[sig].entry = old_entry; + + /* Restore signal mask */ + (void)sigprocmask(SIG_SETMASK, &old_signal_mask, NULL); + if (oact && oact->sa_handler != SIG_IGN && oact->sa_handler != SIG_DFL) { oact->sa_handler = (__sighandler_t)old_entry;

...ed, 2 insertions(+), 2 deletions(-) diff --git a/usr/include/arch/ia64/klibc/archsignal.h b/usr/include/arch/ia64/klibc/archsignal.h index fbc961b4..7cfbf308 100644 --- a/usr/include/arch/ia64/klibc/archsignal.h +++ b/usr/include/arch/ia64/klibc/archsignal.h @@ -22,8 +22,8 @@ struct sigaction { __sighandler_t _sa_handler; void (*_sa_sigaction) (int, struct siginfo *, void *); } _u; - sigset_t sa_mask; - int sa_flags; + unsigned long sa_flags; + sigset_t sa_mask; }; #define sa_handler _u._sa_handler

...act, oact, size); + if (rv) + signal_descriptors[sig].entry = old_entry; + + /* Restore signal mask */ + (void)sigprocmask(SIG_SETMASK, &old_signal_mask, NULL); + if (oact && oact->sa_handler != SIG_IGN && oact->sa_handler != SIG_DFL) { oact->sa_handler = (__sighandler_t)old_entry;

...0 +#define SA_SIGINFO 0x00000040 + +#define SA_ONESHOT SA_RESETHAND +#define SA_NOMASK SA_NODEFER + +#define MINSIGSTKSZ 4096 +#define SIGSTKSZ 16384 + +#define SIG_BLOCK 1 +#define SIG_UNBLOCK 2 +#define SIG_SETMASK 3 + +#include <asm-generic/signal-defs.h> + +struct sigaction { + union { + __sighandler_t sa_handler; + void (*sa_sigaction)(int, struct siginfo *, void *); + }; + unsigned long sa_flags; + sigset_t sa_mask; +}; #endif

...ESHOT SA_RESETHAND + + +/* + * sigaltstack controls + */ +#define SS_ONSTACK 1 +#define SS_DISABLE 2 + +#define MINSIGSTKSZ 2048 +#define SIGSTKSZ 8192 + +#include <asm-generic/signal-defs.h> + +/* This uses gcc anonymous union support... */ +struct siginfo; + +struct sigaction { + union { + __sighandler_t sa_handler; + void (*sa_sigaction)(int, struct siginfo *, void *); + }; + unsigned long sa_flags; + __sigrestore_t sa_restorer; + sigset_t sa_mask; +}; #endif -- 1.6.5.rc2

.../signal.h:41: error: expected constructor, destructor, or type conversion before ‘typedef’ In file included from project.h:40, from files.cpp:20: /usr/include/signal.h:75: error: expected constructor, destructor, or type conversion before ‘typedef’ /usr/include/signal.h:80: error: ‘__sighandler_t’ does not name a type /usr/include/signal.h:83: error: ‘__sighandler_t’ does not name a type /usr/include/signal.h:92: error: expected constructor, destructor, or type conversion before ‘extern’ /usr/include/signal.h:109: error: expected constructor, destructor, or type conversion before ‘extern’ /...

....h + * + * Architecture-specific signal definitions + * + */ + +#ifndef _KLIBC_ARCHSIGNAL_H +#define _KLIBC_ARCHSIGNAL_H + +#include <asm/signal.h> +#define _NSIG 64 +#define _NSIG_SZ (_NSIG / LONG_BIT) + +typedef struct { + unsigned long sig[_NSIG_SZ]; +} sigset_t; + +struct sigaction { + __sighandler_t sa_handler; + unsigned long sa_flags; + sigset_t sa_mask; +}; + +#endif diff --git a/usr/include/arch/parisc/klibc/archstat.h b/usr/include/arch/parisc/klibc/archstat.h new file mode 100644 index 0000000..0b8ef8d --- /dev/null +++ b/usr/include/arch/parisc/klibc/archstat.h @@ -0,0 +1,29 @@ +#ifndef...

...ine SA_NOMASK SA_NODEFER +#define SA_ONESHOT SA_RESETHAND + +/* + * sigaltstack controls + */ +#define SS_ONSTACK 1 +#define SS_DISABLE 2 + +#define MINSIGSTKSZ 2048 +#define SIGSTKSZ 8192 + +#include <asm-generic/signal.h> + +struct siginfo; + +struct sigaction { + union { + __sighandler_t sa_handler; + void (*sa_sigaction)(int, struct siginfo *, void *); + }; + unsigned long sa_flags; + __sigrestore_t sa_restorer; + sigset_t sa_mask; +}; + +#endif diff --git a/usr/include/arch/avr32/klibc/archstat.h b/usr/include/arch/avr32/klibc/archstat.h new file mode 100644 index 0000000....

...ons. + * + */ + +#ifndef _KLIBC_ARCHSIGNAL_H +#define _KLIBC_ARCHSIGNAL_H + +#include <asm/signal.h> +#define _NSIG 64 +#define _NSIG_BPW 64 +#define _NSIG_WORDS (_NSIG / _NSIG_BPW) + +typedef struct { + unsigned long sig[_NSIG_WORDS]; +} sigset_t; + +struct sigaction { + union { + __sighandler_t _sa_handler; + void (*_sa_sigaction) (int, struct siginfo *, void *); + } _u; + sigset_t sa_mask; + int sa_flags; +}; + +#define sa_handler _u._sa_handler +#define sa_sigaction _u._sa_sigaction + +#endif diff --git a/usr/include/arch/ia64/klibc/archstat.h b/usr/include/arch/ia64/klibc/arch...

...ne SA_RESTORER 0x04000000 + +/* + * sigaltstack controls + */ +#define SS_ONSTACK 1 +#define SS_DISABLE 2 + +#define MINSIGSTKSZ 2048 +#define SIGSTKSZ 8192 + +#include <asm-generic/signal.h> + +/* This uses gcc anonymous union support... */ +struct siginfo; + +struct sigaction { + union { + __sighandler_t sa_handler; + void (*sa_sigaction)(int, struct siginfo *, void *); + }; + unsigned long sa_flags; + __sigrestore_t sa_restorer; + sigset_t sa_mask; +}; + +#endif diff --git a/usr/include/arch/i386/klibc/archstat.h b/usr/include/arch/i386/klibc/archstat.h new file mode 100644 index 0000000..c00f95...