search for: __pm_runtime_resume

...6.593382] __rpm_callback+0xc6/0x210 [ 56.593383] ? pci_restore_standard_config+0x40/0x40 [ 56.593384] rpm_callback+0x24/0x80 [ 56.593385] ? pci_restore_standard_config+0x40/0x40 [ 56.593385] rpm_resume+0x47d/0x680 [ 56.593400] ? i915_gem_timeline_init+0xe/0x10 [i915] [ 56.593401] __pm_runtime_resume+0x4f/0x80 [ 56.593415] nouveau_drm_open+0x3b/0x1b0 [nouveau] [ 56.593417] ? security_capable+0x48/0x60 [ 56.593423] drm_open+0x205/0x3f0 [drm] [ 56.593428] drm_stub_open+0xb6/0x110 [drm] [ 56.593429] chrdev_open+0xbf/0x1b0 [ 56.593431] do_dentry_open+0x1e4/0x310 [ 56.593432] ?...

...;ffffffffa001cd34>] drm_gem_object_handle_unreference_unlocked+0xe4/0x120 [drm] [<ffffffffa001ce2a>] drm_gem_handle_delete+0xba/0x110 [drm] [<ffffffffa001d495>] drm_gem_close_ioctl+0x25/0x30 [drm] [<ffffffffa001df0c>] drm_ioctl+0x1ec/0x660 [drm] [<ffffffff8148e4b2>] ? __pm_runtime_resume+0x32/0x60 [<ffffffff817102fd>] ? _raw_spin_unlock_irqrestore+0x5d/0x70 [<ffffffff810df15d>] ? trace_hardirqs_on_caller+0xfd/0x1c0 [<ffffffff810df22d>] ? trace_hardirqs_on+0xd/0x10 [<ffffffff817102e2>] ? _raw_spin_unlock_irqrestore+0x42/0x70 [<ffffffffa0290bd4>] no...

...kmem_cache_alloc+0x1f0/0x2d0 [ 10.035790] nouveau_drm_load+0x71/0xec0 [nouveau] [ 10.040735] drm_dev_register+0x1b4/0x330 [ 10.044872] ? pci_enable_device_flags+0x155/0x200 [ 10.049806] drm_get_pci_dev+0xde/0x2c0 [ 10.053874] nouveau_drm_probe+0x1b9/0x240 [nouveau] [ 10.058986] ? __pm_runtime_resume+0x68/0xb0 [ 10.063409] local_pci_probe+0x5e/0xf0 [ 10.067300] work_for_cpu_fn+0x10/0x30 [ 10.071183] process_one_work+0x21a/0x670 [ 10.075325] worker_thread+0x256/0x500 [ 10.079208] ? manage_workers+0x1e0/0x1e0 [ 10.083362] kthread+0x169/0x220 [ 10.086730] ? kthread_create_work...

...> [ 861.487044] Workqueue: events nouveau_display_hpd_work [nouveau] > [ 861.487737] Call Trace: > [ 861.488394] __schedule+0x322/0xaf0 > [ 861.489070] schedule+0x33/0x90 > [ 861.489744] rpm_resume+0x19c/0x850 > [ 861.490392] ? finish_wait+0x90/0x90 > [ 861.491068] __pm_runtime_resume+0x4e/0x90 > [ 861.491753] nouveau_display_hpd_work+0x22/0x60 [nouveau] > [ 861.492416] process_one_work+0x231/0x620 > [ 861.493068] worker_thread+0x44/0x3a0 > [ 861.493722] kthread+0x12b/0x150 > [ 861.494342] ? wq_pool_ids_show+0x140/0x140 > [ 861.494991] ? kthread_cre...

This fixes some nasty issues I found in nouveau that were being caused looping through connectors using racy legacy methods, along with some caused by making incorrect assumptions about the drm_connector structs in nouveau's connector list. Most of these memory corruption issues could be reproduced by using an MST hub with nouveau. Cc: Karol Herbst <karolherbst at gmail.com> Cc: stable

...287] ? pci_restore_standard_config+0x70/0x70 [ 201.039291] ? pci_restore_standard_config+0x70/0x70 [ 201.039296] rpm_callback+0x175/0x210 [ 201.039300] ? pci_restore_standard_config+0x70/0x70 [ 201.039305] rpm_resume+0xcc3/0x18a0 [ 201.039312] ? rpm_callback+0x210/0x210 [ 201.039317] ? __pm_runtime_resume+0x9e/0x100 [ 201.039322] ? kasan_check_write+0x14/0x20 [ 201.039326] ? do_raw_spin_lock+0xc2/0x1c0 [ 201.039333] __pm_runtime_resume+0xac/0x100 [ 201.039374] nouveau_display_hpd_work+0x67/0x1f0 [nouveau] [ 201.039380] process_one_work+0x7a0/0x14d0 [ 201.039388] ? cancel_delayed_work_syn...

...D 0 61 2 0x80000000 [ 861.487044] Workqueue: events nouveau_display_hpd_work [nouveau] [ 861.487737] Call Trace: [ 861.488394] __schedule+0x322/0xaf0 [ 861.489070] schedule+0x33/0x90 [ 861.489744] rpm_resume+0x19c/0x850 [ 861.490392] ? finish_wait+0x90/0x90 [ 861.491068] __pm_runtime_resume+0x4e/0x90 [ 861.491753] nouveau_display_hpd_work+0x22/0x60 [nouveau] [ 861.492416] process_one_work+0x231/0x620 [ 861.493068] worker_thread+0x44/0x3a0 [ 861.493722] kthread+0x12b/0x150 [ 861.494342] ? wq_pool_ids_show+0x140/0x140 [ 861.494991] ? kthread_create_worker_on_cpu+0x70/0x70 [...

...ce between that resume and the reboot? I think we do in fact resume PCI devices before shutdown. Here's the path I'm looking at: device_shutdown pm_runtime_get_noresume pm_runtime_barrier dev->bus->shutdown pci_device_shutdown pm_runtime_resume __pm_runtime_resume(dev, 0) rpm_resume(dev, 0) __update_runtime_status(dev, RPM_RESUMING) callback = RPM_GET_CALLBACK(dev, runtime_resume) rpm_callback(callback, dev) __rpm_callback pci_pm_runtime_resume drv-&gt...

...;] drm_gem_object_handle_unreference_unlocked+0xe4/0x120 [drm] > [<ffffffffa001ce2a>] drm_gem_handle_delete+0xba/0x110 [drm] > [<ffffffffa001d495>] drm_gem_close_ioctl+0x25/0x30 [drm] > [<ffffffffa001df0c>] drm_ioctl+0x1ec/0x660 [drm] > [<ffffffff8148e4b2>] ? __pm_runtime_resume+0x32/0x60 > [<ffffffff817102fd>] ? _raw_spin_unlock_irqrestore+0x5d/0x70 > [<ffffffff810df15d>] ? trace_hardirqs_on_caller+0xfd/0x1c0 > [<ffffffff810df22d>] ? trace_hardirqs_on+0xd/0x10 > [<ffffffff817102e2>] ? _raw_spin_unlock_irqrestore+0x42/0x70 > [&lt...

This fixes some nasty issues I found in nouveau that were being caused looping through connectors using racy legacy methods, along with some caused by making incorrect assumptions about the drm_connector structs in nouveau's connector list. Most of these memory corruption issues could be reproduced by using an MST hub with nouveau. Next version of

...) nouveau_connector_hotplug() nouveau_display_hpd_work() nv17_tv_set_property() Stack trace for posterity: INFO: task kworker/0:1:58 blocked for more than 120 seconds. Workqueue: events output_poll_execute [drm_kms_helper] Call Trace: schedule+0x28/0x80 rpm_resume+0x107/0x6e0 __pm_runtime_resume+0x47/0x70 nouveau_connector_detect+0x7e/0x4a0 [nouveau] nouveau_connector_detect_lvds+0x132/0x180 [nouveau] drm_helper_probe_detect_ctx+0x85/0xd0 [drm_kms_helper] output_poll_execute+0x11e/0x1c0 [drm_kms_helper] process_one_work+0x184/0x380 worker_thread+0x2e/0x390 INFO: task k...

...a new bug > report for it. As previously, no (real) badness by just modprobing nouveau. Starting Xorg on top of it (though while having other Xorg running on radeon, but from local linux console) gets my a stuck Xorg: [<ffffffff815704ac>] rpm_resume+0x18c/0x5c0 [<ffffffff81570928>] __pm_runtime_resume+0x48/0x70 [<ffffffffa00914af>] nouveau_drm_open+0x3f/0x230 [nouveau] [<ffffffff8144123d>] drm_open+0x1ad/0x4b0 [<ffffffff81447711>] drm_stub_open+0xb1/0x130 [<ffffffff811c6371>] chrdev_open+0xb1/0x190 [<ffffffff811bf702>] do_dentry_open.isra.18+0x1f2/0x320 [<fffffff...

...restore_standard_config+0x30/0x30 > [<ffffffff8137b6f6>] ? __rpm_callback+0x36/0x80 > [<ffffffff8137b768>] ? rpm_callback+0x28/0x90 > [<ffffffff8137c48d>] ? rpm_resume+0x39d/0x570 > [<ffffffff81071483>] ? __wake_up+0x43/0x70 > [<ffffffff8137c8f8>] ? __pm_runtime_resume+0x48/0x70 > [<ffffffffa020e5a2>] ? nouveau_drm_open+0x42/0x1d0 [nouveau] > [<ffffffff811bb858>] ? ext4_da_write_end+0xa8/0x2b0 > [<ffffffff811ef559>] ? jbd2_journal_stop+0x1d9/0x2c0 > [<ffffffff8124a56f>] ? apparmor_capable+0x1f/0x90 > [<ffffffffa00c5c...

...invalid_op+0x1f/0x90 ? asm_exc_invalid_op+0x16/0x20 ? nv50_display_init+0x28c/0x4f0 [nouveau] ? nv50_display_init+0x28c/0x4f0 [nouveau] ? sched_set_fifo+0x46/0x60 nouveau_display_init+0xa0/0xd0 [nouveau] nouveau_drm_device_init+0x42a/0x990 [nouveau] nouveau_drm_probe+0x105/0x240 [nouveau] ? __pm_runtime_resume+0x68/0xa0 pci_device_probe+0xaa/0x140 really_probe+0xc2/0x2d0 __driver_probe_device+0x73/0x120 driver_probe_device+0x2c/0xb0 __driver_attach+0xa0/0x150 ? __device_attach_driver+0xc0/0xc0 bus_for_each_dev+0x67/0xa0 bus_add_driver+0x10e/0x210 driver_register+0x5c/0x120 ? 0xffffffffa0336000...

...nouveau] [ 1295.046583] ? nouveau_svm_fault+0x13e0/0x13e0 [nouveau] [ 1295.051912] drm_ioctl_kernel+0x14d/0x1a0 [ 1295.055930] ? drm_setversion+0x330/0x330 [ 1295.059971] drm_ioctl+0x308/0x530 [ 1295.063384] ? drm_version+0x150/0x150 [ 1295.067153] ? find_held_lock+0xac/0xd0 [ 1295.070996] ? __pm_runtime_resume+0x3f/0xa0 [ 1295.075285] ? mark_held_locks+0x29/0xa0 [ 1295.079230] ? _raw_spin_unlock_irqrestore+0x3c/0x50 [ 1295.084232] ? lockdep_hardirqs_on+0x17d/0x250 [ 1295.088768] nouveau_drm_ioctl+0x9a/0x100 [nouveau] [ 1295.093661] do_vfs_ioctl+0x137/0x9a0 [ 1295.097341] ? ioctl_preallocate+0x140/0...

...nouveau] [ 1295.046583] ? nouveau_svm_fault+0x13e0/0x13e0 [nouveau] [ 1295.051912] drm_ioctl_kernel+0x14d/0x1a0 [ 1295.055930] ? drm_setversion+0x330/0x330 [ 1295.059971] drm_ioctl+0x308/0x530 [ 1295.063384] ? drm_version+0x150/0x150 [ 1295.067153] ? find_held_lock+0xac/0xd0 [ 1295.070996] ? __pm_runtime_resume+0x3f/0xa0 [ 1295.075285] ? mark_held_locks+0x29/0xa0 [ 1295.079230] ? _raw_spin_unlock_irqrestore+0x3c/0x50 [ 1295.084232] ? lockdep_hardirqs_on+0x17d/0x250 [ 1295.088768] nouveau_drm_ioctl+0x9a/0x100 [nouveau] [ 1295.093661] do_vfs_ioctl+0x137/0x9a0 [ 1295.097341] ? ioctl_preallocate+0x140/0...

Next version of https://patchwork.freedesktop.org/series/46815/ Same as previous version, but some small changes made to commit messages and acks/rbs have been added Lyude Paul (5): drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement drm/nouveau: Remove duplicate poll_enable() in pmops_runtime_suspend() drm/nouveau: Fix deadlock with fb_helper with async RPM requests

Latest version of https://patchwork.freedesktop.org/series/46815/ , with one small change re: ilia Lyude Paul (5): drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement drm/nouveau: Remove duplicate poll_enable() in pmops_runtime_suspend() drm/nouveau: Fix deadlock with fb_helper with async RPM requests drm/nouveau: Use pm_runtime_get_noresume() in connector_detect()

Latest version of https://patchwork.freedesktop.org/series/46815/ with some significant improvements: - I finally figured out a clean way to do this entirely with runtime PM helpers, no avoiding grabbing refs required! - Since this new method removes the need for a lot of the other changes I made (although we probably still want those changes, but not for fixing these deadlocks)

This is the latest version of https://patchwork.freedesktop.org/series/46815/ With a bunch of fixes to the new fb_helper to prevent it from breaking module loading/unloading with nouveau. Also; lots of documentation fixes and one fix in response to a kbuild bot. Lyude Paul (8): drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement drm/nouveau: Enable polling even if we have runtime