search for: __param_perm_check_

Displaying 11 results from an estimated 11 matches for "__param_perm_check_".

2014 Mar 17
2
[PATCH] virtio-blk: make the queue depth configurable
...> Erk, our tests are insufficient. Testbuilding an allmodconfig with this > now: Good idea. > diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h [] > @@ -188,6 +188,9 @@ struct kparam_array > /* Default value instead of permissions? */ \ > static int __param_perm_check_##name __attribute__((unused)) = \ > BUILD_BUG_ON_ZERO((perm) < 0 || (perm) > 0777 || ((perm) & 2)) \ > + /* User perms >= group perms >= other perms. */ \ > + + BUILD_BUG_ON_ZERO(((perm) >> 6) < (((perm) >> 3) & 7)) \ > + + BUILD_BUG_ON_ZERO((((per...
2014 Mar 17
2
[PATCH] virtio-blk: make the queue depth configurable
...> Erk, our tests are insufficient. Testbuilding an allmodconfig with this > now: Good idea. > diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h [] > @@ -188,6 +188,9 @@ struct kparam_array > /* Default value instead of permissions? */ \ > static int __param_perm_check_##name __attribute__((unused)) = \ > BUILD_BUG_ON_ZERO((perm) < 0 || (perm) > 0777 || ((perm) & 2)) \ > + /* User perms >= group perms >= other perms. */ \ > + + BUILD_BUG_ON_ZERO(((perm) >> 6) < (((perm) >> 3) & 7)) \ > + + BUILD_BUG_ON_ZERO((((per...
2014 Mar 14
2
[PATCH] virtio-blk: make the queue depth configurable
On Fri, Mar 14, 2014 at 10:38:40AM -0700, Joe Perches wrote: > > +static int queue_depth = 64; > > +module_param(queue_depth, int, 444); > > 444? Really Ted? Oops, *blush*. Thanks for catching that. - Ted
2014 Mar 14
2
[PATCH] virtio-blk: make the queue depth configurable
On Fri, Mar 14, 2014 at 10:38:40AM -0700, Joe Perches wrote: > > +static int queue_depth = 64; > > +module_param(queue_depth, int, 444); > > 444? Really Ted? Oops, *blush*. Thanks for catching that. - Ted
2014 Mar 19
5
[PATCH] virtio-blk: make the queue depth configurable
...gt;> > now: >> >> Good idea. >> >> > diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h >> [] >> > @@ -188,6 +188,9 @@ struct kparam_array >> > /* Default value instead of permissions? */ \ >> > static int __param_perm_check_##name __attribute__((unused)) = \ >> > BUILD_BUG_ON_ZERO((perm) < 0 || (perm) > 0777 || ((perm) & 2)) \ >> > + /* User perms >= group perms >= other perms. */ \ >> > + + BUILD_BUG_ON_ZERO(((perm) >> 6) < (((perm) >> 3) & 7)) \ >&g...
2014 Mar 19
5
[PATCH] virtio-blk: make the queue depth configurable
...gt;> > now: >> >> Good idea. >> >> > diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h >> [] >> > @@ -188,6 +188,9 @@ struct kparam_array >> > /* Default value instead of permissions? */ \ >> > static int __param_perm_check_##name __attribute__((unused)) = \ >> > BUILD_BUG_ON_ZERO((perm) < 0 || (perm) > 0777 || ((perm) & 2)) \ >> > + /* User perms >= group perms >= other perms. */ \ >> > + + BUILD_BUG_ON_ZERO(((perm) >> 6) < (((perm) >> 3) & 7)) \ >&g...
2014 Mar 17
0
[PATCH] virtio-blk: make the queue depth configurable
...building an allmodconfig with this > > now: > > Good idea. > > > diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h > [] > > @@ -188,6 +188,9 @@ struct kparam_array > > /* Default value instead of permissions? */ \ > > static int __param_perm_check_##name __attribute__((unused)) = \ > > BUILD_BUG_ON_ZERO((perm) < 0 || (perm) > 0777 || ((perm) & 2)) \ > > + /* User perms >= group perms >= other perms. */ \ > > + + BUILD_BUG_ON_ZERO(((perm) >> 6) < (((perm) >> 3) & 7)) \ > > + + BUIL...
2014 Mar 19
0
[PATCH] virtio-blk: make the queue depth configurable
...dea. >>> >>> > diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h >>> [] >>> > @@ -188,6 +188,9 @@ struct kparam_array >>> > /* Default value instead of permissions? */ \ >>> > static int __param_perm_check_##name __attribute__((unused)) = \ >>> > BUILD_BUG_ON_ZERO((perm) < 0 || (perm) > 0777 || ((perm) & 2)) \ >>> > + /* User perms >= group perms >= other perms. */ \ >>> > + + BUILD_BUG_ON_ZERO(((perm) >> 6) < (((perm)...
2014 Mar 17
0
[PATCH] virtio-blk: make the queue depth configurable
...g with this now: diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h index 175f6995d1af..626b85888a6b 100644 --- a/include/linux/moduleparam.h +++ b/include/linux/moduleparam.h @@ -188,6 +188,9 @@ struct kparam_array /* Default value instead of permissions? */ \ static int __param_perm_check_##name __attribute__((unused)) = \ BUILD_BUG_ON_ZERO((perm) < 0 || (perm) > 0777 || ((perm) & 2)) \ + /* User perms >= group perms >= other perms. */ \ + + BUILD_BUG_ON_ZERO(((perm) >> 6) < (((perm) >> 3) & 7)) \ + + BUILD_BUG_ON_ZERO((((perm) >> 3) &...
2014 Mar 19
1
[PATCH] virtio-blk: make the queue depth configurable
Couple more bikesheddy things: Is there ever a reason to use a non __builtin_const_p(perms)? Maybe that should be a BUILD_BUG_ON too BUILD_BUG_ON(!builtin_const_p_perms) My brain of little size gets confused by the BUILD_BUG_ON_ZERO(foo) + vs BUILD_BUG_ON(foo); as it just seems like more text for the same content. Is there any value on the "_ZERO(foo) +" I don't understand?
2014 Mar 19
1
[PATCH] virtio-blk: make the queue depth configurable
Couple more bikesheddy things: Is there ever a reason to use a non __builtin_const_p(perms)? Maybe that should be a BUILD_BUG_ON too BUILD_BUG_ON(!builtin_const_p_perms) My brain of little size gets confused by the BUILD_BUG_ON_ZERO(foo) + vs BUILD_BUG_ON(foo); as it just seems like more text for the same content. Is there any value on the "_ZERO(foo) +" I don't understand?