search for: __mark_inode_dirty

Hi Chris. I think it is needed to call mark_inode_dirty() when file size expands in order to flush metadata updates to HDD through sync() syscall or background_writeout(). Thanks. Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp> diff -Nrup linux-2.6.29-rc3.org/fs/btrfs/file.c linux-2.6.29-rc3/fs/btrfs/file.c --- linux-2.6.29-rc3.org/fs/btrfs/file.c 2009-02-02

...2b8e8f>] __down_failed+0x7/0xc > kernel: [<c016bb42>] .text.lock.namei+0x8/0x1e6 > kernel: [<c0167f35>] do_lookup+0x85/0x90 > kernel: [<c016872f>] __link_path_walk+0x7ef/0xdd0 > kernel: [<c0168d5e>] link_path_walk+0x4e/0xd0 > kernel: [<c017ce14>] __mark_inode_dirty+0x104/0x1b0 > kernel: [<c016907f>] path_lookup+0x9f/0x170 > kernel: [<c01693cf>] __user_walk+0x2f/0x60 > kernel: [<c0163b5d>] vfs_stat+0x1d/0x60 > kernel: [<c017ce14>] __mark_inode_dirty+0x104/0x1b0 > kernel: [<c0121a0f>] current_fs_time+0x5f/0x70 &...

...01fbf69>{journal_get_write_access+41} <ffffffff801ec41c>{ext3_reserve_inode+write+76} <ffffffff80195170>{filldir+0} <ffffffff801ec4d8>{ext3_mark_inode_dirty+56} <ffffffff801fa9e5>{journal_start_229} <ffffffff801ee571>{ext3_dirty_inode+113} <ffffffff801a5604>{__mark_inode_dirty+52} <ffffffff8019bd2b>{update_atime+123} <ffffffff80195016>{vfs_readdir+166} <ffffffff801952e2>{syst_getdents+130} <ffffffff8019465e>{sys_fcntl+830} <ffffffff8010dc46>{system_call+126} Code: 8b 40 18 48 c1 e0 07 48 8b 98 08 58 5b 80 4c 01 e3 48 89 df RIP <ffffffff8...

...rom a lightly editted "echo t > /proc/sysrq-trigger" output. A substantial number of nfsd threads a waiting to "start a handle": nfsd Call Trace: [sleep_on+75/124] [start_this_handle+205/368] [journal_start+149/196] [ext3_dirty_inode+116/268] [__mark_inode_dirty+50/168] [update_atime+75/80] [do_generic_file_read+1158/1172] [generic_file_read+147/400] [file_read_actor+0/224] [nfsd_read+477/636] [nfsd3_proc_read+295/388] [nfsd_dispatch+207/406] [svc_process+655/1264] [nfsd+566/944] [arch_kernel_thread+40/56] Thi...

...xternal usb storage formatted with JFS. Steps to reproduce: mkfs.jfs /dev/sdb1 (unpluggable USB hard drive) mount /dev/sdb1 /mnt/drive cd /mnt/drive touch test sync ..unplug a drive ls Result: BUG: unable to handle kernel NULL pointer dereference at 0000000000000020 IP: __mark_inode_dirty Then I got a kernel coredump. Here is a stack trace: (gdb) bt #0 __mark_inode_dirty (inode=0xffff880078fc1490, flags=<value optimized out>) at fs/fs-writeback.c:990 #1 0xffffffff810e4990 in mark_inode_dirty_sync (mnt=0xffff88007862fd00, dentry=<value optimized out>)...

...5a3c4 c9fa8ac0 Call Trace: [<c0171046>] journal_get_write_access+0xb/0x2d [<c016aa53>] ext3_reserve_inode_write+0x33/0x89 [<c016aac1>] ext3_mark_inode_dirty+0x18/0x31 [<c017082b>] journal_start+0x7f/0xa9 [<c016ab26>] ext3_dirty_inode+0x4c/0x5f [<c0156c20>] __mark_inode_dirty+0x24/0xce [<c01527d2>] inode_setattr+0x118/0x123 [<c016a951>] ext3_setattr+0xc9/0x104 [<c0152903>] notify_change+0xda/0x143 [<c013c6b9>] sys_utime+0xec/0x110 [<c013e5ad>] __fput+0xc2/0xde [<c013d251>] filp_close+0x5a/0x63 [<c013d2b2>] sys_close+0x58/...

...f75da800 c01615da Jul 4 20:53:14 localhost kernel: e5fa9640 f5a2e9a0 f6b55efc 00000000 e5fa9640 f5a2e9a0 f6d2ff80 f33b9380 Jul 4 20:53:14 localhost kernel: Call Trace: [ext3_reserve_inode_write+50/172] [start_this_handle+284/352] [ext3_mark_inode_dirty+26/52] [ext3_dirty_inode+163/276] [__mark_inode_dirty+50/188] Jul 4 20:53:14 localhost kernel: [update_atime+75/80] [link_path_walk+2038/2328] [path_walk+26/28] [__user_walk+53/80] [sys_stat64+25/112] [system_call+51/56] Jul 4 20:53:14 localhost kernel: Jul 4 20:53:14 localhost kernel: Code: f0 ff 8b 94 00 00 00 0f 88 17 15 00 00 6a 00 57 56...

...ite_access+0x53/0x78 [<c01695df>] ext3_do_update_inode+0x21f/0x3e0 [<c0169b15>] ext3_reserve_inode_write+0x31/0xb0 [<c0169ab5>] ext3_mark_iloc_dirty+0x21/0x50 [<c0169bbd>] ext3_mark_inode_dirty+0x29/0x34 [<c0169c9b>] ext3_dirty_inode+0xd3/0x14c [<c0154809>] __mark_inode_dirty+0x39/0xec [<c014fab4>] update_atime+0x8c/0x98 [<c0145b74>] link_path_walk+0x698/0x8c0 [<c0169ca7>] ext3_dirty_inode+0xdf/0x14c [<c0147e53>] vfs_follow_link+0x12f/0x1a4 [<c0170df6>] ext3_follow_link+0x16/0x20 [<c0145b81>] link_path_walk+0x6a5/0x8c0 [<c01...

...] :ext3:ext3_reserve_inode_write+0x38/0x90 Jan 8 05:20:01 localhost kernel: [<ffffffff8804dcee>] :ext3:ext3_mark_inode_dirty+0x21/0x3c Jan 8 05:20:01 localhost kernel: [<ffffffff88050b14>] :ext3:ext3_dirty_inode+0x63/0x7b Jan 8 05:20:01 localhost kernel: [<ffffffff8001349c>] __mark_inode_dirty+0x29/0x16e Jan 8 05:20:01 localhost kernel: [<ffffffff8804b5f5>] :ext3:ext3_new_blocks+0x567/0x693 Jan 8 05:20:01 localhost kernel: [<ffffffff80025273>] __bread+0x6/0x81 Jan 8 05:20:01 localhost kernel: [<ffffffff8804e46b>] :ext3:ext3_get_blocks_handle+0x43a/0x9f1 Jan 8 05:...

...] [<c014a11c>] [<c0129270>] [<c01366e6>] [<c0136a34>] [<c0106ffb>] Code: 0f 0b 83 c4 14 ff 43 08 eb 65 6a 01 68 f0 00 00 00 6a 14 68 >>EIP; c0165908 <journal_start+58/d0> <===== Trace; c016080e <ext3_dirty_inode+6e/100> Trace; c014b58e <__mark_inode_dirty+2e/a0> Trace; c012ae2d <generic_file_write+33d/780> Trace; c0130b83 <add_to_swap_cache+63/b0> Trace; c012db40 <do_ccupdate_local+0/40> Trace; c015060b <write_dquot+ab/100> Trace; c0150a50 <dqput+70/d0> Trace; c015196b <dquot_drop+3b/50> Trace; c014c03a <cle...

...1371 11348 (NOTLB) Call Trace: [<c0118ecb>] sleep_on [kernel] 0x4b [<f885d225>] start_this_handle [jbd] 0xc5 [<f885d37d>] journal_start_Rsmp_89deb980 [jbd] 0xbd [<f887297e>] ext3_dirty_inode [ext3] 0x6e [<c014ce7e>] link_path_walk [kernel] 0xa3e [<c0156f2e>] __mark_inode_dirty [kernel] 0x2e [<c01588b1>] update_atime [kernel] 0x51 [<c01303af>] do_generic_file_read [kernel] 0x48f [<c014d4c2>] __user_walk [kernel] 0x32 [<c013072e>] generic_file_read [kernel] 0x7e [<c01305b0>] file_read_actor [kernel] 0x0 [<c0141986>] sys_read [kerne...

...c015a039>] STACK TRACE FOR TASK: 0xe7ede000 (sendmail) 0 do_get_write_access+340 [0xc015fb48] 1 journal_get_write_access+52 [0xc015ff34] 2 ext3_do_update_inode+469 [0xc01599f9] 3 ext3_mark_iloc_dirty+29 [0xc0159e51] 4 ext3_mark_inode_dirty+36 [0xc0159f54] 5 ext3_dirty_inode+208 [0xc015a034] 6 __mark_inode_dirty+44 [0xc01464e4] 7 update_atime+70 [0xc0147a22] 8 do_generic_file_read+1105 [0xc012674d] 9 generic_file_read+124 [0xc0126a10] 10 sys_read+141 [0xc0133305] 11 system_call+44 [0xc0106e48] ebx: 00000004 ecx: 0810dc38 edx: 00001000 esi: 0810a0b9 edi: 3e65d011 ebp: bfff9a5c eax: 00000003 ds:...

...00000498 c015368f c70c2340 c3ad95a0 c47dbefc 00000000 c70c2340 00000498 Jun 29 11:30:05 ns kernel: Call Trace: [journal_dirty_metadata+324/356] [ext3_do_update_inode+763/920] [ext3_mark_iloc_dirty+33/72] [ext3_mark_inode_dirty+41/52] [ext3_dirty_inode+134/196] Jun 29 11:30:05 ns kernel: [__mark_inode_dirty+46/120] [generic_file_write+808/1864] [do_getitimer+156/164] [ext3_file_write+70/76] [sys_write+146/224] [system_call+51/56] Jun 29 11:30:05 ns kernel: Jun 29 11:30:05 ns kernel: Code: 0f 0b 83 c4 14 90 8d 74 26 00 8b 43 14 39 f0 74 29 85 c0 74 this apeared in our log after that the load went...

....4.17/kernel/net/unix/unix.o_M+-1642892/96] [unix:__insmod_unix_O/lib/modules/2.4.17/kernel/net/unix/unix.o_M+-1656581/96] [unix:__insmod_unix_O/lib/modules/2.4.17/kernel/net/unix/unix.o_M+-1608504/96] [unix:__insmod_unix_O/lib/modules/2.4.17/kernel/net/unix/unix.o_M+-1608260/96] [filldir+174/224] [__mark_inode_dirty+46/160] [update_atime+81/96] [unix:__insmod_unix_O/lib/modules/2.4.17/kernel/net/unix/unix.o_M+-1627672/96] [open_namei+805/1680] [dentry_open+171/400] [kfree_skbmem+12/112] [filldir+0/224] [vfs_readdir+126/208] [filldir+0/224] [sys_getdents+71/160] [filldir+0/224] [system_call+51/56] Code:...

...8021A4 018031A0 01804C00 01804FDC 0180578C 00000000 >>NIP; c0080424 <journal_blocks_per_page+148/e4f8> <===== Trace; c0080384 <journal_blocks_per_page+a8/e4f8> Trace; c0076440 <journal_start+ac/3a8> Trace; c006f998 <grok_partitions+9358/fd54> Trace; c0055650 <__mark_inode_dirty+4c/948> Trace; c0057394 <update_atime+64/74> Trace; c0029c18 <do_generic_file_read+4d0/8b4> Trace; c002a08c <generic_file_read+90/8bc> Trace; c0045fc4 <kernel_read+58/354> Trace; c00466a8 <prepare_binprm+100/114> Trace; c0046dec <do_execve+17c/290> Trace; c000...

I had the following spat out by syslog on my (2.4.18-pre7-ac3) mailer / web server: Assertion failure in do_get_write_access() at transaction.c:611: "!(((jh2bh(jh))->b_state & (1UL << BH_Lock)) != 0)" One of its partitions froze hard--I've rebooted it, and I have an oops which the BUG() triggered which won't decode at the moment, but I'll sort that one out

hello! i'm using redhat 7.2 with ext3 as my primary fs on kernel 2.4.17 + grsecurity + acl after 2-3 days of uptime i'm expiriencing problems... i attached below excert from my system logs. machine stops responing for a few seconds and after then it looks, like it's in normal operation again. the only problem is load, which is incrementing constantly, but cpu is 99% idle... after

...:ext3_mark_iloc_dirty+740} Dec 18 03:18:09 data3 kernel: <ffffffffa0052a14>{:ext3:ext3_mark_inode_dirty+65} Dec 18 03:18:10 data3 kernel: <ffffffffa003c4c6>{:jbd:journal_start+223} <ffffffffa0054726>{:ext3:ext3_dirty_inode+99} Dec 18 03:18:10 data3 kernel: <ffffffff8018fef0>{__mark_inode_dirty+40} <ffffffff80189748>{inode_update_time+182} Dec 18 03:18:10 data3 kernel: <ffffffff80155b7b>{generic_file_aio_write_nolock+620} Dec 18 03:18:10 data3 kernel: <ffffffff80155c9c>{generic_file_aio_write+126} <ffffffffa004fed0>{:ext3:ext3_file_write+22} Dec 18 03:18:10 data3 k...

...ernel: cda5e900 c3739e80 c0152617 c3739e80 00000000 c0158935 cbc83930 00000000 Apr 17 21:40:13 mofo kernel: c313bc90 cdcc7a40 ca39fec0 ccd18ec0 cda5e900 cc283600 00000007 c013e3ce Apr 17 21:40:13 mofo kernel: Call Trace: [ext3_dirty_inode+199/256] [journal_get_undo_access+245/288] [__mark_inode_dirty+46/144] [ext3_new_block+112/1936] [journal_cancel_revoke+251/368] Apr 17 21:40:13 mofo kernel: Call Trace: [<c0152617>] [<c0158935>] [<c013e3ce>] [<c014d370>] [<c015ca9b>] Apr 17 21:40:13 mofo kernel: [do_get_write_access+1183/1216] [journal_dirty_metadata+398/432...

...rnal_enable_debug+651/5be5> Trace; f88b5063 <[jbd]__ksymtab_journal_enable_debug+1f/28> Trace; f88b4ff4 <[jbd]__ksymtab_journal_ack_err+0/8> Trace; f88b5da0 <[jbd]__kstrtab_journal_enable_debug+811/5be5> Trace; f88c4bc0 <[ext3]ext3_dirty_inode+160/180> Trace; c0157ff5 <__mark_inode_dirty+b5/4e0> Trace; c0131f7a <generic_file_write+2ba/2bb0> Trace; c01de57f <scsi_io_completion+16f/850> Trace; c0138bb5 <free_pages+535/27c0> Trace; f88bf0c9 <[ext3]ext3_file_write+39/d0> Trace; c015e991 <seq_printf+f01/a9c0> Trace; c015ee7c <seq_printf+13ec/a9c0>...